Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index 

On Fri, 2010-11-26 at 14:12 +0100, Joachim Trémouroux wrote:

Pierre-André,

Are you sure it is safe to remove the OpenFlagRec() call ?


Indeed, good catch Joachim. The warning is that the ret value of
OpenFlagRec is unused, looking closed at OpenFlagRec you'll see that it
extracts a value from the underlying stream, so that stream is advanced
by 2 bytes, dropping the call would change that logic. The right fix is
to just drop the BYTE cDFlags =. 

I've fixed this now. Michael has already pushed the remainder of this
patch at least.

C.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.