[Libreoffice] [PATCH] [PUSHED, partial] Commented-out code for the day

Kohei Yoshida <kyoshida -AT- novell.com>
Mon, 08 Nov 2010 10:59:53 -0500

On Mon, 2010-11-08 at 00:53 +0200, Ricardo Moreno wrote:

here is more commented code removal.


Reviewed and applied the part against the 'sc' module.  Thanks a lot!

I removed everything except for the one in sc/inc/compiler.hxx (below).

@@ -101,13 +101,6 @@ class ScTokenArray;
                                                                                                    
                                                                                                 
 // constants and data types internal to compiler                                                   
                                                                                                 
                                                                                                    
                                                                                                 
-/*                                                                                                 
                                                                                                 
-    OpCode   eOp;           // OpCode                                                              
                                                                                                 
-    formula::StackVar eType;         // type of data                                               
                                                                                                 
-    USHORT   nRefCnt;       // reference count                                                     
                                                                                                 
-    BOOL     bRaw;          // not cloned yet and trimmed to real size                             
                                                                                                 
- */                                                                                                
                                                                                                 
-                                                                                                   
                                                                                                 
 #define SC_TOKEN_FIX_MEMBERS    \                                                                  
                                                                                                 
     OpCode   eOp;               \                                                                  
                                                                                                 
     formula::StackVar eType;    \                     

That comment there was clearly used to annotate the defined macros
immediately below it, so I considered it'd be better to keep that one.

The other parts of your patch have not been reviewed yet.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>

Context

[Libreoffice] [libreoffice] [PATCH] Commented-out code for the day · Ricardo Moreno
- Re: [Libreoffice] [libreoffice] [PATCH] Commented-out code for the day · Norbert Thiebaud
- [Libreoffice] [PATCH] [PUSHED, partial] Commented-out code for the day · Kohei Yoshida
- [Libreoffice] [PATCH] [PUSHED, partial] Commented-out code for the day · Kohei Yoshida
- Re: [Libreoffice] [libreoffice] [PATCH] Commented-out code for the day · Kohei Yoshida

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.