Re: [Libreoffice] [PUSHED] EasyHack RTL_CONSTASCII_USTRINGPARAM in sc

On Tue, 2010-11-02 at 09:45 +0000, Caolán McNamara wrote:
> On Mon, 2010-11-01 at 22:27 -0400, Kohei Yoshida wrote:
> > Hello Joost,
> >
> > Thanks for the patch.  Just pushed to the master branch. :-)
>
> Nothing to do with the patch, but I see a ConvertCountryCode which,
> depending on what it does, might be a candidate to be moved into
> i18npool/source/isolang beside the rest of the code that handles
> conversion to/from iso language names.

That function appears to return a numerical value representing a country
code from the country code string, and the values appear to be specific
to the VBA layer.  So, from what I can see we can't move this into
i18npool/source/isolang since the value set likely differ from the one
that we use internally.  However, it *may* make sense to move it to
somewhere common among all VBA implementations (Calc and Writer) if the
country code set is identical between Writer's and Calc's
implementations.

CC'ing Noel here since he is the expert on this.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>