Re: [Libreoffice] [PUSHED] Re: [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM in starmath

Hi there,

On Sat, 2010-10-30 at 22:24 +0100, Caolán McNamara wrote:
> > This changes the only occurrence in writer/starmath.
>
> Thanks, Hmm, an empty string. I wonder why it using ::createFromAscii
> for the empty string case. I suggest that...

        Interesting question that needs testing. Since OUString() just gives
you a new reference counted pointer to a singleton 'empty string'
string ;-)

        Perhaps the hash is relying on a different pointer value there ? [ too
lazy to read it just now but ... ;-]

> Digging for UNOOUSTRING I see that indeed it is a define for
> rtl::OUString, i.e.
> (http://opengrok.go-oo.org/xref/libs-core/sfx2/inc/sfx2/sfxuno.hxx#71)
..
> so yes they can be replaced as well. I think I'd prefer to see them
> replaced with rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(... instead of 

        I hope eventually, when we have in-line strings fixed up - we will have
a rather shorter macro to instantiate strings ;-)

        HTH,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot