Re: [Libreoffice] First time Build issues on Ubuntu

Hi,

On Fri, Oct 29, 2010 at 3:04 PM, Caolán McNamara <caolanm@redhat.com> wrote:
> On Fri, 2010-10-29 at 09:34 +0530, surenspost@gmail.com wrote:
> > I am new to Libreoffice and I was trying to build Libreoffice for the
> > first time. I ended up with this error - [1]. I figured it might be
> > because the file might not have included algorithm as the
> > 'lower_bound' function that was said missing is provided by algorithm
> > header. I naively added a
> >
> > <snip>
> > #include<algorithm>
> > using namespace std
> > </snip>
> >
> > to .../build/build/libreoffice-3.2.99.2/forms/source/component/GroupManager.hxx
> > and the build worked. And right now proceeding with the build further.
>
> Right, yes #include <algorithm> was the right fix. I pushed that last
> night, so it should be good now. You're instincts were correct.
>
> > But I am not sure this is the right way of doing it as I believe we
> > are using stlports and that would mean algorithm should come from
> > stlports and now from system provided STL. Please do advice how to
> > proceed to get it fixed.
>
> Nah, Ignore the stl implementation behind the curtain (For linux its
> only behind the curtain for x86 anyway). You generally don't need to
> worry about doing anything special for the stlport using ports, just
> #include <thenormalname> and its all taken care of, so indeed #include
> <algorithm> is good.
>
> C.

Thanks for the response and fix. Meanwhile I had got the actual commit
which introduced the break and raised the bug against the committer.
Will close the bug as well.

-- 
regards
Suren