On Fri, Oct 22, 2010 at 09:40:34AM -0400, Kevin Hunter wrote:
Have you enumerated everywhere this is used (in the code base). At
the moment, I'm having a difficult time seeing the use (both
logically and usefully) of a macro that defines a single space. At
the point you're basically castrating that macro, why not just
remove it entirely?
As they say, "code removed is code debugged," and we've already
experienced some confusion over the handling of the use-related
__PRETTY_FUNCTION__ non-macro.
I'd like to get some feedback if someone is interested in converting
this to use the language identifiers before making it harder by
removing the macro completely.
A short grep shows it is used in
clone/ure/sal/inc/osl/diagnose.h
clone/writer/sw/source/filter/ww8/ (multiple files)
rawbuild/writerfilter/source/filter/RtfFilter.cxx
patches/dev300/oox-import-comments-fix-add-annotation.diff
If there's consensus, I can remove it completely.
Thomas
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.