Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal

Cédric Bosdonnat <cedric.bosdonnat.ooo -AT- free.fr>
Wed, 13 Oct 2010 23:02:44 +0200

Hi Jacek,

I removed a hunk that wasn't valid, but otherwise, the patch looks good
to me. I've pushed it.

Many thanks for your help!

--
Cedric

On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote:

Hi, 

As in the topic. I replaced some assert items with OSL equivalents.
I also replaced #ifdef DBG_UTIL with #if OSL_DEBUG_LEVEL > 1 in
accordance with some findings in opengrok and
http://wiki.services.openoffice.org/wiki/Debug_Levels. 

Some additional questions. What should I replace DBG_ERROR with?

Should RTL_LOGFILE_CONTEXT_AUTHOR as in http://bit.ly/buiBlA be updated
somehow as it contains a lot of hardcoded e-mail addresses?

Regards,

Jacek
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Context

[Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal · Jacek Wolszczak
- Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal · Cédric Bosdonnat
- Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal · Caolán McNamara
  - Re: [Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal · David Tardon

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.