Re: [Libreoffice] [PATCH] printf without format considered harmful

On Mon, Oct 4, 2010 at 4:57 AM, Michael Meeks <michael.meeks@novell.com> wrote:
> Hi Norbert,
>
> On Sun, 2010-10-03 at 14:24 -0500, Norbert Thiebaud wrote:
> > [PATCH] printf without format considered harmful
>
>        Great patch :-) good to know that that is cleaned up globally. Glad to
> see Cedric committed it already.
>
> > -                printf( ByteString( aPrintMsg, RTL_TEXTENCODING_UTF8
> > ).GetBuffer() );
> > +                printf( "%s", ByteString( aPrintMsg,
> > RTL_TEXTENCODING_UTF8 ).GetBuffer() );
>
>        Line wrapping is a bit of a pain in patch mails though ;-)

Sorry about that. I need to learn how to manage a patch-based
workflow... I'll switch to attached file for the next patches, see if
that works better.

>        ATB,
>
>                Michael.
>
> PS. you seem to have a gold-mine of easy-type hacks up your sleeve, any
> chance you could add some of these to the wiki page and leave them for
> the less obviously competant ? :-)

I'm not following....
Maybe you're giving me too much credit: All  I did was to read the
warning the compiler spouted out and get rid of them....



> --
>  michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot