Re: [Libreoffice] [PATCH] printf without format considered harmful

Michael Meeks <michael.meeks -AT- novell.com>
Mon, 04 Oct 2010 10:57:50 +0100

Hi Norbert,

On Sun, 2010-10-03 at 14:24 -0500, Norbert Thiebaud wrote:

[PATCH] printf without format considered harmful


        Great patch :-) good to know that that is cleaned up globally. Glad to
see Cedric committed it already.

-                printf( ByteString( aPrintMsg, RTL_TEXTENCODING_UTF8
).GetBuffer() );
+                printf( "%s", ByteString( aPrintMsg,
RTL_TEXTENCODING_UTF8 ).GetBuffer() );


        Line wrapping is a bit of a pain in patch mails though ;-)

        ATB,

                Michael.

PS. you seem to have a gold-mine of easy-type hacks up your sleeve, any
chance you could add some of these to the wiki page and leave them for
the less obviously competant ? :-)
-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot

Context

[Libreoffice] [PATCH] printf without format considered harmful · Norbert Thiebaud
- Re: [Libreoffice] [PATCH] printf without format considered harmful · Cédric Bosdonnat
- Re: [Libreoffice] [PATCH] printf without format considered harmful · Michael Meeks
  - Re: [Libreoffice] [PATCH] printf without format considered harmful · Norbert Thiebaud

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.