Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


The patch is very large (almost 1M), because both BOOL and sal_Bool
are defined as unsigned char, and of course bool is... a boolean.
The C++ compiler doesn't like a virtual funciton declared as returning
a unsigned char and re-implemented returnuing a bool.
So it is an all or nothing operation.

one way to do that is phase would be:

1/ introduce a new typedef TBOOL as unsigned char
2/ do many small patchs to migrate the BOOL and sal_BOOL impacted by
this patch to TBOOL
3/ a patch to change the typedef of TBOOL to bool
4/ another series of patch to change TBOOL to bool
5/ remove the TBOOL typdedef

So if this big patch can go, that would be much simpler.

the patch is at:
https://bugs.freedesktop.org/show_bug.cgi?id=30556

Norbert Thiebaud

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.