Re: [Libreoffice] [PATCH 1/3] Janitorial work. remove commented-out code

On Tue, Sep 28, 2010 at 08:42:00PM -0500, Norbert Thiebaud wrote:
> Here are 3 small patches that do simple 'commented-out code' clean-up.
>
> I don't know if bigger patches are favored. It seems that smaller patches
> would make the maintainer 's job easier...
> but too many of these may pollute the history... either way let me know how
> you would prefer theses...
>
> I generated the patches with git format-patch. If there are prefered
> options, method.. please let me know (or RTFM me - with a link to TFM :-)
>
> Norbert Thiebaud
>
>
> From a03c2d0a1ba37747a4b1993a141fb17dbb13d714 Mon Sep 17 00:00:00 2001
> From: Norbert Thiebaud <nthiebaud@gmail.com>
> Date: Tue, 28 Sep 2010 20:06:49 -0500
> Subject: [PATCH 1/3] Janitorial work. remove commented-out code
>
> ---
>  sc/inc/hints.hxx              |    1 -
>  sc/source/core/tool/hints.cxx |    5 -----
>  2 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/sc/inc/hints.hxx b/sc/inc/hints.hxx
> index 5ff21e8..e5b0fe4 100644
> --- a/sc/inc/hints.hxx
> +++ b/sc/inc/hints.hxx
> @@ -93,7 +93,6 @@ class ScPointerChangedHint : public SfxHint
>  public:
>                      TYPEINFO();
>
> -//UNUSED2008-05     ScPointerChangedHint( USHORT nF );
>                      ~ScPointerChangedHint();
>
>      USHORT                     GetFlags() const                        {
> return nFlags; }
> diff --git a/sc/source/core/tool/hints.cxx b/sc/source/core/tool/hints.cxx
> index 4ca62d8..677a726 100644
> --- a/sc/source/core/tool/hints.cxx
> +++ b/sc/source/core/tool/hints.cxx
> @@ -79,11 +79,6 @@ ScUpdateRefHint::~ScUpdateRefHint()
>  //      ScPointerChangedHint - Pointer ist ungueltig geworden
>  // -----------------------------------------------------------------------
>
> -//UNUSED2008-05  ScPointerChangedHint::ScPointerChangedHint( USHORT nF ) :
> -//UNUSED2008-05      nFlags( nF )
> -//UNUSED2008-05  {
> -//UNUSED2008-05  }
> -
>  ScPointerChangedHint::~ScPointerChangedHint()
>  {
>  }
> -- 
> 1.7.1

Hi,

it looks good, but you're too late :( See Justin's mail and
https://bugs.freedesktop.org/show_bug.cgi?id=30442 .

D.