[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[libreoffice-design] Fwd: Rework of Writer comments "button"


Please CC libreoffice-design@lists.freedesktop.org on replies. I didn't check the mail address.

-------- Originalnachricht --------
Betreff: Rework of Writer comments "button"
Datum: 11.07.2019 17:21
Von: Jan-Marek Glogowski <glogow@fbihome.de>
An: libreoffice@lists.freedesktop.org, libreoffice-design@lists.freedesktop.org

Hi everybody,

an other query for a different problem :-)

While fixing tdf#126333 (https://bugs.documentfoundation.org/show_bug.cgi?id=126333) I found the current behavior of that pseudo button quite annoying. Not only forces it a repositioning of the displayed document, which probably can't be avoided, but it also moves the text and arrow of the button around.

So now there is as WIP / RfC: https://gerrit.libreoffice.org/#/c/75421/

* cleanup code
* handle the arrow like a tree view
* > = collapsed, v = expanded
* keeping the position of the arrow in front of the text
* no more shifting of the text and arrow in the button
* replace many static values with (correct?) dynamic ones
* use highlight colors for mouse over

I tried to use the DecorationView::DrawButton, but that didn't work. I'm not sure this is even the right interface.

But there is still one major problem left: positioning of the button text in RTL. If you start LO with LANG=ar, the button text and arrow aren't visible, because they are outside of the view. As a workaround I left-aligned them together in case of collapsed comments in RTL in the patch.

But the problem would go away, if Writer would mirror the position of the comments too and would also show the button on the left side in RTL.

* How do other programs display comments when in RTL mode?
* Do you think moving the comments to the right is a good idea for RTL?
* I hope moving the "button" and comments wouldn't be that hard. Anyone knows that code and can comment on that?
* Is there a better way to draw this "button"?
* Any other opinions on the patch?
* Any option on the changed behavior?

Thanks

Jan-Marek

--
To unsubscribe e-mail to: design+unsubscribe@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/design/
Privacy Policy: https://www.documentfoundation.org/privacy

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.