[libreoffice-design] Unify position and size of color bar inside icons

Hi all,

there exist several icons, where the current chosen color is drawn as 
color bar on top of the initial icon. The effected icons belong to the 
following .uno: commands:
Color, CharBackColor, Extrusion3DColor, FrameLineColor, XLineColor, 
FillColor, FrameLineColor, FontColor, BackColor, and BackgroundColor.

While I'm working on 
https://bugs.documentfoundation.org/show_bug.cgi?id=84985 I come across 
some general problems:

(a) In the place, where this is calculated, the size of the icon is 
known, but not the icon-theme.
(b) The size of the large icons is different for the themes, and 
sometimes different inside a theme (the later I consider an error of the 
theme). Small icons are all 16 pixel. But for large icons we have:
22 pixel: (crystal), oxygen
24 pixel: breeze, (elementary), (human), (industrial), sifr, tango
26 pixel: galaxy, highcontrast
(c) The ranges for the color bar in the initial icon and in the update 
are different. Main problems:
The position of the updated color area is off by one compared with the 
initial area.
The initial area is 1 pixel right and left smaller than the updated area.
Some color bars are not bottom aligned.


I would like to unify the color bar in this way:
(1) Calculate the height of the color bar as icon-height/4, rounded 
down. (as current implementation) This results in:
icon 16 pixel height -> color bar height 4 pixel
icon 22 pixel height -> color bar height 5 pixel
icon 24 pixel height -> color bar height 6 pixel
icon 26 pixel height -> color bar height 6 pixel

(2) Make all color bars as wide as the icon (as current implementation).

(3) Position the color bar so, that it aligns with the bottom of the 
icon. (new)

Do you agree with this approach?

If yes, then I would like to adapt the existing icons in case some parts 
of the initial icon would be visible, as in the mentioned issue 
tdf#84985. Do you agree?


Kind regards
Regina

--
To unsubscribe e-mail to: design+unsubscribe@global.libreoffice.org
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/global/design/
All messages sent to this list will be publicly archived and cannot be deleted