Re: [libreoffice-design] Re: Rule Colors - Color Change Needs Review

Hi Stuart, *,

On Thu, Dec 10, 2015 at 7:36 PM, V Stuart Foote <VStuart.Foote@utsa.edu> wrote:
> Not sure who told you to try to do it as a single color, but I think your
> approach needs some additional thought.

That was likely bad wording in the initial post. What was meant is not
to try to detect the theme variant in the code that applies the colors
to the ruler, but rather just use one of the available (and taken from
the desktop-style or fallback-defaults) colors and rely on the
combinations of colors to be readable.

> I just checked and the Rulers **are** controlled by style.

> svtools/source/control/ruler.cxx
> #695
>
>    GetFaceColor
>    GetLightColor
>    GetShadowColor
>    GetDarkShadowColor

exactly. but it uses a darkshadow color on another shadow color -
which works in light theme, but fails on dark.

> Meaning, rather than a fixed color--with refined control of the colors
> specified as style defaults loaded into the struct it should allow better
> settings on generally Dark, or Light, or HighContrast, user interfaces.

It is not hard-coded/fixed color - only in the sense that if the
corresponding theme integration doesn't provide a different value, the
builtin default will be used.
(and in the case of the variant Joel picked it is not explicitly
overriden by the GTK plugin for example, so LO's default will be used)

@Joel:
" I changed DarkShadowColor (which is worthless for dark themes) to
DeactivatedColor (light gray)."

hope to Deactive*Text*Color :-)

ciao
Christian

-- 
To unsubscribe e-mail to: design+unsubscribe@global.libreoffice.org
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/global/design/
All messages sent to this list will be publicly archived and cannot be deleted