Re: [pt-br-dev] Fwd: [PATCH] Removel ::rtl:: prefixes and macros in oox

Olá José Guilherme

1) oox/source/export/chartexport.cxx

sal_Int32 lcl_getChartType( const OUString& sChartType )
{
chart::TypeId eChartTypeId = chart::TYPEID_UNKNOWN;
if(( 0 == sChartType.reverseCompareToAsciiL( RTL_CONSTASCII_STRINGPARAM(
"com.sun.star.chart.BarDiagram" )))
|| ( 0 == sChartType.reverseCompareToAsciiL(
RTL_CONSTASCII_STRINGPARAM("com.sun.star.chart2.ColumnChartType") ) ) )
eChartTypeId = chart::TYPEID_BAR;
else if(( 0 == sChartType.reverseCompareToAsciiL(
RTL_CONSTASCII_STRINGPARAM( "com.sun.star.chart.AreaDiagram" )))
|| ( 0 == sChartType.reverseCompareToAsciiL(
RTL_CONSTASCII_STRINGPARAM("com.sun.star.chart2.AreaChartType") ) ) )
eChartTypeId = chart::TYPEID_AREA;
else if(( 0 == sChartType.reverseCompareToAsciiL(
RTL_CONSTASCII_STRINGPARAM( "com.sun.star.chart.LineDiagram" )))


eu usaria
0 == sChartType.reverseCompareTo("bla bla bla")

(http://api.libreoffice.org/docs/cpp/ref/classrtl_1_1_o_u_string.html)

2) Na linha  513
 aRange.SearchAndReplaceAllAscii(".$", rtl::OUString("!$") );

deveria ser

aRange = aRange.replaceAll(".$", "!$" );


3) em oox/source/export/drawingml.cxx
linha 406: eu deixaria como estava

4) Linha 1458: pode ser usado ==, verifique o tipo de rFontDesc.Name

Abraços

Olivier


Em 14-12-2012 00:42, José Guilherme Vanz escreveu:
> ---------- Forwarded message ----------
> From: "José Guilherme Vanz (via Code Review)" <gerrit@gerrit.libreoffice.org
> >
> Date: Dec 14, 2012 12:20 AM
> Subject: [PATCH] Removel ::rtl:: prefixes and macros in oox
> To:
> Cc: "LibreOffice Developer List" <libreoffice@lists.freedesktop.org>
>
> Hi,
>
> I have submitted a patch for review:
>
>     https://gerrit.libreoffice.org/1335
>
> To pull it, you can do:
>
>     git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/1335/1
>
> Removel ::rtl:: prefixes and macros in oox
>
> This commit removes ::rtl:: prefixes, macros and replace old String class
> in oox
>
> Change-Id: I2672c859a45bc1221415479218c352bab4fe9b1a
> Signed-off-by: José Guilherme Vanz <guilherme.sft@gmail.com>
> ---
> M oox/source/export/ColorPropertySet.cxx
> M oox/source/export/ColorPropertySet.hxx
> M oox/source/export/SchXMLSeriesHelper.cxx
> M oox/source/export/chartexport.cxx
> M oox/source/export/drawingml.cxx
> M oox/source/export/shapes.cxx
> M oox/source/export/vmlexport.cxx
> 7 files changed, 56 insertions(+), 76 deletions(-)
>
>
> --
> To view, visit https://gerrit.libreoffice.org/1335
> To unsubscribe, visit https://gerrit.libreoffice.org/settings
>
> Gerrit-MessageType: newchange
> Gerrit-Change-Id: I2672c859a45bc1221415479218c352bab4fe9b1a
> Gerrit-PatchSet: 1
> Gerrit-Project: core
> Gerrit-Branch: master
> Gerrit-Owner: José Guilherme Vanz <guilherme.sft@gmail.com>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
Olivier Hallot
Comunidade LibreOffice

-- 
Você está recebendo e-mails da lista dev@pt-br.libreoffice.org
# Informações sobre os comandos disponíveis (em inglês):
  mande e-mail vazio para dev+help@pt-br.libreoffice.org
# Cancelar sua assinatura: mande e-mail vazio para:
  dev+unsubscribe@pt-br.libreoffice.org
# Arquivo de mensagens: http://listarchives.libreoffice.org/pt-br/dev