guilherme.sft@gmail.com wrote:
This patch removes '@author' annotation, code in comments
and adjust some empty catches. It's cleanup patch
Hi José Guilherme,
partially pushed - I left the hunks commenting empty methods as
FIXME instead of removing them straight away unapplied. If the
method is pointless, why not remove them in one go?
I also did not apply your printStackTrace() logging calls, I think
at least some of them report on exceptions that were seemingly
previously ignored on purpose?
Stephan, or anyone else more up-to-date with contemporary java
idiom, any opinions here?
Thanks for the nice cleanup anyways! :)
Cheers,
-- Thorsten
--
Você está recebendo e-mails da lista dev@pt-br.libreoffice.org
# Informações sobre os comandos disponíveis (em inglês):
mande e-mail vazio para dev+help@pt-br.libreoffice.org
# Cancelar sua assinatura: mande e-mail vazio para:
dev+unsubscribe@pt-br.libreoffice.org
# Arquivo de mensagens: http://listarchives.libreoffice.org/pt-br/dev
Context
- [pt-br-dev] [PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code · Thorsten Behrens
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.