Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


Here's a patch for the salt repo's README.md.

A potential area of improvement would be to include modules to avoid/encourage, whether all files should have 'managed by salt' at the top, and other editing guidelines.

I also made some assumptions and just put some policy in the "Contributing to This Repository" section: I figure an actual policy could be added there (if there needs to be any at all).

A few questions came up while familiarizing myself with the repository:

1) Would the contents of "certs/" be better off in pillar rather than the salt repo?

2) The 'security/' folder is a bit vague. Would it make sense to move the sole .sls file (rpcbind.sls) into its own 'rpcbind' folder?

3) What is the purpose of having the Github repository as a submodule to the Gitlab repository? Is it for compatibility reasons while it gets ported over to the infratools site? I couldn't run anything from tests/ before fetching the submodules... and `git submodule update --init` fails due to a non-existent referenced commit.

Due to the above confusion I left out mention of how to best perform testing in the README.

I can happily continue contributing patches, but I believe it might be easier if I had the capability to introduce PRs and create my own branches.

Hope this helps!

--
To unsubscribe e-mail to: website+unsubscribe@global.libreoffice.org
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/global/website/
All messages sent to this list will be publicly archived and cannot be deleted

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.