https://bugs.documentfoundation.org/show_bug.cgi?id=49033
V Stuart Foote <vstuart.foote@utsa.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |needsUXEval
CC| |libreoffice-ux-advise@lists
| |.freedesktop.org
--- Comment #45 from V Stuart Foote <vstuart.foote@utsa.edu> ---
To UX-Advise to move this forward...
But my take remains that the original implementation applying the
SENTENCE_CASE, via ICU transliteration, needs additional control logic.
Believe we need to handle two cases for applying SENTENCE_CASE in edit engine
[1].
1) Case -- an active selection made:
expand only to the ICU -word boundaries- that hold the selection and apply
ICU transliteration. Treat that "temp" string as the sentence--and apply
transliteration. Since the transliteration of the selection likely cross
sentence boundaries, would need to break selection into multiple "temp" strings
(an opening, middle(s), a closing)--but honor the selections at the word
boundaries as the range.
2) Case -- only text cursor focus, no selection made:
expand only to the ICU -sentence boundaries- that hold the text cursor and
apply ICU transliteration.
The current implementation for sentence case always performs the expansion when
applying SENTENCE_CASE transliteration, with or without selection--that's the
issue. Current implementation probably could/should be retained for a no
selection case, but need to provide new code for the with selection handling.
=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit4.cxx?r=492ea7e0#2665
--
You are receiving this mail because:
You are on the CC list for the bug.
Context
- [Libreoffice-ux-advise] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20) · bugzilla-daemon
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.