Re: [Libreoffice-ux-advise] Page break indicator and RTL

Thank you very much for the fix, I'll test it as soon as it will hit the
3.5 daily builds (after you'll do the branch commit).

Kaplan

On Fri, Dec 16, 2011 at 6:04 PM, Cedric Bosdonnat <cbosdonnat@suse.com>wrote:

> Hi Lior, all,
>
> A fix for the RTL PopupButton is landing in master (and soon in 3.5
> branch). Don't hesitate to stress it a lot (and not only the Page break
> feature as it affects the whole office).
>
> Here is the commit:
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=f6b679e831ebf4a85b3baf37ea0198959f58fa1f
>
> Regards,
> --
> Cedric
>
> On Thu, 2011-12-15 at 11:38 +0200, Lior Kaplan wrote:
> > On Thu, Dec 15, 2011 at 11:23 AM, Cedric Bosdonnat
> > <cbosdonnat@suse.com> wrote:
> >         Hi all,
> >
> >         Lior reported a problem with the positioning of the page break
> >         indicators in RTL UI [0]. I can't really find a cool solution
> >         on how to
> >         place that control to fit all cases like
> >          * RTL UI / LTR document
> >          * RTL UI / RTL document
> >          * LTR UI / LTR document
> >          * LTR UI / RTL document
> >
> > In this case, I don't think the directionality of the document is
> > relevant, only the UI's directionality, we're talking about two
> > options:
> > * LTR UI - already done
> > * RTL UI - location should be mirrored, as most of the UI elements.
> >
> >
> >         In single page view I don't mind moving the control to the
> >         right, but
> >         we'll face problems for book view. We will also have troubles
> >         with the
> >         popup menu for LTR document / UI and book mode when the
> >         control is on
> >         the right.
> >
> > For book view, the current behavior of the marker location should be
> > kept (=
> > marker on the right for a right page, marker on the left for a left
> > page).
> >
> >
> >         My question for you is when to draw it on what side... and how
> >         to make
> >         sure the popup menu never goes outside the Writer window?
> >
> > Can't help you with that, but as it seems that there are calculations
> > for the popup menu location for the LTR UI, this should also be done
> > in RTL UI (just from the other side of the screen).
> >
> >         Lior: the other question for you is: what to do if a document
> >         mixes RTL
> >         and LTR paragraphs?
> >
> > As stated above - not relevant, only take UI directionality into
> > account.
> >
> > Thanks for investing the time in RTL issues (:
> >
> > Kaplan
> >
> > _______________________________________________
> > Libreoffice-ux-advise mailing list
> > Libreoffice-ux-advise@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise