minutes of ESC call ...

* Present:
    + Michael W, Eike, Stephan, Caolan, Christian, Xisco, Michael M,
      Heiko, Kendy, Thorsten, Olivier

* Completed Action Items:

* Pending Action Items:
    + run certification script (Kendy)
      [ not run yet ]
    + add screenshot builder to basic build stats (Christian)
      [ didn’t get to the build failure ]

* Release Engineering update (Christian)
    + all well.
    + 6.2 Beta 1
      + cherry-pick from master to 6.2 branch
      + feature frozen, but no reviews needed yet for 6-2
      + optional beta 1st week in Dec.
      + otherwise RC1 is due Dec 17th.
      + Late Features ?
         + donation infobar (Heiko)
            + not decided yet if we go with it.
            + can we get the strings in ? (Michael M)
               + still a couple of weeks here.
         + red-lining paragraph attribute re-work (Michael S)
    - trying to aim for UI freeze on Dec 17 for switching the default
    + 6.1.4 RC1 next week 48, Nov 26
    + Remotes
    + Android viewer
+ Online
    + 6.2 branch & Beta1 source release

* Printing dialog (Kompi - not here)
    + status update on:
      https://gist.github.com/danielfaleiro/992aa39557f8475b8f4daa3af4bb3052
    + anything actionable here ? (Thorsten)
       + dislike the "hassle things into the project" approach (Michael)
    + expect to get plenty of bugs when it hits real users (Thorsten)
       + need someone to step up to own / fix issues.
       + easy part is the merge conflicts.
    + similar story with GSOC side-bar (Xisco)
       + completely understand not merging it.
    + any volunteers to shared fixing ? (Thorsten)
       + can do a fix or two, but not all of it myself.
       + may have a look (Michael W)
    => looking forward to Daniel continuing to finish this & merge it.

* CentOS base-line for KDE bits ? (Christian)
    + had already bumped it for 6.2 – for gtk3 / KDE5
    + 64bit Linux build on CentOS7
    + 32bit Linux still on CentOS6
       + platform is missing these newer pieces.
       + not got the new gtk/kde support but has new compiler.

* Compiler baselines (Stephan)
    + Plan at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081423.html> “Re: Compiler baselines”:
    + If nobody objects, we'd update the build baselines on master
      (towards LO 6.3) as follows (cf README.md):
        + Windows: from Visual Studio 2017 to Visual Studio 2017 version 15.7
        + macOS: from Xcode 8 to Xcode 9.3
           + expect tinderbox / builders are at 9.3 anyway.
        + Linux GCC: from GCC 4.8.1 to GCC 7
        + Linux Clang: from Clang to Clang 5.0.2
        + Clang compiler plugins: from Clang 3.8 to Clang 5.0.2
        + flex: from 2.5.35 to 2.6.0
        + gperf: from 3.0.0 to 3.1
     + any objections ? otherwise impl. thus.
     + Android ? (Michael)
        + tinderbox is dead too …
        + using the NDK-16 (Christian)
           + C++ run-time deprecated,
             and bump to NDK18 to llvm C++ runtime
             where exception handling is broken.
AI: + mend tinderbox (Christian)
     + MacOS / toolchain ? (Thorten)
        + if dropping unmaintained stuff - no problem.

* Documentation (Olivier)
     + New Help
          + fixes and enhancements in Index (buovjaga)
     + Helpcontents
          + Typos (SophiaS)
          + Pages updates (S. Horacek, M. Kaganski)
     + Guides,
          + many discussions on templates
          + procedures for guides updates
     + plenty of activity.

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        255(255) (topicUI) bugs open, 298(298) - needsUXEval
    + Updates:
        BZ changes 1 week 1 month 3 months 12 months
             added 10(-5) 35(0) 57(3) 100(4)
         commented 75(8) 203(0) 409(18) 1466(-9)
           removed 1(-1) 3(1) 3(1) 9(1)
          resolved 4(2) 10(-2) 25(-1) 121(-4)
    + top 10 contributors:
          Thomas Lendo made 118 changes in 1 month, and 368 changes in 1 year
          Tietze, Heiko made 115 changes in 1 month, and 550 changes in 1 year
          Kainz, Andreas made 52 changes in 1 month, and 147 changes in 1 year
          Xisco Faulí made 44 changes in 1 month, and 273 changes in 1 year
          和尚蟹 made 31 changes in 1 month, and 31 changes in 1 year
          Foote, V Stuart made 29 changes in 1 month, and 217 changes in 1 year
          Cor Nouws made 15 changes in 1 month, and 83 changes in 1 year
          kompilainenn made 15 changes in 1 month, and 55 changes in 1 year
          Muhammet Kara made 12 changes in 1 month, and 15 changes in 1 year
          Zolnai, Tamás made 11 changes in 1 month, and 147 changes in 1 year
   New needsUXEval between Nov/16-22th

     * Standard (Viewing Mode) toolbar does not have the close icon
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121490
       => Assigned/Fixed
     * Add button in tabbed mode
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121556
       => DUP 101513
     * Notebookbar: Tabbed variant for Math
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121484
       => WFM/WF

     * Add generalized Pan control at point of selection
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121480
     * UNO commands to edit the object position needed
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121492
     * Notes and warnings in help have the wrong icons
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121571
     * Form Controls present in Tabbed UI, Draw tab appears or focus
       changes wrongly to Home tab
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121592
     * Borders and background from format header menu is missing
       formatting options
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121545
       => accepted

     * Mouse pauses automatically
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121507
     * "Select" to "automatically copy"
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121481
     * Context menu with "cut,copy,...,symbols" inaccessible, if word
       is autocorrectable
       + https://bugs.documentfoundation.org/show_bug.cgi?id=120901
     * Rename the "Organize Dialogs" command in the Tools tab to Macro Organizer
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121581
     * Missing icon for "Organize Dialogs" in Calc Tools Tab
       + https://bugs.documentfoundation.org/show_bug.cgi?id=121580
     * Pasting from Writer to Impress Should be "Text only" by default
       https://bugs.documentfoundation.org/show_bug.cgi?id=121574
      => NEW/UNCONFIRMED

     * Missing method of inserting custom date format field in Impress
       + https://bugs.documentfoundation.org/show_bug.cgi?id=120647
       => needsDevEval

* Crash Testing (Caolan)
    + 3 (+1) import failures, 13(+13) export failures
        + export failures is a new assert to find these
        + passed these on to Justin.
    + 8 (-1) coverity issues
    + 19 Google / ossfuzz:
        + 1 serious, lots of timeout issues / broken build:
    + ForcePoint, round 9
        + 4 writer layout issues
    + couple of other issues
        + end of Jan. embargo for one lower prio issue.
           + Miklos had a look at improving UI.
        + another issue in progress at higher prio.
          Still struggling to agree an embargo with AOO
           + now have a CVE to go with this.
           + had agreement, agreement withdrawn, back to no date suggested.
        + sticking with 27th November.
    + CNA process joy ?
        + mailed the list, no firm opinions.
        + need to have a page that describes our process:
           + 45 days from fix to revealing the issue.
        => will modify the page
        + and start the process.
    + PVS Studio – still underway - got a few more fixed.

* Crash Reporting (Xisco)
    + http://crashreport.libreoffice.org/stats/version/6.0.6.2
         + 1446 (last 7 days) (+69)
    + http://crashreport.libreoffice.org/stats/version/6.0.7.3
         + 412 (last 7 days) (+127)
    + http://crashreport.libreoffice.org/stats/version/6.1.2.1
         + 3455 (last 7 days) (-67)
    + http://crashreport.libreoffice.org/stats/version/6.1.3.2
         + 1917 (last 7 days) (+490)
    + numbers much better than for the previous ver.
    + expect 6.1.4 to be better too.

* Hackfests & Events (Thorsten)
   + next year hackfests coming up:
  + FOSDEM in February - 2 days before the conference expected.
  + Tirana perhaps in March/April
  + Paris in summer
  + tentative Dresden: late autumn (past mid-October, for having students)
   + hope to have one each quarter.
   + GSoC’19
     + https://opensource.googleblog.com/2018/11/google-summer-of-code-15-years-strong.html
        + project signup starts to open Jan 15th
     + good to come up with good ideas / design plans for the wiki (Thorsten)
    + https://wiki.documentfoundation.org/Development/GSoC/Ideas
        + Heiko / Xisco as org. admins ?
        + trouble with decision of what projects ? (Heiko)
           + based on mentor power and student quality (Thorsten)

* mentoring/easyhack update
          committer... 1 week 1 month 3 months 12 months
                  open 54(-23) 112(-12) 116(-14) 127(-14)
               reviews 1233(-347) 5078(-71) 12648(-226) 33811(550)
                merged 253(-27) 1234(-25) 3557(-167) 15324(47)
             abandoned 14(-10) 114(-6) 223(5) 988(-2)
           own commits 413(59) 1519(38) 4040(141) 15705(150)
        review commits 109(-9) 374(59) 874(46) 3793(55)
        contributor... 1 week 1 month 3 months 12 months
                  open 25(-4) 46(-5) 48(-7) 51(-7)
               reviews 74(15) 236(17) 425(6) 19807(-458)
                merged 44(-3) 150(30) 319(22) 1603(17)
             abandoned 2(-21) 31(-4) 66(-2) 312(-3)
           own commits 46(-9) 164(27) 379(20) 1536(16)
        review commits 0(0) 0(0) 0(0) 0(0)
    + easyHack statistics:
       needsDevEval 58(58) needsUXEval 4(4) cleanup_comments 229(229)
       total 289(289) assigned 21(21) open 204(204)
    + top 10 contributors:
          Gelmini, Andrea made 54 patches in 1 month, and 525 patches in 1 year
          Sophia Schröder made 22 patches in 1 month, and 161 patches in 1 year
          Zoltán Zdibák made 17 patches in 1 month, and 18 patches in 1 year
          Illarionov, Arkadiy made 10 patches in 1 month, and 42 patches in 1 year
          Ilmari Lauhakangas made 8 patches in 1 month, and 43 patches in 1 year
          Tümer, Mert made 7 patches in 1 month, and 29 patches in 1 year
          Aleksei Nikiforov made 5 patches in 1 month, and 5 patches in 1 year
          Johnny_M made 4 patches in 1 month, and 100 patches in 1 year
          Balazs Varga made 3 patches in 1 month, and 13 patches in 1 year
          Hamish McIntyre-Bhatty made 3 patches in 1 month, and 3 patches in 1 year
    + top 10 reviewers:
          Adolfo Jayme Barrientos made 147 review comments in 1 month, and 1010 in 1 year
          Behrens, Thorsten made 140 review comments in 1 month, and 1510 in 1 year
          Nabet, Julien made 127 review comments in 1 month, and 1024 in 1 year
          Vajna, Miklos made 119 review comments in 1 month, and 1285 in 1 year
          Olivier Hallot made 115 review comments in 1 month, and 553 in 1 year
          McNamara, Caolán made 114 review comments in 1 month, and 1023 in 1 year
          Michael Stahl made 104 review comments in 1 month, and 670 in 1 year
          Grandin, Noel made 101 review comments in 1 month, and 1280 in 1 year
          Mohrhard, Markus made 88 review comments in 1 month, and 705 in 1 year
          Meeks, Michael made 87 review comments in 1 month, and 789 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Jozsef Szakacs zmx3@citromail.hu
          Martin van Zijl martin.vanzijl@gmail.com
          Alyssa Ross hi@alyssa.is
* Commit Access
    + Mert Tumer - with android scope -> send welcome mail (Michael)

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + pending the script.

* Jenkins / CI update (Christian)
    master linux rel jobs: 202 ok: 202 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    master linux dbg jobs: 138 ok: 133 ko: 5 fail ratio: 3.62 % break: 5 broken duration: 1.90%
    master mac rel jobs: 139 ok: 137 ko: 2 fail ratio: 1.44 % break: 2 broken duration: 6.71%
    master mac dbg jobs: 139 ok: 137 ko: 2 fail ratio: 1.44 % break: 1 broken duration: 0.49%
    master win rel jobs: 104 ok: 41 ko: 63 fail ratio: 60.58 % break: 18 broken duration:61.11%
    master win dbg jobs: 104 ok: 81 ko: 23 fail ratio: 22.12 % break: 19 broken duration:16.07%
    master win64 dbg jobs: 101 ok: 77 ko: 24 fail ratio: 23.76 % break: 17 broken duration:17.29%
    lo-5.3 mac jobs: 0 ok: 0 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    lo-5.4 mac jobs: 0 ok: 0 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    master gerrit lin jobs: 570 ok: 450 ko: 39 fail ratio: 6.84% time for ok: mean: 22 median: 19
    master gerrit plg jobs: 568 ok: 382 ko: 93 fail ratio: 16.37% time for ok: mean: 38 median: 33
    master gerrit win jobs: 612 ok: 358 ko: 94 fail ratio: 15.36% time for ok: mean: 73 median: 73
    master gerrit mac jobs: 572 ok: 418 ko: 32 fail ratio: 5.59% time for ok: mean: 60 median: 37
    master gerrit all jobs: 458 ok: 253 ko: 159 fail ratio: 34.72% time for ok: mean: 107 median: 98
   + https://dev-www.libreoffice.org/tmp/gerrit_181122.html
   + tests that failed more than twice in last seven days:
      4 CppunitTest_sc_macros_test
      4 CppunitTest_vcl_complextext
      4 UITest_calc_tests6
      9 CppunitTest_vcl_pdfexport
   + going quite well; an issue with master being broken.
       + one compiler plugin triggered faults.
       + being based on a broken master.
   + windows / cygwin had the forking problem needing fixing
       + unclear if this one was updated to be fixed
       + have now updated - lets see.

* l10n (Sophie)
  (who has lost her voice)
    + Upper and Lower Sorbian fully translated, kudos to the team!
    + complete done in near record time - amazing (Christian)
    + follow-up on plural forms without issues currently
       + ongoing issue, Icelandic team report on dev-list.
       + Sophie fixed this.
    + Eike mentioned that pocheck kills duplicates only
       + translated function name might still conflict with an English name
       + don't think it is worth fixing though (cloph)
         (in theory there could be a third translation that conflicts with the
         English terms that would be used instead)

* Commit hook (Kendy)
    + does checks around git submodules
    + struggling committing unwanted changed to translations
    + hooks should tell people what to do to fix things
    + hopefully it doesn't annoy anyone.
    + doesn't need propagating to other repos (Michael)
    + server-side commits to toplevel core.git to keep submodules in sync.
    + if someone commits by mistake changing the submodules
      things get out of sync.

* QA update (Xisco)

    + had a bug-hunting session for Beta1 this week

    + Please help flesh out the monthly reports:
        https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 537 (+29)
        + enhancements: 65 (+9)
        + needsUXEval: 2 (+1)
        + haveBackTrace: 5 (+0)
        + needsDevAdvice: 22 (+0)
        + documentation: 4 (+0)
        + android: 14 (+1)

        + KDE5 crashes ( 6 )
            + KDE5: Crash closing check for update dialog
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121516
            + kde5: Sporadic crash when right-clicking items in toolbar
                + https://bugs.documentfoundation.org/show_bug.cgi?id=120454
            + KDE5: Impress crashes after selecting some of Slide Transitions
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121266
            + KDE5: Impress crashes at starting Slide show (with animation...
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121247
            + KDE5: Recent Documents -> Clear list leads to crash
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121417
            + KDE5: Perform some actions for View -> Toolbars menu -> Crash
                + https://bugs.documentfoundation.org/show_bug.cgi?id=120890
    + Most pressing bugs:
        + New
            + [None]

        + Older
            + Crash after accepting all changes from compared documents
                + https://bugs.documentfoundation.org/show_bug.cgi?id=109376
                + M. Stahl ?
            + Crash restarting LibreOffice after applying an option
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121180
                + Diadlo, Bubli ? ...
            + Crashes on UNDO
                + https://bugs.documentfoundation.org/show_bug.cgi?id=120754
                + dtardon / Caolan. Its an extension, so I'm guessing that one of the steps is outside undo control
            + Crash applying bold to textbox control
                + https://bugs.documentfoundation.org/show_bug.cgi?id=120750
                + Jochen Nitschke / mst ? - Xisco poked Jochen.

            + Crash in: SwIndex::SwIndex(SwIndexReg * const,long)
                + https://bugs.documentfoundation.org/show_bug.cgi?id=119989
                + bisected to Ash

            + Calc: Crash when cutting some content
                + https://bugs.documentfoundation.org/show_bug.cgi?id=118707
                + Henry Castro

        + Fixed
            + Pressing twice on the "Help" button causes LibreOffice application to crash when the focus is on one of the tabs on Properties window
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121432
                + Thanks to Caolán McNamara

            + CRASH deleting a form from form navigator
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121540
                + Thanks to Noel Grandin

            + choosing additional formatting in dialog insert fields cause crash (gen/gtk)
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121538
                + Thanks to Caolán McNamara

            + Crash clicking on 'row' of a chart (with missing chart bars)
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121246
                + Thanks to Caolán McNamara

            + CRASH: Print Preview fails if cursor inside Floating frame
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121591
                + Problematic commit reverted

            + Impress/Draw hangs/crashes when exiting while editing formula
                + https://bugs.documentfoundation.org/show_bug.cgi?id=119945
                + Problematic commit reverted

            + Insert OLE Object from file causes crash, if Experimental features are enabled
                + https://bugs.documentfoundation.org/show_bug.cgi?id=120991
                + Thanks to Michael Stahl

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +157 +36 (-98) overall)
      many thanks to the top bug squashers:
       Caolán McNamara 12
       Xisco Faulí 10
       andreas_k 9
       Adolfo Jayme 8
       Buovjaga 6
       Markus Mohrhard 4
       Timur 3
       Maxim Monastirsky 3
       Olivier Hallot 3
       Heiko Tietze 3

    + top 10 bugs reporters:
       NISZ LibreOffice Team 20
       Xisco Faulí 4
       Liad Skiva 4
       andreas_k 3
       和尚蟹 3
       robert 3
       Mike Kaganski 2
       Jim Raykowski 2
       raal 2
       Drew Jensen 2

    + top 10 bugs fixers:
       McNamara, Caolán 9
       Kainz, Andreas 6
       Olivier Hallot 3
       Mohrhard, Markus 3
                               2
       Kaganski, Mike 2
       Mehrbrodt, Samuel 2
       Xisco Faulí 2
       Rathke, Eike 2
       Michael Stahl 2

    + top 10 bugs confirmers:
       Xisco Faulí 44
       Tietze, Heiko 8
       Brinzing, Oliver 7
       Foote, V Stuart 6
       Nabet, Julien 4
       Kainz, Andreas 3
       m.a.riosv 3
       Budea, Áron 3
       kompilainenn 3

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 2/50 - 4 % (+0)
     5.4 : 1/40 - 2 % (+0)
     5.3 : 2/54 - 3 % (+0)
     5.2 : 1/41 - 2 % (+0)
     5.1 : 0/35 - 0 % (+0)
     5.0 : 3/65 - 4 % (+1)
     4.4 : 1/76 - 1 % (+0)
     4.3 : 2/73 - 2 % (+0)
     4.2 : 5/134 - 3 % (+0)
     4.1 : 3/84 - 3 % (+0)
     4.0 : 4/83 - 4 % (+0)
     old : 19/257 - 7 % (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 614/2756 609/2732 602/2702 599/2682 601/2660 595/2638 599/2623

     done by:
        Xisco Faulí 19
        Budea, Áron 3
        Benes, Luke 2

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 801/3517 795/3494 787/3460 785/3440 785/3416 777/3392 777/3370

     done by:
        Xisco Faulí 19
        Budea, Áron 3
        Thomas Lendo 1

* all bugs tagged with 'regression'
   + 1055(+2) bugs open of 7816(+21) total 14(+1) high prio.

     done by:
        Xisco Faulí 13
        Benes, Luke 3
        robert 2
        Telesto 2
        Thomas Lendo 1

* ~Component count net * high severity regressions
   + http://bit.ly/1HWHb3E
     LibreOffice - 5(+0)
     Writer - 4(+1)
     Base - 2(+0)
     Calc - 2(+0)
     graphics stack - 1(+0)

   by OS:
     Windows - 3(+0)
     Linux - 0(+0)
     All - 11(+1)
     Mac OS X - 0(+0)

* ~Component count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other - 275(+4)
     Calc - 188(+0)
     Impress - 115(+0)
     Writer: docx filter - 76(+1)
     LibreOffice - 71(+0)
     UI - 43(-2)
     Draw - 43(+0)
     Borders - 39(-1)
     Base - 35(+1)
     Writer: doc filter - 34(+0)
     Writer: perf - 34(+0)
     graphics stack - 32(+0)
     Crashes - 30(-1)
     Writer: other filter - 25(+0)
     filters and storage - 24(+0)
     Chart - 20(-1)
     Printing and PDF export - 15(+0)
     BASIC - 13(-2)
     Linguistic - 2(+0)
     framework - 2(+0)
     Extensions - 1(+0)
     Formula Editor - 1(+0)
     sdk - 1(+0)