minutes of ESC call ...

* Present:
    + Stephan, Olivier, Eike, Michael M, Heiko, Sophie, Cloph,
      Miklos, Kendy, Caolán, Thorsten

* Completed Action Items:
    + remove internal file-picker from the options page (Heiko)
    + add internal file-picker removal to “pending removal”
      release-notes in 6.0 (Heiko)
       + ticket for discussion; Rene has concerns
       https://bugs.documentfoundation.org/show_bug.cgi?id=114484
         commit comment was misleading just disabled file (Michael)
           + the internal print dialog is not shown at all, see comment on
             ticket (Heiko) ]

* Pending Action Items:
    + come up with a list of retiring committers to mail (Norbert)

* Release Engineering update (Christian)
   + 5.4.4 RC2
        + released as final yesterday.
        + issue installing on WinXP – forgot the SDK switch to enable it.
           + builds are running, and will replace builds on mirrors when done
           + re-doing and replace & announce on twitter.
    + 6.0 RC1
        + builds are done, and up-loading
        + no additional branch yet – but on -6-0 branch
        + still in 1x review mode.
        + 6-0-0 branch is due Jan 9th for RC2.
        + late features
            + gpg4libre branch (Thorsten)
               [ almost done with decrypting – but negative time.
                 expect things next week. ]
            + HTML help pieces (Olivier)
               [ still working, not yet ready – fixing l10n issues
                 working sfx2 to make it work.
                 Kendy has a patch to help out. ]
            + ‘experimental’ Calc / threading UI setting (Michael)
               [ disabled threading by default for 6.0
                 not got this setting in ? (Michael)
                    + apparently patch in 6-0 (Eike)
                      + fine with keeping it in if translators are happy
                      + no problem (Sophie)
                    + seems its not in – lets push it but mark it highly
                      experimental (Eike) ]
            + VC Runtime re-distributable installer (Cloph)
               [ change added to master, included in TB builds,
                 will cherry-pick to 6-0 branch ]
   + Android
        + patch for unified headers don’t switch to llvm on ARM
        + working for Intel & ARM – but still in gerrit
        + along with patches avoiding Nnullptr exceptions loading docs.
   + Online
        + 6.0.0 RC1 source up-loaded
        + ongoing fixing & polish there.

* Documentation (Olivier)
   + Working on the XSLT transformation to get relative paths for help
          + same pages will serve local and online versions
   + Several corrections and additions to help pages
   + Working on the LO call to the local help in HTML
   + Guides 6.0: Stalled. Holliday season
   + found issue with online docs (Stephan)
          + start page – get a re-direct to somewhere with no-redirect token
          + something broke; filed a red-mine ticket.

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        254(254) (topicUI) bugs open, 328(328) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes 1 week 1 month 3 months 12 months
             added 2(0) 10(-1) 39(-4) 109(-5)
         commented 26(-6) 152(-25) 538(-36) 2192(-68)
           removed 0(0) 2(0) 3(-2) 21(0)
          resolved 5(2) 20(0) 58(2) 243(1)
    + top 10 contributors:
          Tietze, Heiko made 63 changes in 1 month, and 1059 changes in 1 year
          Philips, Yousuf made 30 changes in 1 month, and 785 changes in 1 year
          Xisco Faulí made 22 changes in 1 month, and 395 changes in 1 year
          Foote, V Stuart made 19 changes in 1 month, and 352 changes in 1 year
          Thomas Lendo made 16 changes in 1 month, and 409 changes in 1 year
          Zolnai, Tamás made 16 changes in 1 month, and 145 changes in 1 year
          Henschel, Regina made 13 changes in 1 month, and 125 changes in 1 year
          kompilainenn made 13 changes in 1 month, and 25 changes in 1 year
          Monastirsky, Maxim made 12 changes in 1 month, and 33 changes in 1 year
          Cor Nouws made 10 changes in 1 month, and 181 changes in 1 year

  + late changes to Draw main menu
       + https://gerrit.libreoffice.org/#/c/46867/
       + could also be done without string changes
       + getting very late wrt. freezes (Michael)
           + lets not make a habit of it.
       + if several strings – not important to break freeze (Sophie)
       + can we get it in without the string changes ? (Heiko)
       => lets keep it as is – and do it in -6-1

  + new default colors for shapes, problem with unit tests
    + https://bugs.documentfoundation.org/show_bug.cgi?id=112541
    + http://nabble.documentfoundation.org/unit-test-for-COL-DEFAULT-SHAPE-FILLING-tt4229400.html
    + changing the default color – to have a different non-sky-blue name
       + have to update hundreds of files in the unit tests.
       + can we change behavior of unit tests.
       + https://opengrok.libreoffice.org/xref/core/include/svx/xdef.hxx
       + in the past didn’t write the defaults (Miklos)
           + changing these broke existing docs.
           + think we have version checks in place now.
           + did you check affecting existing documents ?
               + not tested (Heiko)
           + breaks lots of unit tests.
       + need to separate default on filter from default in UI.

+ ugly track changes / tooltip issue over them.
   + https://bugs.documentfoundation.org/show_bug.cgi?id=114523
   + worse when you don’t show them – but they are there.
   + hacking on this now.

* Crash Hunting (Caolan)
    + 98 (-18) import failure, 0 export failures
        + another run of the imports – gone down to 98
        + another run in progress
        + still some calc threading issues pending.
    + 14 (+6) coverity
        + all the new 6 are fixed
        + another run over Christmas to confirm just java bits left
    + 44 (+1) fuzzers * 3 sanitizers+engine combos (asan+libfuzzer,
            ubsan+libfuzzer, asan+afl), writer html newly added
        + 6 hours of html testing locally passed
        + will enable it up-stream.
    + sec list – idefense report vs. fixed bug in 5.4.x
        + need to note it was fixed already.
    + calc issue, need to sanitize that in the new year.

* Crash Reporter (Xisco sadly missing)
    + http://crashreport.libreoffice.org/stats/version/5.3.6.1
        + 1602 (last 7 days) (down)
    + http://crashreport.libreoffice.org/stats/version/5.3.7.2
        + 1107 (last 7 days) (up)
    + http://crashreport.libreoffice.org/stats/version/5.4.2.2
    + 3992 (last 7 days) (up)
    + Updater still the main crasher
    + http://crashreport.libreoffice.org/stats/version/5.4.3.2
    + 2762 (last 7 days) (up)
        + lots of people decided to update ? – a peak here.
        + looking forward to 5.4.4 – which fixes main crashers in 5.4.3.

* Hackfests & Events (Thorsten)
    + FOSDEM hack-fest / meetings
        + confirmed for following Monday/Tuesday at ICAB
        + dates confirmed (Monday + Tuesday), book your travel!
        + Bedford – overbooked right now; didn’t get a group rate (Heiko)
            + hurry to book.
        + La Grande Cloche over the street.
    + Hamburg – 1st new-style hackfest
        + deferred to next year ...
            + https://wiki.documentfoundation.org/Hackfests/HackfestTNG
        + should meet with locals
    + fallback plan for March in either Italy or Germany
    + still looking for people who want help learning how to fix
      their problems interactively at a hackfest.

* mentoring/easyhack update
          committer... 1 week 1 month 3 months 12 months
                  open 67(-14) 117(-14) 119(-13) 123(-13)
               reviews 599(-4) 2202(208) 4894(-30) 18690(136)
                merged 428(86) 1551(229) 3557(192) 11871(204)
             abandoned 28(-14) 135(14) 267(17) 744(18)
           own commits 339(-8) 1545(76) 4246(-9) 13944(181)
        review commits 56(-15) 343(5) 866(-9) 3337(5)
        contributor... 1 week 1 month 3 months 12 months
                  open 17(-6) 38(3) 39(1) 43(1)
               reviews 845(-80) 3324(190) 7735(111) 24245(279)
                merged 13(-15) 85(-9) 234(-9) 1183(-1)
             abandoned 2(-6) 23(-1) 57(-4) 346(-1)
           own commits 13(-15) 86(-9) 240(-10) 866(-11)
        review commits 0(0) 0(0) 0(0) 0(0)
    + easyHack statistics:
       needsDevEval 37(37) needsUXEval 1(1) cleanup_comments 206(206)
       total 255(255) assigned 24(24) open 192(192)
    + top 5 contributors:
          Gelmini, Andrea made 24 patches in 1 month, and 211 patches in 1 year
          Goncharuk, Lera made 8 patches in 1 month, and 13 patches in 1 year
          Donkers, Winfried made 8 patches in 1 month, and 29 patches in 1 year
          Gabriel Chiquini made 4 patches in 1 month, and 6 patches in 1 year
          Latini, Marina made 3 patches in 1 month, and 4 patches in 1 year
    + top 5 reviewers:
          Pootle bot made 237 review comments in 1 month, and 741 in 1 year
          Holešovský, Jan made 203 review comments in 1 month, and 1143 in 1 year
          Behrens, Thorsten made 195 review comments in 1 month, and 1068 in 1 year
          Stahl, Michael made 195 review comments in 1 month, and 1987 in 1 year
          Rathke, Eike made 152 review comments in 1 month, and 1142 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:

* XHTML export filter (Miklos)
    + remember recent commits for XHTML / XSLT.
    + added a new flag to HTML export to produce XHTML
        + far from perfect but a good start.
    + profiling XHTML export – a large cost is compiling XSLT thing.
        + 2x XHTML exports in writer.
    + XSLT is the default still, but now have the C++ one too.
    + in case no-one shouts: prefer to move to C++ not XSLT
        + no time for it just now to do it completely.
    + thoughts ?
    + no fan of XSLT (Thorsten)
        + fixing bits here & there had to re-write.
        + one good bit – exercises the flat-odf filter
        + Regina working on fixing that.
    + perhaps keep it around and deprecate it.
    + generally the concept is powerful if you love XSLT (Thorsten)
    + patch to change type of pictures (Kendy)
        + useful for flat-odt (Thorsten)

* Commit Access

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + sleep for 16 weeks.

* Jenkins / CI update (Christian)
    master linux rel jobs: 204 ok: 201 ko: 3 fail ratio: 1.47 % break: 2 broken duration: 0.17%
    master linux dbg jobs: 133 ok: 130 ko: 1 fail ratio: 0.75 % break: 1 broken duration: 0.74%
    master mac rel jobs: 141 ok: 140 ko: 1 fail ratio: 0.71 % break: 1 broken duration: 1.15%
    master mac dbg jobs: 137 ok: 135 ko: 2 fail ratio: 1.46 % break: 2 broken duration: 2.71%
    master win rel jobs: 94 ok: 85 ko: 9 fail ratio: 9.57 % break: 9 broken duration:11.47%
    master win dbg jobs: 114 ok: 101 ko: 13 fail ratio: 11.40 % break: 12 broken duration: 9.92%
    master win64 dbg jobs: 106 ok: 93 ko: 13 fail ratio: 12.26 % break: 12 broken duration: 8.68%
    lo-5.3 mac jobs: 0 ok: 0 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    lo-5.4 mac jobs: 0 ok: 0 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    branch gerrit all jobs: 0 ok: 0 ko: 0 fail ratio: 0.00%
    master gerrit lin jobs: 472 ok: 434 ko: 36 fail ratio: 7.63%
    master gerrit plg jobs: 472 ok: 334 ko: 125 fail ratio:26.48%
    master gerrit win jobs: 326 ok: 274 ko: 49 fail ratio:15.03%
    master gerrit mac jobs: 321 ok: 301 ko: 16 fail ratio: 4.98%
    master gerrit all jobs: 470 ok: 260 ko: 182 fail ratio:38.72%
    + split of Linux builds helps reduce the load on Win/Mac
    + un-related build failures un-related to build/test framework
    + pretty solid.
    + 90 more builds on master in the last 7 days.

* l10n (Sophie)
    + did the strings get pushed ?
         + updated templates on pootle for RC
         + previously strings were un-translated (Cloph)
             + now there are translations, but marked as fuzzy
             + now can see un-translated only.
         + plan to remove the fuzzy marker
             + hope to get a partial de-fuzz this year.

* Blurry icons (Heiko)
    + a PNG issue for hidpi screens.
    + why not use SVG icons instead ?
    + quikee wrote some code to render SVG icons (Kendy)
       + need to look into what the state is
       + adds some startup-time potentially.
       + need to measure startup impact.
    + SVG renderer we have is not the fastest in the world (Thorsten)
       + with some caching – in a good shape.
    + thought it was solved ? Just switching.
    => ask quikee what he recommends.

* QA update (Xisco)

    + UNCONFIRMED: 394 (-7)
        + enhancements: 40 (-10)
        + needsUXEval: 0 (+0)
        + haveBackTrace: 7 (-2)
        + needsDevAdvice: 28 (-3)
        + documentation: 2 (-2)
        + android: 15 (-3)

    + Most Pressing Bugs: http://tdf.io/mostressingbugs
        + New:
             + Draw filter export to PDF/A-1a crashes LO & system
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=114314
                   + Xorg crash → notourbug.

        + Fixed:

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +133 +34 (-129) overall)
      many thanks to the top bug squashers:
       Buovjaga 14
       Olivier Hallot 13
       Xisco Faulí 11
       Heiko Tietze 10
       Yousuf Philips (jay) 9
       Michael Stahl 6
       Maxim Monastirsky 6
       Timur 5
       Eike Rathke 5
       Markus Mohrhard 4

    + top 10 bugs reporters:
       Yousuf Philips (jay) 9
       Telesto 7
       Volga 6
       squeezechart 4
       Ljiljan 3
       Jim Raykowski 2
       Philippe Hemmel 2
       Aron Budea 2
       Thomas Lendo 2
       Nemo_bis 2

    + top 10 bugs fixers:
       Olivier Hallot 11
       Stahl, Michael 6
       Mohrhard, Markus 4
       McNamara, Caolán 3
       Philips, Yousuf 3
                               2
       Justin L 2
       Tietze, Heiko 2
       Rathke, Eike 2
       Abe, Takeshi 1

    + top 10 bugs confirmers:
       Buovjaga 27
       Xisco Faulí 13
       Philips, Yousuf 11
       Jacques Guilleron 6
       Dieter Praas 6
       Budea, Áron 4
       Foote, V Stuart 4
       Tietze, Heiko 4
       Alex Thurgood 4
       Henschel, Regina 3

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     5.3 : 2/49 - 4 % (+0)
     5.2 : 2/39 - 5 % (+0)
     5.1 : 1/35 - 2 % (+0)
     5.0 : 2/62 - 3 % (+0)
     4.4 : 2/76 - 2 % (+0)
     4.3 : 6/75 - 8 % (+2)
     4.2 : 6/134 - 4 % (+0)
     4.1 : 3/84 - 3 % (+0)
     4.0 : 4/83 - 4 % (+0)
     old : 25/258 - 9 % (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 410/1796 420/1795 413/1767 416/1760 414/1748 425/1735 417/1714

     done by:
        Xisco Faulí 2
        Budea, Áron 1

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 500/2409 510/2407 500/2376 502/2369 500/2355 510/2341 501/2317

     done by:
        Xisco Faulí 2
        Budea, Áron 1

* all bugs tagged with 'regression'
   + 876(-8) bugs open of 6623(+8) total 6(-1) high prio.

     done by:
        Xisco Faulí 3
        Telesto 2
        Raal 2
        Cor Nouws 1
        MM 1
        Jacques Guilleron 1
        Budea, Áron 1

* ~Component count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Impress - 2(+0)
     Calc - 1(-1)
     graphics stack - 1(+0)
     Writer - 1(+0)
     LibreOffice - 1(+0)

   by OS:
     Mac OS X - 3(+0)
     All - 3(-1)
     Linux - 0(+0)
     Windows - 0(+0)

* ~Component count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other - 157(-4)
     Calc - 149(+0)
     Impress - 91(+0)
     Writer: docx filter - 74(-1)
     LibreOffice - 69(+0)
     UI - 47(-1)
     Writer: perf - 34(+0)
     graphics stack - 34(+0)
     Draw - 33(+0)
     Writer: doc filter - 33(+0)
     Base - 29(+0)
     Borders - 28(+0)
     filters and storage - 27(+1)
     Writer: other filter - 25(+0)
     Crashes - 20(+1)
     Chart - 19(-3)
     BASIC - 16(+1)
     Printing and PDF export - 15(-1)
     framework - 5(+0)
     Linguistic - 2(+0)
     Extensions - 1(+0)
     Installation - 1(+0)
     sdk - 1(+0)