Re: [libreoffice-l10n] Weblate upgraded to 4.15.2

Hi Valter, *,

On Sat, Feb 4, 2023 at 5:12 PM Valter Mura <valtermura@libreoffice.org> wrote:
> I've made some test on 4.15.2 and I noticed a delay in saving of about
> *8 seconds*. I'm talking of the commands: Acceps a suggestion and
> Modify, and after Save.

During FOSDEM I got a chance to talk to the weblate developers and now
have an explanation for that - from Weblate POV that is not a single
action, but you accept the translation, and then edit it. Weblate adds
the string to the list of strings that needs to be updated in git and
puts that into the update queue, but since the same string gets
modified, the change needs to be flushed out to disk (git commit)
immediately so that state isn't just discarded, so the waiting time is
due to the time needed for the git commit (waiting until nothing else
writes to git, acquire the lock, do the actual git commit). (In our
setup we have it set to squash changes when pushing to the
repositories, so the individual commits won't show up in our
repository as individual changes)

So long for the explanation - but there also is an easy fix to improve
that situation: Instead of waiting until you submit your edited string
(and weblate realizing that the string already has a pending change),
the commit can be triggered as soon as you hit the accept and edit
button. So during the time it takes you to edit the string and hit
save, the commit is already done, and you probably won't notice the
difference between regular updates and the accept-and-edit suggestion
case. So should be fixed in one of the next releases.

ciao
Christian

-- 
To unsubscribe e-mail to: l10n+unsubscribe@global.libreoffice.org
Problems? https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: https://wiki.documentfoundation.org/Netiquette
List archive: https://listarchives.libreoffice.org/global/l10n/
Privacy Policy: https://www.documentfoundation.org/privacy