RE: LibreOffice Digest, Vol 119, Issue 12

Hi 

we need some help with our free app, this is link to open source code
https://www.enriched.online/our-software/

Re;

Notarization LibreOffice 6.0.1.0 on MacOS Catalina

Details; 

Our Dev.  knows that LibreOffice supports notarization from the version 6.3.
But I want to make the notarization possible for LibreOffice 6.0.1.1
So I had patched some files from 6.3 and did passed notarization process
successfully.
hardened_runtime.xcent
macosx-codesign-app-bundle
Library_sd.mk (in order to support MacOS 10.15 SDK)

But unfortunately, "save" file doesn't work at Catalina.
General IO Exception is occurred.
(The program runs without problem before notarization.)

I'm wondering if it's possible to successfully notarization without
upgrading version to LibreOffice6.3, as this seems a big job.

BTW, our app is free and intended to ultimately help Dementia sufferers and
also people with reding difficulty, once we get it running properly.

Any help and tip will be appreciated.
Thank you in advance.



-----Original Message-----
From: LibreOffice <libreoffice-bounces@lists.freedesktop.org> On Behalf Of
libreoffice-request@lists.freedesktop.org
Sent: Saturday, 11 July 2020 10:00 PM
To: libreoffice@lists.freedesktop.org
Subject: LibreOffice Digest, Vol 119, Issue 12

Send LibreOffice mailing list submissions to
        libreoffice@lists.freedesktop.org

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.freedesktop.org/mailman/listinfo/libreoffice
or, via email, send a message with subject or body 'help' to
        libreoffice-request@lists.freedesktop.org

You can reach the person managing the list at
        libreoffice-owner@lists.freedesktop.org

When replying, please edit your Subject line so it is more specific than
"Re: Contents of LibreOffice digest..."


Today's Topics:

   1. Re: [Bug 115747] Can't edit file on samba shares (Finway)
   2. CppunitTest_sw_ooxmlexport4 failing with --disable-pch on
      Windows (Mike Kaganski)
   3. New Defects reported by Coverity Scan for LibreOffice
      (scan-admin@coverity.com)


----------------------------------------------------------------------

Message: 1
Date: Fri, 10 Jul 2020 08:13:41 -0700 (MST)
From: Finway <finway@orange.fr>
To: libreoffice@lists.freedesktop.org
Subject: Re: [Bug 115747] Can't edit file on samba shares
Message-ID: <1594394021585-0.post@n3.nabble.com>
Content-Type: text/plain; charset=us-ascii

Wols Lists wrote
> On 28/01/19 07:55, Kaganski Mike wrote:
> > Hi Thorsten!
> >
> > On 28.01.2019 5:32, Thorsten Behrens wrote:
> > > Kaganski Mike wrote:
> > > > My vision of this would me that if inability to create lockfiles 
> > > > needs to be handled specially at all, then at maximum a warning 
> > > > infobar telling that "no lockfile was created, so clashes are 
> > > > possible" could be shown, but not limiting user's ability to work 
> > > > (because technically nothing prevents users).
> > > That appears backwards to me. My take is, software should always go 
> > > the safe path by default, and offer the dangerous one only after 
> > > explicit consent. So with the infobar idea, that would mean open 
> > > read-only, but perhaps provide the option to switch to edit mode 
> > > while keeping the filename?
> >
> > Well - that'd be OK IMO :-)
> Maybe with a follow-up warning on saving "you are about to save a file 
> someone else may have open. Either you or they could lose their changes".
>
> Cheers,
> Wol
> _______________________________________________
> LibreOffice mailing list

> LibreOffice@.freedesktop

> https://lists.freedesktop.org/mailman/listinfo/libreoffice

oHi everyone !

To list the 2 main problems I see that may put a user in this situation:
- administrator doesn't allow to create hidden file on a server (dot file
forbidden)
- administrator doesn't allow to create new file on a server (yet to modify
some/all existing ones)

What canNOT be done:
- use special file convention behavior for a single user (at worst have
administrator strategy (save in a special server folder, save with special
name convention,... shared by all the network users), but that's kind of a
new development I guess !!)
- (even) use a special behavior for a single user may be problematic (an
option to ignore warnings/protections when lock-file cannot be create could
be problematic ; yet to be allowed to select in in "advanced options" why
not...)

To compare with MS behavior in this case:
- by default a file on a server cannot be modified by the user
- a banner to "activate" the document is shown with a warning
- a warning appears when saving

So,
the already given solutions may fit the idea to fix the problem (which
prevents me to use LO at work for example ;-))

Thanks for your work <3
--
Fin'



--
Sent from:
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.ht
ml


------------------------------

Message: 2
Date: Sat, 11 Jul 2020 02:35:45 +0300
From: Mike Kaganski <mikekaganski@hotmail.com>
To: libreoffice@lists.freedesktop.org
Subject: CppunitTest_sw_ooxmlexport4 failing with --disable-pch on
        Windows
Message-ID:
        
<DB6PR07MB3512B026E4C5942E73E76A0BD6650@DB6PR07MB3512.eurprd07.prod.outlook.
com>
        
Content-Type: text/plain; charset="utf-8"

Hi!

In current master (at least a week, and still the same after pull just
now) I see 100% reproducible failure of make CppunitTest_sw_ooxmlexport4:

> $ /opt/lo/bin/make CppunitTest_sw_ooxmlexport4 ...
> test_Tdf115030::Load_Reload_Verify finished in: 1500ms
> C:/lo/src/core/test/source/xmltesttools.cxx(194) : error : Assertion 
> Test name: testComboBoxControl::Load_Reload_Verify
> equality assertion failed
> - Expected: manolo
> - Actual  : Manolo
> - In <file:///C:/cygwin64/tmp/lu23416a8g0y3.tmp>, XPath contents of 
> child does not match
>
> Failures !!!
> Run: 85   Failure total: 1   Failures: 1   Errors: 0

This test succeeds normally though, when run individually:

> $ /opt/lo/bin/make CppunitTest_sw_ooxmlexport4 
> CPPUNIT_TEST_NAME=testComboBoxControl

I was able to narrow down the problem to --disable-pch in my config.
Specifically, the problem is reproduced with the normal PCH build, after
just adding the '--disable-pch' option to autogen.sh, executing 'touch
sw/qa/extras/ooxmlexport/ooxmlexport4.cxx', and then 'make
CppunitTest_sw_ooxmlexport4' - so rebuilding the single CXX reliably
produces the failure.

My full autogen.sh:

> --with-distro=LibreOfficeWin64
> --with-external-tar=c:/lo/src/lo-externalsrc
> --with-junit=c:/lo/src/junit-4.10.jar
> --with-ant-home=c:/lo/src/apache-ant-1.9.5
> --with-jdk-home=C:/Program Files/AdoptOpenJDK/jdk-11.0.7.10-hotspot
> --with-galleries=no
> --with-parallelism=14
> --with-visual-studio=2019
> --disable-pch
> --enable-dbgutil
> --without-help
> --with-lang=ru de gd kab om rw si he
> --with-myspell-dicts
> --without-package-format
> --without-helppack-integration
> --enable-64-bit
> --enable-werror
> --with-ucrt-dir=D:/Downloads/ucrt/WindowsUCRT
> --enable-breakpad
> --disable-mergelibs
> --enable-qt5
> --disable-odk

using Windows 10 64-bit v.1909 build 18363.900, with gpg4win 3.1.11
installed.

Could you please perform a quick test like the described, to check if that
is reproducible universally, or some problem with my system? Thank you!

--
Best regards,
Mike Kaganski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 1769 bytes
Desc: not available
URL:
<https://lists.freedesktop.org/archives/libreoffice/attachments/20200711/2cc
1cbbb/attachment-0001.key>

------------------------------

Message: 3
Date: Sat, 11 Jul 2020 10:09:16 +0000 (UTC)
From: scan-admin@coverity.com
To: libreoffice@lists.freedesktop.org
Subject: New Defects reported by Coverity Scan for LibreOffice
Message-ID:
        <5f098fcb8133a_33f99d2ab03c342f5812848@prd-scan-dashboard-0.mail>
Content-Type: text/plain; charset=us-ascii

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice
found with Coverity Scan.

9 new defect(s) introduced to LibreOffice found with Coverity Scan.
19 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan Showing 9 of 9 defect(s)


** CID 1465260:  Error handling issues  (CHECKED_RETURN)
/svx/source/sidebar/inspector/InspectorTextPanel.cxx: 79 in
svx::sidebar::InspectorTextPanel::updateEntries(const
std::vector<svx::sidebar::TreeNode, std::allocator<svx::sidebar::TreeNode>>
&)()


____________________________________________________________________________
____________________________
*** CID 1465260:  Error handling issues  (CHECKED_RETURN)
/svx/source/sidebar/inspector/InspectorTextPanel.cxx: 79 in
svx::sidebar::InspectorTextPanel::updateEntries(const
std::vector<svx::sidebar::TreeNode, std::allocator<svx::sidebar::TreeNode>>
&)()
73         pTreeDiagram->all_foreach([pTreeDiagram](weld::TreeIter& rEntry)
{
74             pTreeDiagram->expand_row(rEntry);
75             return false;
76         });
77     
78         std::unique_ptr<weld::TreeIter> xEntry =
mxListBoxStyles->make_iterator();
> > >     CID 1465260:  Error handling issues  (CHECKED_RETURN)
> > >     Calling "get_iter_first" without checking return value (as is done
elsewhere 85 out of 91 times).
79         mxListBoxStyles->get_iter_first(*xEntry);
80         mxListBoxStyles->iter_next(*xEntry);
81         mxListBoxStyles->collapse_row(*xEntry); // Collapse "Default
Paragraph Style"
82     }
83     
84     InspectorTextPanel::~InspectorTextPanel() { disposeOnce(); }

** CID 1465259:  API usage errors  (SWAPPED_ARGUMENTS)


____________________________________________________________________________
____________________________
*** CID 1465259:  API usage errors  (SWAPPED_ARGUMENTS)
/editeng/source/editeng/impedit.cxx: 150 in
LOKSpecialPositioning::GetWindowPos(const tools::Rectangle &, MapUnit)
const()
144         {
145             aRect = tools::Rectangle(aPos, aSz);
146         }
147         else
148         {
149             Point aNewPos(aPos.X() - aSz.Height(), aPos.Y());
> > >     CID 1465259:  API usage errors  (SWAPPED_ARGUMENTS)
> > >     The positions of arguments in the constructor for "Size" do not
match the ordering of the parameters:
* "aSz.Height()" is passed to "nWidth"
* "aSz.Width()" is passed to "nHeight"
150             aRect = tools::Rectangle(aNewPos, Size(aSz.Height(),
aSz.Width()));
151         }
152         return aRect;
153     }
154     
155     Point LOKSpecialPositioning::convertUnit(const Point& rPos, MapUnit
ePosUnit) const

** CID 1465258:  Uninitialized members  (UNINIT_CTOR)
/svtools/source/brwbox/ebbcontrols.cxx: 391 in
svt::EditControlBase::EditControlBase(BrowserDataWin *)()


____________________________________________________________________________
____________________________
*** CID 1465258:  Uninitialized members  (UNINIT_CTOR)
/svtools/source/brwbox/ebbcontrols.cxx: 391 in
svt::EditControlBase::EditControlBase(BrowserDataWin *)()
385             m_pWidget = pWidget;
386         }
387     
388         EditControlBase::EditControlBase(BrowserDataWin* pParent)
389             : ControlBase(pParent, "svt/ui/thineditcontrol.ui",
"EditControl") // *thin*editcontrol has no frame/border
390         {
> > >     CID 1465258:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member "m_pEntry" is not initialized in this
constructor nor in any functions that it calls.
391         }
392     
393         void EditControlBase::InitEditControlBase(weld::Entry* pEntry)
394         {
395             InitControlBase(pEntry);
396             m_pEntry = pEntry;

** CID 1465257:  Error handling issues  (CHECKED_RETURN)
/svx/source/sidebar/inspector/InspectorTextPanel.cxx: 80 in
svx::sidebar::InspectorTextPanel::updateEntries(const
std::vector<svx::sidebar::TreeNode, std::allocator<svx::sidebar::TreeNode>>
&)()


____________________________________________________________________________
____________________________
*** CID 1465257:  Error handling issues  (CHECKED_RETURN)
/svx/source/sidebar/inspector/InspectorTextPanel.cxx: 80 in
svx::sidebar::InspectorTextPanel::updateEntries(const
std::vector<svx::sidebar::TreeNode, std::allocator<svx::sidebar::TreeNode>>
&)()
74             pTreeDiagram->expand_row(rEntry);
75             return false;
76         });
77     
78         std::unique_ptr<weld::TreeIter> xEntry =
mxListBoxStyles->make_iterator();
79         mxListBoxStyles->get_iter_first(*xEntry);
> > >     CID 1465257:  Error handling issues  (CHECKED_RETURN)
> > >     Calling "iter_next" without checking return value (as is done
elsewhere 77 out of 79 times).
80         mxListBoxStyles->iter_next(*xEntry);
81         mxListBoxStyles->collapse_row(*xEntry); // Collapse "Default
Paragraph Style"
82     }
83     
84     InspectorTextPanel::~InspectorTextPanel() { disposeOnce(); }
85     

** CID 1465256:  Error handling issues  (UNCAUGHT_EXCEPT)
/usr/include/c++/8/bits/list.tcc: 67 in
std::__cxx11::_List_base<sc::DelayStartListeningFormulaCells,
std::allocator<sc::DelayStartListeningFormulaCells>>::_M_clear()()


____________________________________________________________________________
____________________________
*** CID 1465256:  Error handling issues  (UNCAUGHT_EXCEPT)
/usr/include/c++/8/bits/list.tcc: 67 in
std::__cxx11::_List_base<sc::DelayStartListeningFormulaCells,
std::allocator<sc::DelayStartListeningFormulaCells>>::_M_clear()()
61     _GLIBCXX_BEGIN_NAMESPACE_VERSION
62     _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
63     
64       template<typename _Tp, typename _Alloc>
65         void
66         _List_base<_Tp, _Alloc>::
> > >     CID 1465256:  Error handling issues  (UNCAUGHT_EXCEPT)
> > >     An exception of type "com::sun::star::uno::RuntimeException" is
thrown but the throw list "noexcept" doesn't allow it to be thrown. This
will cause a call to unexpected() which usually calls terminate().
67         _M_clear() _GLIBCXX_NOEXCEPT
68         {
69           typedef _List_node<_Tp>  _Node;
70           __detail::_List_node_base* __cur = _M_impl._M_node._M_next;
71           while (__cur != &_M_impl._M_node)
72      {

** CID 1465255:  Null pointer dereferences  (FORWARD_NULL)


____________________________________________________________________________
____________________________
*** CID 1465255:  Null pointer dereferences  (FORWARD_NULL)
/sc/source/ui/uitest/uiobject.cxx: 264 in ScGridWinUIObject::execute(const
rtl::OUString &, const std::map<const rtl::OUString, rtl::OUString,
std::less<const rtl::OUString>, std::allocator<std::pair<const
rtl::OUString, rtl::OUString>>> &)()
258                 pViewFunc->EditNote();
259             }
260             else if ( rParameters.find("CLOSE") != rParameters.end() )
261             {
262                 FuDraw* pDraw = dynamic_cast<FuDraw*>
(getViewFunc()->GetDrawFuncPtr());
263                 ScViewData* pViewData = mxGridWindow->getViewData();
> > >     CID 1465255:  Null pointer dereferences  (FORWARD_NULL)
> > >     Passing null pointer "pDraw" to "GetSlotID", which dereferences it.
264                 pViewData->GetDispatcher().Execute( pDraw->GetSlotID() ,
SfxCallMode::SLOT | SfxCallMode::RECORD );
265             }
266             else if ( rParameters.find("SETTEXT") != rParameters.end() )
267             {
268                 auto itr = rParameters.find("SETTEXT");
269                 const OUString rStr = itr->second;

** CID 1465254:  Uninitialized members  (UNINIT_CTOR)
/svtools/source/brwbox/ebbcontrols.cxx: 354 in
svt::ControlBase::ControlBase(BrowserDataWin *, const rtl::OUString &, const
rtl::OString &)()


____________________________________________________________________________
____________________________
*** CID 1465254:  Uninitialized members  (UNINIT_CTOR)
/svtools/source/brwbox/ebbcontrols.cxx: 354 in
svt::ControlBase::ControlBase(BrowserDataWin *, const rtl::OUString &, const
rtl::OString &)()
348             m_aModifyHdl.Call(nullptr);
349         }
350     
351         ControlBase::ControlBase(BrowserDataWin* pParent, const
OUString& rUIXMLDescription, const OString& rID)
352             : InterimItemWindow(pParent, rUIXMLDescription, rID)
353         {
> > >     CID 1465254:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member "m_pWidget" is not initialized in this
constructor nor in any functions that it calls.
354         }
355     
356         bool ControlBase::ControlHasFocus() const
357         {
358             if (!m_pWidget)
359                 return false;

** CID 1465253:  Error handling issues  (CHECKED_RETURN)
/svx/source/tbxctrls/verttexttbxctrl.cxx: 89 in
SvxVertCTLTextTbxCtrl::initialize(const
com::sun::star::uno::Sequence<com::sun::star::uno::Any> &)()


____________________________________________________________________________
____________________________
*** CID 1465253:  Error handling issues  (CHECKED_RETURN)
/svx/source/tbxctrls/verttexttbxctrl.cxx: 89 in
SvxVertCTLTextTbxCtrl::initialize(const
com::sun::star::uno::Sequence<com::sun::star::uno::Any> &)()
83             m_bVisible =
m_pToolbar->get_item_visible(m_aCommandURL.toUtf8());
84             return;
85         }
86     
87         ToolBox* pToolBox = nullptr;
88         sal_uInt16 nItemId = 0;
> > >     CID 1465253:  Error handling issues  (CHECKED_RETURN)
> > >     Calling "getToolboxId" without checking return value (as is done
elsewhere 52 out of 55 times).
89         getToolboxId(nItemId, &pToolBox);
90         m_bVisible = pToolBox && pToolBox->IsItemVisible(nItemId);
91     }
92     
93     void SAL_CALL SvxVertCTLTextTbxCtrl::statusChanged(const
css::frame::FeatureStateEvent& rEvent)
94     {

** CID 1465252:  Null pointer dereferences  (NULL_RETURNS)


____________________________________________________________________________
____________________________
*** CID 1465252:  Null pointer dereferences  (NULL_RETURNS)
/sc/source/ui/uitest/uiobject.cxx: 86 in ScGridWinUIObject::get_state()()
80         aMap["MarkedArea"] = aMarkedAreaString;
81     
82         ScDocument* pDoc = mxGridWindow->getViewData()->GetDocument();
83         ScAddress aPos( mxGridWindow->getViewData()->GetCurX() ,
mxGridWindow->getViewData()->GetCurY() ,
mxGridWindow->getViewData()->GetTabNo() );
84         if ( pDoc->HasNote( aPos ) )
85         {
> > >     CID 1465252:  Null pointer dereferences  (NULL_RETURNS)
> > >     Dereferencing a pointer that might be "nullptr"
"pDoc->GetNote(aPos)" when calling "GetText".
86             aMap["CurrentCellCommentText"] = pDoc->GetNote( aPos
)->GetText();
87         }
88     
89         ScAppOptions aOpt = SC_MOD()->GetAppOptions();
90         aMap["Zoom"] = OUString::number( aOpt.GetZoom() );
91         return aMap;


____________________________________________________________________________
____________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0
qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFD
d2LJ-2BDKI-3D99Zx_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitr
GlNxDIzPJiE28Dl5h7LfJkIDfjhwO634bXr2DudJsag-2F1U0-2FJdsHkSCiPcd-2ByU7z424ptx
aMQWUCQ-2BM8qk1NiqU5dSJyGtzmHC3I39YVEieF6JqXs-2BXCmYV9jztbN8nx-2B-2F-2BPEe75
ykjhQhg20LM8Gbs3-2Fvrs4h59FIy89oNWnQAnNRaXTCfxEF-2FwM8oFSmq3Ix259bRldF



------------------------------

Subject: Digest Footer

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


------------------------------

End of LibreOffice Digest, Vol 119, Issue 12
********************************************