ESC meeting minutes: 2020-05-28

* Present:
    + Gabriel, Olivier, Stephan, Michael W, Ilmari, Caolan, Thorsten, Cloph, Sophie, Miklos, Heiko, 
Eike, Michael S, Xisco, Eike

* Completed Action Items:
    + install java 9 on tinderboxes / jenkins slaves (tinderbox owners)
      + installed java 11 in fact (Cloph)

* Pending Action Items:
    + fix Jenkins_Callgrind at some stage (Cloph)
      [ must be an env var mismatch, custom LD_LIBRARY_PATH causes problems ]
    + run ‘make check’ as part of the TDF CI for online.git (Thorsten)

* Release Engineering update (Cloph)
    + 7.0 status: libreoffice-7-0 branch-off & feature freeze -> done now
      + beta1 is building
      + UI freeze & string freeze after that, in first week of July
      + may need one more beta
    + 6.4 status: will have rc1 for 6.4.5 in 2 weeks
    + 6.3 status: no more releases planned
    + Remotes
    + Android viewer
      + Android tinderbox is now setup (both arm and x86/32bit)
    + Online
      + libreoffice-7-0 branch is created (Andras)

* Documentation (Olivier)
    + New Help
        + Bug fixes in page layout (ohallot, buovjaga)
    + Helpcontent2
        + new pages on Solvers (ohallot)
        + bug fixes and updates (ohallot, S. Fanning, Johnny_M, Caolán)
    + GSoDoc
        + Several proposals
        + One for API documentation (Need mentor or co-mentor!)
    + Guides
        + Work in progress on all guides

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        243(243) (topicUI) bugs open, 274(274) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months
             added     12(6)      36(8)      88(6)     182(12)
         commented     97(-19)   464(43)   1052(9)    3495(61)
           removed      0(-1)      3(-1)     37(0)      46(0)
          resolved      5(-13)    56(-1)    128(-8)    343(0)
    + top 10 contributors:
          Heiko Tietze made 262 changes in 1 month, and 1993 changes in 1 year
          Telesto made 190 changes in 1 month, and 249 changes in 1 year
          Foote, V Stuart made 104 changes in 1 month, and 631 changes in 1 year
          Ilmari Lauhakangas made 62 changes in 1 month, and 139 changes in 1 year
          Dieter Praas made 61 changes in 1 month, and 533 changes in 1 year
          Kainz, Andreas made 42 changes in 1 month, and 436 changes in 1 year
          BogdanB made 35 changes in 1 month, and 59 changes in 1 year
          Xisco Faulí made 27 changes in 1 month, and 582 changes in 1 year
          Monastirsky, Maxim made 16 changes in 1 month, and 52 changes in 1 year
          Eyal Rozenberg made 13 changes in 1 month, and 32 changes in 1 year

    + New tickets with needsUXEval May/21-28

      * UI: Pressing Standard In frame style Graphics dialog changes Optimal
        wrap to Parallel wrap
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133469
      * LO goes back automatically to paragraph styles instead of staying on
        frames styles after pressnig OK
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133468
      * Duplicate Dialog
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133405
   -> * [UI] PDF export options dialog: Usage of term "bookmark" confusing
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133403
        + rename bookmark -> outline
      * Layout of a document different between 4.4.7.2 (and older) and 5.0
        and up
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133401
      * Missing "Surround header" and "Surround footer" Page Border options
        in Writer
        + https://bugs.documentfoundation.org/show_bug.cgi?id=121055
      * UI: RESET (to default) button for search and replace dialog
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133391
   -> * Lost New Gallery Stuff in 7.0
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132904
        + mentoring needed
        + first confirm is appreciated (Miklos)
      => in discussion, unconfirmed

      * Ctrl+PageDown doesn't change focus to the same cell in the next sheet
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133443
      * Import cell styles from another spreadsheet
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133430
   -> * Error importing a template should be explained
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133253
        + needsDevAdvice junit test fails,
      * Please add the ability to search for Page Styles
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133300
   -> * [UI] Please increase the 'needs save' indicator visibility
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133265
        + ui test failed
          see https://gerrit.libreoffice.org/c/core/+/94827
      * Applying Graphic style to an image can enable the Paragraph anchoring
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133291
      * UI: View > HTML-source works as a toggle function, but looks as an
        option button
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133204
      * Allow [Delete] to open "Delete Bitmap" dialog in Paragraph Style > Area
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133146
      * TOOLBAR: 'Fill Color' drop down control doesnt set color in 'Area
        Style / Filling' drop down
        + https://bugs.documentfoundation.org/show_bug.cgi?id=90853
      => NEW

      * Typing before a formatted word does not formatting but it does when
        word is at beginning of the line
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132891
      * Writer Feature Request - Advance to Page Break
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133314
      * Paint fill tool has no effect
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133319
      * UI: Make it possible to set the anchor in the Graphic style dialog
        + https://bugs.documentfoundation.org/show_bug.cgi?id=133293
      => WFM, DUP

* Crash Testing (Caolan)
    + 15(+4) import failure, 5(-1) export failures
    + 1 coverity issues (claims “running” I have my doubts)
    + 6 ossfuzz issues (-2)

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.3.6.2
        + (+190) 858 668 529 283 0
    + https://crashreport.libreoffice.org/stats/version/6.4.2.2
        + (-468) 3033 3501 3702 4322 5765 6869 6527 8046 6988 3716 0
    + https://crashreport.libreoffice.org/stats/version/6.4.3.2
        + (-1297) 6243 7540 6577 5725 4328 2199 0
    + https://crashreport.libreoffice.org/stats/version/6.4.4.2
        + (+1638) 1638 0
1. https://crashreport.libreoffice.org/stats/signature/SwRect::SwRect(tools::Rectangle%20const%20&)

* GSoC 2020 (Ilmari)
    + Projects announced: https://blog.documentfoundation.org/blog/2020/05/05/9769/
    + June 1, 2020 - August 24, 2020: Students work on their projects
    + 6 projects accepted

* Mentoring/easyhack update
          committer...   1 week      1 month      3 months     12 months
                  open      88(-9)      144(-7)      150(-8)       162(-8)
               reviews     368(-128)   1656(-82)    4110(-212)   21657(-388)
                merged     294(-92)    1686(-82)    4543(-144)   19028(-74)
             abandoned      21(3)        93(-10)     273(-14)     1031(1)
           own commits     252(-35)    1380(-104)   3756(-75)    15641(-45)
        review commits     107(1)       428(-4)     1139(4)       4650(0)
        contributor...   1 week       1 month     3 months      12 months
                  open       32(-7)       76(7)        78(7)         80(7)
               reviews     1110(-124)   4406(-26)   10864(-180)   39706(152)
                merged       43(0)       125(20)      302(11)       869(28)
             abandoned        6(-3)       33(0)       128(-5)       546(0)
           own commits       53(0)       173(20)      440(15)      1120(38)
        review commits        0(0)         0(0)         0(0)          0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 2(2)   cleanup_comments 221(221)
       total 268(268)   assigned 24(24)   open 226(226)
    + top 10 contributors:
          Johnny_M made 58 patches in 1 month, and 78 patches in 1 year
          LibreOfficiant made 16 patches in 1 month, and 128 patches in 1 year
          Steve Fanning made 14 patches in 1 month, and 16 patches in 1 year
          himajin100000 made 6 patches in 1 month, and 18 patches in 1 year
          Attila Bakos made 5 patches in 1 month, and 14 patches in 1 year
          Ilmari Lauhakangas made 4 patches in 1 month, and 22 patches in 1 year
          Marco A.G.Pinto made 4 patches in 1 month, and 19 patches in 1 year
          Aditya Sahu made 3 patches in 1 month, and 6 patches in 1 year
          Weblate made 3 patches in 1 month, and 52 patches in 1 year
          mesut çifci made 3 patches in 1 month, and 16 patches in 1 year
    + top 10 reviewers:
          Timar, Andras made 206 review comments in 1 month, and 1375 in 1 year
          Behrens, Thorsten made 166 review comments in 1 month, and 1230 in 1 year
          Olivier Hallot made 108 review comments in 1 month, and 448 in 1 year
          Adolfo Jayme Barrientos made 102 review comments in 1 month, and 1068 in 1 year
          Michael Stahl made 100 review comments in 1 month, and 1438 in 1 year
          Vajngerl, Tomaž made 82 review comments in 1 month, and 252 in 1 year
          Nabet, Julien made 82 review comments in 1 month, and 1884 in 1 year
          Meeks, Michael made 64 review comments in 1 month, and 852 in 1 year
          Bergmann, Stephan made 62 review comments in 1 month, and 911 in 1 year
          Németh, László made 58 review comments in 1 month, and 539 in 1 year
    + Patches automatically abandoned:
        Don't busy lock UITest_calc_tests ( Jan-Marek Glogowski )
            - https://gerrit.libreoffice.org/#/c/88834

        tdf#129342 EMF+ Initial support of BrushTypeTextureFill ( Bartosz Kosiorek )
            - https://gerrit.libreoffice.org/#/c/90134

        tdf#131358 Delete "Snap to grid" ( Roman Kuznetsov )
            - https://gerrit.libreoffice.org/#/c/90400

    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Ogasawara, Naruhiko
          So Yanaihara

* Commit Access
    + None

* Developer Certification (Stephan/Kendy/Thorsten)
    + sleep 16 weeks
    + seeking for a new person as a replacement for Bjoern, who is currently
      inactive

* Jenkins / CI update (Christian)
    from:Thu May 21 13:36:55 2020
    master linux rel  jobs:  59 ok:  59 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master linux dbg  jobs:  52 ok:  38 ko:  13 fail ratio: 25.00 % break:   7 broken 
duration:45.05%
    master mac rel    jobs:  85 ok:  83 ko:   2 fail ratio:  2.35 % break:   1 broken 
duration:15.99%
    master mac dbg    jobs:  83 ok:  81 ko:   2 fail ratio:  2.41 % break:   1 broken duration: 
0.06%
    master win rel    jobs:  98 ok:  97 ko:   1 fail ratio:  1.02 % break:   1 broken duration: 
0.75%
    master win dbg    jobs: 100 ok:  99 ko:   1 fail ratio:  1.00 % break:   1 broken duration: 
0.61%
    master win64 dbg  jobs: 103 ok: 102 ko:   1 fail ratio:  0.97 % break:   1 broken duration: 
0.61%
    master gerrit lin jobs: 561 ok: 417 ko:  98 fail ratio: 17.47% time for ok: mean:  23 median:  
22
    master gerrit plg jobs: 549 ok: 276 ko: 208 fail ratio: 37.89% time for ok: mean:  31 median:  
28
    master gerrit win jobs: 576 ok: 397 ko: 122 fail ratio: 21.18% time for ok: mean:  55 median:  
52
    master gerrit mac jobs: 592 ok: 381 ko: 159 fail ratio: 26.86% time for ok: mean:  36 median:  
34
    master gerrit all jobs: 573 ok: 227 ko: 271 fail ratio: 47.29% time for ok: mean:  66 median:  
60
   + https://dev-www.libreoffice.org/tmp/gerrit_200528.html
   + tests failing more than twice in last seven days
      3 JunitTest_ridl_remote
      4 CppunitTest_sw_uwriter
      5 UITest_chart
     10 CppunitTest_sw_uiwriter
     12 CppunitTest_services
     16 CppunitTest_dbaccess_hsqldb_test
     17 CppunitTest_dbaccess_RowSetClones
     20 UITest_writer_tests7
     24 UITest_calc_demo
     28 JunitTest_toolkit_unoapi_1

  + lots of unstable tests, not 100% reproducible
    + JunitTest_toolkit_unoapi_1 -> did the revert help? (Stephan)
      + it should help more and more as people rebase (Cloph)
    + heads-up: working on kill-timeout handler to have better error reporting (Stephan)
      + will give you an output, hiting which uitest hangs


* l10n (Sophie)
  + Wrong translations in Formula names, etc. have been removed

* Graphics architecture (Thorsten)
  * https://pad.documentfoundation.org/p/ESC_graphics_architecture
  * skia / vulkan: to try it on master (Lubos)
    + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
      + 4 (-1) open bugs, 65 total (+9)

* macOS runtime baseline (Eivind, from mailing list)
    + proposal:
        + runtime: bump requirement from 10.10 to 10.11
        + also deprecate <10.14
    + rationale: “Then a depreciation warning should be put in for 10.12-13 as they will not 
receive security fixes past this fall”
    + prefer to have input from Cloph and Stephan (Xisco)
    + bump to 10.10 was just a year ago, so maybe jump to 10.11 may be too new
    + a year ago, 10.10 was 6.24%, and halved since then (Ilmari)
=> postponing till next week
    + if there is something in the code, then decide to drop the 10.10 version, not the other way 
around (Stephan)
      + same as Windows 7 (Miklos)
    + fine with deprecation for 10.10 & 10.11 on master/7.1 (Cloph)
AI:      + will put the deprecation notice to the 7.0 release notes (Ilmari)
    + Metal via skia would need this (Ilmari)
      + in theory

* QA update (Xisco)
    + Please help flesh out the monthly reports:
          https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 765 (+57)
        + enhancements: 86  (+7)
        + needsUXEval: 17 (+7)
        + haveBackTrace: 1 (+1)
        + needsDevAdvice: 12 (+0)
        + documentation:  11 (-1)
        + android:  4 (+0)
        + iOS:  0 (+0)
        + Online:  14 (+0)



    + Most pressing bugs:
     New:
        + Objects are not printed (Win-only)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=133216
            + fixed, thanks to Chris (reverted)
     Old:
       + macOS: Can't Save As after installing language pack on Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=132025
           + more info here: “Subject: Budget 2020 proposals and macOS Catalina support / 
onboarding” on the dev list (Heiko)

       + Notarize LibreOffice builds so that it launches without warnings on macOS 10.15 Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126409
           + Cloph?
           + Catalina doesn't seem to complain about this anymore (Cloph)

       + Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
           + https://bugs.documentfoundation.org/show_bug.cgi?id=116079
           + regression from the fastparser gsoc work from 2016
          + Mohammed is no longer around, Julien is asking for tips

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

    + New high severity bugs of the week:
        + New Print dialog: impossible to only print even/odd pages from a range/selection
            + https://bugs.documentfoundation.org/show_bug.cgi?id=127680
            + regression, but not bisected
            + advice from UX is appreciated (Xisco)
            + will comment in the bug (Heiko)

        + Time to copy sheet has doubled
            + https://bugs.documentfoundation.org/show_bug.cgi?id=121745
            + Henry?

        + Huge ram amount used not freed
            + https://bugs.documentfoundation.org/show_bug.cgi?id=125428
            + Kohei → Dennis / Lubos?
            + Lubos's proposed patch at <https://gerrit.libreoffice.org/c/core/+/95045>

        + Redo from instantaneous to 3 minutes waiting time
            + https://bugs.documentfoundation.org/show_bug.cgi?id=133302
            + Dennis?

        + Crash in: sw::GetParaPropsNode
            + https://bugs.documentfoundation.org/show_bug.cgi?id=133358
            + Michael S?

        + LO Writer form controls tab order is broken
            + https://bugs.documentfoundation.org/show_bug.cgi?id=133158
            + regression, not yet bisected
            + macOS-specific

* QA stats
    + plan to check if these stats are accurate (Xisco)
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +240  -46 (-195) overall)
      many thanks to the top bug squashers:
       QA Administrators       30
       Telesto                 21
       Timur                   11
       Aron Budea              9
       V Stuart Foote          9
       Buovjaga                8
       Luboš Luňák             8
       NISZ LibreOffice Team   8
       Michael Stahl (CIB)     7
       Caolán McNamara         6

    + top 10 bugs reporters:
       Telesto                 37
       Luke Kendall            7
       JBrown                  6
       NISZ LibreOffice Team   6
       Nicolas Christener      6
       Regina Henschel         5
       Menoo                   4
       Timur                   4
       Mike Kaganski           3
       Rizal Muttaqin          3

    + top 10 bugs fixers:
       Michael Stahl           7
       McNamara, Caolán        6
       Luboš Luňák             5
       Balazs Varga            3
       Justin Luth             3
       Olivier Hallot          3
       Budea, Áron             2
       DaeHyun Sung            2
       Kainz, Andreas          2
       Kosiorek, Bartosz       2

    + top 10 bugs confirmers:
       Dieter Praas            17
       Telesto                 12
       Xisco Faulí             12
       b.                      8
       *UNKNOWN*               7
       Budea, Áron             7
       Heiko Tietze            7
       Timur                   7
       Ilmari Lauhakangas      6
       m.a.riosv               6


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/52 -     1 %  (+0)
     5.4 : 1/41 -     2 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 1/36 -     2 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 1/133 -    0 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 3/82 -     3 %  (+0)
     old : 6/245 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 745/4274 737/4241 737/4219 728/4195 708/4160 704/4138 699/4119

     done by:
        Telesto               20
        Xisco Faulí            5
        Timur                  3
        Ilmari Lauhakangas     2
        Kelemen, Gabor         1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 924/5130 917/5096 915/5071 905/5045 883/5006 877/4982 870/4962

     done by:
        Telesto               20
        Xisco Faulí            5
        Timur                  3
        Ilmari Lauhakangas     2
        Justin Luth            1
        Kelemen, Gabor         1


* all bugs tagged with 'regression'
   + 1182(+2) bugs open of 9695(+35) total 10(+3) high prio.

     done by:
        Telesto               20
        Xisco Faulí            4
        Budea, Áron            2
        Timur                  2
        Roman Kuznetsov        1
        Dieter Praas           1
        Ilmari Lauhakangas     1
        Alex Thurgood          1
        Justin Luth            1
        Kaganski, Mike         1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Calc          - 4(+1)
     Writer        - 3(+1)
     Impress       - 1(+0)
     LibreOffice   - 1(+0)
     Printing and PDF export - 1(+1)

   by OS:
     All           - 5(+1)
     Linux         - 1(+0)
     Mac OS X      - 0(+0)
     Windows       - 4(+2)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 338(+0)
     Calc                     - 231(+5)
     Impress                  - 133(-2)
     LibreOffice              - 63(-4)
     Writer: docx filter      - 54(+0)
     Crashes                  - 48(+0)
     Draw                     - 45(-1)
     Borders                  - 41(-1)
     UI                       - 40(-1)
     Writer: perf             - 36(+0)
     Base                     - 30(-1)
     graphics stack           - 28(+0)
     Writer: doc filter       - 27(+2)
     Writer: other filter     - 27(+0)
     Printing and PDF export  - 25(+1)
     Chart                    - 24(+0)
     RTL                      - 23(+1)
     filters and storage      - 21(-1)
     BASIC                    - 16(+0)
     framework                - 2(+0)
     Formula Editor           - 1(+0)
     Installation             - 1(+0)
     sdk                      - 1(+0)