ESC meeting minutes: 2020-05-14

* Present:
    + Heiko, Cloph, Caolan, Ilmari, Michael W, Stephan, Gabriel, Olivier, Xisco, Sophie, Eike, 
Miklos, Michael M, Thorsten, Michael S

* Completed Action Items:
    + add `make screenshot´ to gerrit_linux_clang_dbgutil (Stephan)

* Pending Action Items:
    + Pranam, send the new-committer mail (Kendy)
    + fix Jenkins_Callgrind at some stage (Cloph)
      [ must be an env var mismatch, custom LD_LIBRARY_PATH causes problems ]

* Release Engineering update (Cloph)
    + 7.0 status: libreoffice-7-0 branch-off & feature freeze in 2 weeks
      + UI freeze & string freeze after that
      + any late feature proposals? (Miklos)
        + ODF 1.3 support will be in by the deadline, probably (Thorsten)
    + 6.4 status: 6.4.4 rc2 is tagged, builds started
    + 6.3 status: no more releases planned
    + Remotes
    + Android viewer
      + Android tinderbox has problems, will probably fix it for next week
    + Online

* Java baseline update, to version 9 (Thorsten)
  + benefits (Michael S)
    + will be able to build some java module (not possible with java 8)
    + target version for the java bytecode is still 8, just the module part would be 9
    + then extensions can use this “module”, not 4 jar files
    + java 11 available on Linux baseline (Cloph)
=> no objections (all)
AI: install java 9 on tinderboxes / jenkins slaves until May 21st (tinderbox owners)

* Documentation (Olivier)
    + New Help
        + Fix in build
    + Helpcontents2
        + Updates and fixes (libreofficiant, ohallot, fistoshido, Johnny_M, Laurent BP, M. Kaganski)
    + Google Seasons of Doc
        + TDF approved, community bonding phase start, ends June 8th.
    + Guides
        + Work in progress towards 6.4

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        243(243) (topicUI) bugs open, 270(270) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month    3 months    12 months
             added      15(4)     35(9)       88(6)      176(8)
         commented     132(18)   452(107)   1122(128)   3491(209)
           removed       1(0)      3(0)       38(1)       45(0)
          resolved      19(0)     55(9)      134(7)      332(10)
    + top 10 contributors:
          Heiko Tietze made 276 changes in 1 month, and 1961 changes in 1 year
          Telesto made 109 changes in 1 month, and 156 changes in 1 year
          Kainz, Andreas made 95 changes in 1 month, and 468 changes in 1 year
          Ilmari Lauhakangas made 72 changes in 1 month, and 132 changes in 1 year
          Foote, V Stuart made 72 changes in 1 month, and 575 changes in 1 year
          Dieter Praas made 38 changes in 1 month, and 509 changes in 1 year
          Xisco Faulí made 29 changes in 1 month, and 604 changes in 1 year
          Rizal Muttaqin made 21 changes in 1 month, and 67 changes in 1 year
          eisa01 made 19 changes in 1 month, and 28 changes in 1 year
          BogdanB made 16 changes in 1 month, and 40 changes in 1 year

     + New tickets with needsUXEval May/08-15
       + 28 new

     * Improve the UX during saving
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131283
       + possible to put saving in a thread working on a temp file?
       + sounds hard, export filters assume the doc model does not change (Miklos)
     * Optimal wrap wraps mostly at the right even enough room (2cm) at the left
       + https://bugs.documentfoundation.org/show_bug.cgi?id=132928
       + seeking input how optimal works
       + not happy with how it works (Michael)
         + additional problem: it’s the default
       + a terrible default (Heiko)
       + parallel would probably do what most users expect (Cloph)
AI:    + will look at what would be a good default on the UI (Heiko)
         + will find a better name for “optimal”

     * Remove mediawiki template from sources
       + https://bugs.documentfoundation.org/show_bug.cgi?id=132625
       + https://opengrok.libreoffice.org/search?project=core&full=mediawiki
       + remove all mediawiki code/templates/scripts?
       + don’t think it should be removed (Ilmari)
         + know people who use it
       + if we drop the template, but not the exporter, that breaks things (Heiko)
       + what maintenance would be needed for the mediawiki export? (Michael S)
     => needsDevAdvice

* Crash Testing (Caolan)
    + 11(+0) import failure, 6(+0) export failures
    + 1 coverity issues
    + 8 ossfuzz issues
    + 6.3 EOL is 29th May
      + can announce issues after that

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.3.5.2
        + (-135) 1693 1828 1771 1474 1755 1845 1565 1167 961 635 312 0
    + https://crashreport.libreoffice.org/stats/version/6.3.6.2
        + (+246) 529 283 0
    + https://crashreport.libreoffice.org/stats/version/6.4.1.2
        + (-89) 1928 2017 2195 2230 1961 2884 4166 5344 5609 3687 2052 0
    + https://crashreport.libreoffice.org/stats/version/6.4.2.2
        + (-620) 3702 4322 5765 6869 6527 8046 6988 3716 0
    + https://crashreport.libreoffice.org/stats/version/6.4.3.2
        + (+852) 6577 5725 4328 2199 0
    + stats don’t look bad, similar to previous weeks (Xisco)
- Crash without steps:
1. https://crashreport.libreoffice.org/stats/signature/vcl::Window::GetParentWithLOKNotifier()
    + it’s there since 6.1, no reproducer steps yet

* GSoC 2020 (Ilmari)
    + Projects announced: https://blog.documentfoundation.org/blog/2020/05/05/9769/
    + June 1, 2020 - July 3, 2020: Students work on their projects
    + 6 projects accepted
    + mentors: please reach out to your students to start community bonding (Thorsten)
      + expect: students present themselves on the dev list during the next week
      + everyone expect 1 student appeared on the dev list (Ilmari)
        + will help sorting this out (Xisco)

* Mentoring/easyhack update
          committer...   1 week     1 month     3 months     12 months
                  open     102(6)      158(-16)    164(-14)      176(-16)
               reviews     648(242)   1654(192)   4354(-208)   22213(-88)
                merged     524(161)   1798(261)   4709(123)    19070(261)
             abandoned      38(24)     114(9)      295(-2)      1030(19)
           own commits     416(111)   1535(216)   3906(85)     15722(197)
        review commits     114(50)     393(52)    1117(-50)     4638(10)
        contributor...   1 week      1 month     3 months     12 months
                  open       40(9)       68(10)       69(10)       71(10)
               reviews     1430(350)   4388(406)   10962(39)    39264(496)
                merged       20(-3)      76(-35)     268(-69)     818(-70)
             abandoned        5(0)       28(-4)      131(-5)      538(-2)
           own commits       34(0)      121(-26)     392(-52)    1052(-47)
        review commits        0(0)        0(0)         0(0)         0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 2(2)   cleanup_comments 220(220)
       total 266(266)   assigned 22(22)   open 225(225)
    + top 10 contributors:
          LibreOfficiant made 38 patches in 1 month, and 134 patches in 1 year
          Johnny_M made 14 patches in 1 month, and 30 patches in 1 year
          Weblate made 6 patches in 1 month, and 50 patches in 1 year
          Marco A.G.Pinto made 4 patches in 1 month, and 19 patches in 1 year
          Attila Bakos made 4 patches in 1 month, and 12 patches in 1 year
          Ian Barkley-Yeung made 3 patches in 1 month, and 3 patches in 1 year
          Sophia Schröder made 2 patches in 1 month, and 20 patches in 1 year
          Ilmari Lauhakangas made 2 patches in 1 month, and 25 patches in 1 year
          Aditya Sahu made 2 patches in 1 month, and 5 patches in 1 year
          Szabolcs Tóth (NISZ) made 2 patches in 1 month, and 22 patches in 1 year
    + top 10 reviewers:
          Timar, Andras made 194 review comments in 1 month, and 1369 in 1 year
          Behrens, Thorsten made 148 review comments in 1 month, and 1264 in 1 year
          Michael Stahl made 142 review comments in 1 month, and 1500 in 1 year
          Adolfo Jayme Barrientos made 104 review comments in 1 month, and 1064 in 1 year
          Nabet, Julien made 88 review comments in 1 month, and 2056 in 1 year
          Vajna, Miklos made 72 review comments in 1 month, and 1320 in 1 year
          Olivier Hallot made 70 review comments in 1 month, and 392 in 1 year
          Meeks, Michael made 68 review comments in 1 month, and 886 in 1 year
          Bergmann, Stephan made 66 review comments in 1 month, and 949 in 1 year
          Grandin, Noel made 54 review comments in 1 month, and 1121 in 1 year
    + Patches automatically abandoned:
        tdf#42982: improve UNO API error reportings ( Hakan Bakacak )
            - https://gerrit.libreoffice.org/#/c/87616
        Introduce javacheck target and move Java tests ( Jan-Marek Glogowski )
            - https://gerrit.libreoffice.org/#/c/88833
        tdf#124983 In calc make printable page borders initially visible ( Ilhan Yesil )
            - https://gerrit.libreoffice.org/#/c/90101
        WIP allow relative URLs ( Jan-Marek Glogowski )
            - https://gerrit.libreoffice.org/#/c/90139
        WiP: Revamp keyboard tab of Customize dialog ( Muhammet Kara )
            - https://gerrit.libreoffice.org/#/c/90183
        Change in height of textviews recent files and all files from 48dp to wrap_content to fix 
overflow ( Rutuja Kendre )
            - https://gerrit.libreoffice.org/#/c/90246
        editeng: minor cleanup ( Ashod Nakashian )
            - https://gerrit.libreoffice.org/#/c/90294
        desktop: minor cleanup ( Ashod Nakashian )
            - https://gerrit.libreoffice.org/#/c/90295
        desktop: deduplicate all identical window events ( Ashod Nakashian )
            - https://gerrit.libreoffice.org/#/c/90296
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Colomban Wendling (Hypra)

* Commit Access
    + None

* Developer Certification (Stephan/Kendy/Thorsten)
    + sleep 18 weeks
    + seeking for a new person as a replacement for Bjoern, who is currently
      inactive

* Jenkins / CI update (Christian)
    from:Thu May  7 13:58:30 2020
    master linux rel  jobs:  53 ok:  51 ko:   2 fail ratio:  3.77 % break:   1 broken duration: 
0.61%
    master linux dbg  jobs:  55 ok:  48 ko:   7 fail ratio: 12.73 % break:   4 broken duration: 
9.77%
    master mac rel    jobs: 122 ok: 119 ko:   3 fail ratio:  2.46 % break:   2 broken duration: 
7.20%
    master mac dbg    jobs: 123 ok: 121 ko:   1 fail ratio:  0.81 % break:   1 broken duration: 
0.72%
    master win rel    jobs:  93 ok:  91 ko:   2 fail ratio:  2.15 % break:   1 broken duration: 
0.65%
    master win dbg    jobs:  97 ok:  96 ko:   1 fail ratio:  1.03 % break:   1 broken duration: 
0.31%
    master win64 dbg  jobs:  92 ok:  90 ko:   2 fail ratio:  2.17 % break:   1 broken duration: 
0.63%
    master gerrit lin jobs: 831 ok: 610 ko: 164 fail ratio: 19.74% time for ok: mean:  23 median:  
22
    master gerrit plg jobs: 804 ok: 514 ko: 205 fail ratio: 25.50% time for ok: mean:  31 median:  
28
    master gerrit win jobs: 871 ok: 565 ko: 215 fail ratio: 24.68% time for ok: mean:  53 median:  
53
    master gerrit mac jobs: 833 ok: 685 ko:  95 fail ratio: 11.40% time for ok: mean:  24 median:  
19
    master gerrit all jobs: 839 ok: 420 ko: 286 fail ratio: 34.09% time for ok: mean: 103 median:  
91
   + https://dev-www.libreoffice.org/tmp/gerrit_200514.html
   + tests that failed more than twice in last seven days
      3 CppunitTest_chart2_export
      3 CppunitTest_sc_subsequent_filters_test
      3 CppunitTest_sw_uibase_shells
      4 CppunitTest_sw_ooxmlexport14
      4 UITest_writer_tests
      5 CppunitTest_sc_statistical_functions_test
      5 CppunitTest_sw_mailmerge
      5 CppunitTest_xmlsecurity_signing
      6 CppunitTest_sw_ooxmlexport8
      9 UITest_impress_tests
     27 CppunitTest_sw_uiwriter

    + out of order change submission caused some problems, fixed now
    + Michael Stahl did fixes on the sw_uiwriter test failure
      + not remember that (Michael S)
    + large patch set submission -> longer build times
    + added an online.git Jenkins builder
      + just building the code, no tests yet
      + same host as the daily docker image

* l10n (Sophie)
  + Wrong translations in Formula names, etc. will be removed next week

* Graphics architecture (Thorsten)
  * https://pad.documentfoundation.org/p/ESC_graphics_architecture
  * skia / vulkan: to try it on master (Lubos)
    + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
      + 5 (-1) open bugs, 55 total (+3)

* QA update (Xisco)
    + Please help flesh out the monthly reports:
          https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 724 (-130)
        + enhancements: 74  (-29)
        + needsUXEval: 11 (+2)
        + haveBackTrace: 0 (-1)
        + needsDevAdvice: 13 (+2)
        + documentation:  15 (-8)
        + android:  5 (+0)
        + iOS:  0 (+0)
        + Online:  15 (+1)

    + Most pressing bugs:
     New:
        + Crash when I press down arrow in edit header dialog using e.g, Japanese keyboard
            + https://bugs.documentfoundation.org/show_bug.cgi?id=129620
            + will try to bisect (Xisco)

     Old:
       + macOS: Can't Save As after installing language pack on Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=132025
           + more info here: “Subject: Budget 2020 proposals and macOS Catalina support / 
onboarding” on the dev list (Heiko)

       + Notarize LibreOffice builds so that it launches without warnings on macOS 10.15 Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126409
           + Cloph?

       + Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
           + https://bugs.documentfoundation.org/show_bug.cgi?id=116079
           + regression from the fastparser gsoc work from 2016
          + Mohammed is no longer around, Julien is asking for tips

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it
    Fixed:
        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=132783
                + Thanks to Luboš


    + New high severity bugs of the week:
        + Enabling 'follow text flow' causes shape to not render
            + https://bugs.documentfoundation.org/show_bug.cgi?id=113373
            + Michael S?

        + FILEOPEN: Cell in table is displayed on next page
            + https://bugs.documentfoundation.org/show_bug.cgi?id=128437
                + Michael S?

        + 'performance problem with plenty comments' still in 6.3 alpha1, *only after save of 
file/autosave*
            + https://bugs.documentfoundation.org/show_bug.cgi?id=125619
            + Armin?
            + the problem is that (a) as soon as we display a note it becomes an SdrObject and 
stays an SdrObject until Calc closes (b) when we save, we create an SdrObject for every note during 
the save process (Noel)
            + tons of SdrObjects interact badly with the accessibility stuff in calc, and it 
becomes a huge slowdown. I've optimized the accessibility stuff as much as possible, but we have 
run out of easy/medium fixes
            + even if we throw away things after a timeout, it won’t help much (Eike)

        + calc using scenarios crash after 5 minutes away
            + https://bugs.documentfoundation.org/show_bug.cgi?id=127957
            + not a regression

        + Catalina: Can't open attachments in Mail due to Lock File issues (full disk access 
workaround)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=128526
            + Tor will take a look

        + Cannot change data point icons in Calc's XY or points and lines chart
            + https://bugs.documentfoundation.org/show_bug.cgi?id=131333
            + regression, not bisected

        + FILEOPEN Old base file (*.dbf) created in LO fails to open in 6.4.2.2
            + https://bugs.documentfoundation.org/show_bug.cgi?id=132713
            + regression, not bisected

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +227  +26 (-220) overall)
      many thanks to the top bug squashers:
       Buovjaga                33
       Telesto                 14
       Aron Budea              13
       QA Administrators       13
       Xisco Faulí             13
       eisa01                  12
       Heiko Tietze            11
       Julien Nabet            10
       Mike Kaganski           7
       Caolán McNamara         5

    + top 10 bugs reporters:
       Telesto                 70
       NISZ LibreOffice Team   9
       Alvaro Segura           3
       Heiko Tietze            3
       Rizal Muttaqin          3
       Robert Großkopf         3
       andreas_k               3
       joalisson               3
       Adolfo Jayme            2
       Gerald Pfeifer          2

    + top 10 bugs fixers:
       McNamara, Caolán        5
       Nabet, Julien           4
       Budea, Áron             3
       Justin Luth             3
       Kaganski, Mike          3
       Kainz, Andreas          3
       Luboš Luňák             3
       Vajna, Miklos           3
       Xisco Faulí             3
       *UNKNOWN*               2

    + top 10 bugs confirmers:
       Xisco Faulí             86
       Ilmari Lauhakangas      53
       Heiko Tietze            18
       Dieter Praas            17
       Alex Thurgood           12
       Telesto                 11
       *UNKNOWN*               9
       Nabet, Julien           6
       BogdanB                 5
       Kaganski, Mike          5


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/52 -     1 %  (+0)
     5.4 : 2/41 -     4 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 1/36 -     2 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 1/133 -    0 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 3/82 -     3 %  (+0)
     old : 6/245 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Xisco Faulí             9
        Timur                   5
        Telesto                 4
        Budea, Áron             3
        eisa01                  1
        NISZ LibreOffice Team   1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Xisco Faulí             9
        Timur                   5
        Telesto                 4
        Budea, Áron             3
        Ilmari Lauhakangas      1
        NISZ LibreOffice Team   1


* all bugs tagged with 'regression'
   + 1173(+12) bugs open of 9632(+28) total 5(-1) high prio.

     done by:
        Telesto                   14
        Xisco Faulí                6
        Roman Kuznetsov            1
        Dieter Praas               1
        eisa01                     1
        Heiko Tietze               1
        Alex Thurgood              1
        Balland-Poirier, Laurent   1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Calc          - 2(-1)
     Impress       - 1(+0)
     LibreOffice   - 1(+0)
     Writer        - 1(+0)

   by OS:
     All           - 2(-1)
     Linux         - 1(+0)
     Mac OS X      - 1(+0)
     Windows       - 1(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 341(+12)
     Calc                     - 222(-1)
     Impress                  - 134(+1)
     LibreOffice              - 66(-1)
     Writer: docx filter      - 55(-2)
     Crashes                  - 48(+0)
     Draw                     - 47(+1)
     Borders                  - 41(+1)
     UI                       - 41(+2)
     Writer: perf             - 36(+0)
     Base                     - 32(-1)
     graphics stack           - 28(-1)
     Writer: other filter     - 27(+0)
     Writer: doc filter       - 25(+0)
     Printing and PDF export  - 24(+0)
     Chart                    - 23(+0)
     RTL                      - 22(+0)
     filters and storage      - 22(+0)
     BASIC                    - 16(+0)
     framework                - 2(+0)
     Installation             - 1(+0)
     sdk                      - 1(+0)