ESC meeting minutes: 2020-05-07

* Present:
    + Stephan, Sophie, Michael W, Cloph, Heiko Caolan, Ilmari, Michael S, Olivier, Miklos, 
Thorsten, Xisco, Eike, Gabriel

* Completed Action Items:
    + Pranam, toggle the committer bit button (Cloph)
    + Install clang-cl on the Windows bots (buildbot owners)
      [ done earlier today ]

* Pending Action Items:
    + Pranam, send the new-committer mail (Kendy)
    + fix Jenkins_Callgrind at some stage (Cloph)
      [ must be an env var mismatch ]

* Release Engineering update (Cloph)
    + 7.0 status: alpha was tagged yesterday
      + problem with mac signing, fixed
    + 6.4 status: 6.4.4 rc2 will be tagged next week
    + 6.3 status: no more releases planned
    + Remotes
    + Android viewer
      + Android tinderbox has problems, need HW help -> still broken
      + maybe it’ll be moved to TDF infra
    + Online

* Documentation (Olivier)
    + New Help
       + CSS fixes (buovjaga)
       + patch to automate icon replacement table (ohallot)
    + Helpcontent2
       + Several fixes and enhancements (ohallot, libreofficiant, S. Schröder)
    + Guides
       + Published Getting Started Guide 6.4

    + Google Seasons of Doc
       + Awaiting response for application

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        244(244) (topicUI) bugs open, 264(264) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week     1 month    3 months    12 months
             added      12(-7)     26(-4)      84(-4)     170(-3)
         commented     109(-25)   377(-54)   1057(-20)   3378(51)
           removed       1(0)       3(1)       37(1)       45(1)
          resolved      17(11)     44(-2)     126(7)      319(7)
    + top 10 contributors:
          Heiko Tietze made 219 changes in 1 month, and 1881 changes in 1 year
          Kainz, Andreas made 110 changes in 1 month, and 467 changes in 1 year
          Foote, V Stuart made 52 changes in 1 month, and 560 changes in 1 year
          Dieter Praas made 47 changes in 1 month, and 497 changes in 1 year
          Telesto made 47 changes in 1 month, and 85 changes in 1 year
          Ilmari Lauhakangas made 46 changes in 1 month, and 103 changes in 1 year
          Thomas Lendo made 19 changes in 1 month, and 253 changes in 1 year
          Timur made 18 changes in 1 month, and 208 changes in 1 year
          Rizal Muttaqin made 18 changes in 1 month, and 64 changes in 1 year
          Cor Nouws made 17 changes in 1 month, and 179 changes in 1 year

    + New tickets with needsUXEval Apr/30-May/07

      + 16 (not listing all)
      + image compression/resolution 132657, 132658, 132656
      + styles, templates 132718, 132798, 132625, 132572, 132570…

      + Change Arabic diacritics' colours separate from base font colour
        + https://bugs.documentfoundation.org/show_bug.cgi?id=129330
        + autocorrection to apply a character style?
      + FORMATTING: Clone Formatting should allow typing when in multiple
        selection mode
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128719
        + make functions sticky until escape?
        + did you research what the competition does? (Miklos)
          + not interesting, if that’s your workflow (Heiko)

* Crash Testing (Caolan)
    + 11(-5) import failure, 6(-1) export failures
      + bisected 1 export failure, results are sent to the list
    + 1 coverity issues
    + 9 Google / ossfuzz

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.3.5.2
        + (+57) 1828 1771 1474 1755 1845 1565 1167 961 635 312 0
    + https://crashreport.libreoffice.org/stats/version/6.3.6.2
        + (+283) 283 0
    + https://crashreport.libreoffice.org/stats/version/6.4.1.2
        + (-178) 2017 2195 2230 1961 2884 4166 5344 5609 3687 2052 0
    + https://crashreport.libreoffice.org/stats/version/6.4.2.2
        + (-1443) 4322 5765 6869 6527 8046 6988 3716 0
    + https://crashreport.libreoffice.org/stats/version/6.4.3.2
        + (+1397) 5725 4328 2199 0
    + trend is ~OK
    + still researching what decides the lack of symbols (Windows version)

* GSoC 2020 (Ilmari)
    + Projects announced: https://blog.documentfoundation.org/blog/2020/05/05/9769/
    + June 1, 2020 - July 3, 2020: Students work on their projects
    + 6 projects accepted
    + mentors: please reach out to your students to start community bonding (Thorsten)
      + expect: students present themselves on the dev list during the next week

* Mentoring/easyhack update
    + reviewing patches from first contributors is much appreciated (Muhammet)
    + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers

          committer...   1 week     1 month      3 months     12 months
                  open      98(-5)     163(7)       168(6)        182(3)
               reviews     430(-80)   1442(-118)   4602(-196)   22341(-330)
                merged     367(5)     1528(20)     4599(87)     18783(73)
             abandoned      16(-12)    108(-8)      298(6)       1010(-27)
           own commits     316(-27)   1310(55)     3835(62)     15504(116)
        review commits      76(-31)    336(0)      1167(-2)      4629(-5)
        contributor...   1 week      1 month     3 months     12 months
                  open       28(-5)      57(-12)      59(-11)      61(-11)
               reviews     1096(-46)   3944(-22)   10929(182)   38688(332)
                merged       29(-1)     111(-4)      337(9)       891(12)
             abandoned        4(-11)     32(-12)     136(-3)      541(-4)
           own commits       38(7)      149(-8)      442(13)     1100(13)
        review commits        0(0)        0(0)         0(0)         0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 2(2)   cleanup_comments 221(221)
       total 265(265)   assigned 24(24)   open 222(222)
    + top 10 contributors:
          LibreOfficiant made 42 patches in 1 month, and 128 patches in 1 year
          Pranam Lashkari made 28 patches in 1 month, and 64 patches in 1 year
          Steve Fanning made 10 patches in 1 month, and 26 patches in 1 year
          Weblate made 6 patches in 1 month, and 49 patches in 1 year
          Marco A.G.Pinto made 5 patches in 1 month, and 17 patches in 1 year
          Johnny_M made 4 patches in 1 month, and 20 patches in 1 year
          Attila Bakos made 4 patches in 1 month, and 11 patches in 1 year
          Szabolcs Tóth (NISZ) made 3 patches in 1 month, and 22 patches in 1 year
          Balázs regényi made 3 patches in 1 month, and 4 patches in 1 year
          Sophia Schröder made 2 patches in 1 month, and 20 patches in 1 year
    + top 10 reviewers:
          Michael Stahl made 146 review comments in 1 month, and 1510 in 1 year
          Timar, Andras made 140 review comments in 1 month, and 1319 in 1 year
          Behrens, Thorsten made 134 review comments in 1 month, and 1254 in 1 year
          Nabet, Julien made 82 review comments in 1 month, and 2152 in 1 year
          Meeks, Michael made 78 review comments in 1 month, and 906 in 1 year
          Vajna, Miklos made 70 review comments in 1 month, and 1336 in 1 year
          Adolfo Jayme Barrientos made 70 review comments in 1 month, and 1030 in 1 year
          Olivier Hallot made 60 review comments in 1 month, and 374 in 1 year
          Xisco Faulí made 58 review comments in 1 month, and 864 in 1 year
          Holešovský, Jan made 48 review comments in 1 month, and 871 in 1 year
    + Patches automatically abandoned:
        "Insert - Text from File..." ( Sophia Schröder )
            - https://gerrit.libreoffice.org/#/c/88044
        Improve visibility and consistency ( Sophia Schröder )
            - https://gerrit.libreoffice.org/#/c/88056
            + this was just causing work for translators (Olivier)
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Fatih Budak
          scito
          van Oostrum, Piet

* Commit Access
    + None
    + Commit access for GSoC students? (Heiko)
      + let’s do the same as last year (Thorsten)
        + mentors will request access as needed

* Developer Certification (Stephan/Kendy/Thorsten)
    + sleep 19 weeks
    + seeking for a new person as a replacement for Bjoern, who is currently
      inactive

* Jenkins / CI update (Christian)
    from:Tue Apr 28 16:35:27 2020
    master linux rel  jobs:  62 ok:  59 ko:   3 fail ratio:  4.84 % break:   2 broken duration: 
3.62%
    master linux dbg  jobs:  57 ok:  54 ko:   3 fail ratio:  5.26 % break:   3 broken duration: 
0.98%
    master mac rel    jobs:  66 ok:  66 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master mac dbg    jobs:  66 ok:  66 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master win rel    jobs:  83 ok:  83 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master win dbg    jobs:  87 ok:  86 ko:   1 fail ratio:  1.15 % break:   1 broken duration: 
0.31%
    master win64 dbg  jobs:  85 ok:  84 ko:   1 fail ratio:  1.18 % break:   1 broken duration: 
0.35%
    master gerrit lin jobs: 457 ok: 375 ko:  53 fail ratio: 11.60% time for ok: mean:  22 median:  
22
    master gerrit plg jobs: 432 ok: 300 ko:  88 fail ratio: 20.37% time for ok: mean:  30 median:  
28
    master gerrit win jobs: 463 ok: 333 ko:  92 fail ratio: 19.87% time for ok: mean:  50 median:  
50
    master gerrit mac jobs: 451 ok: 373 ko:  40 fail ratio:  8.87% time for ok: mean:  26 median:  
23
    master gerrit all jobs: 426 ok: 239 ko: 134 fail ratio: 31.46% time for ok: mean:  96 median:  
69
+ https://dev-www.libreoffice.org/tmp/gerrit_200507.html
+ tests that failed more than twice in last seven days:
      3 CppunitTest_sw_htmlexport
      3 CppunitTest_sw_uwriter
      4 CppunitTest_sc_statistical_functions_test
      4 CppunitTest_sw_uibase_shells
     10 CppunitTest_sw_odfimport
     12 CppunitTest_vcl_backend_test
     13 CppunitTest_sw_uiwriter
     + no outstanding problems (Cloph)

  + add `make screenshot´ to gerrit_linux_clang_dbgutil? (Stephan)
    + to find occasional breakers early
    + should be reasonably cheap
      + faster than uicheck
    + see
      <https://lists.freedesktop.org/archives/libreoffice/2020-May/085038.html>
      “CI and `make screenshot` (was: [core] make the family and mask explicit
      in SfxStyleSheetBasePool::First)”
    + could add the screenshot target in lode.git (Stephan)
      + have a daily check already (Cloph)
      + no objections (all)
AI:   do the lode.git change + deploy it (Stephan)

* l10n (Sophie)
  + Christian has added checks for Formula, Installer bar, Math symbols names and SQL functions
  + I’ll remove remaining wrong translations listed in #128200 next week

* Graphics architecture (Thorsten)
  * https://pad.documentfoundation.org/p/ESC_graphics_architecture
  * skia / vulkan: to try it on master (Lubos)
    + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
      + 6 (-2) open bugs, 52 total (+1)
    + alpha1 already was built using clang-cl for skia (Cloph)

* Assert pages in sw export tests ( Xisco )
        - https://gerrit.libreoffice.org/c/core/+/93645
      - goal: easily check if page number changes after an export+import
      - making sure that the good behavior is preserved
      - don’t really mind either way (Michael S)
      - see no problems (Miklos)

* QA update (Xisco)

    + BHS for 7.0 alpha1 on Monday 11, 2020
        - https://wiki.documentfoundation.org/QA/BugHuntingSession/7.0.0Apha

    + office-interoperability-tools scripts rewritten in python ( a lot of cleans ups, 
multiprocessing )
        - https://github.com/x1sc0/office-interoperability-tools/commits/master
      - previous run was about 10 days, now only 5

    + Please help flesh out the monthly reports:
          https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 832 (-31)
        + enhancements: 99  (-15)
        + needsUXEval: 8 (-6)
        + haveBackTrace: 1 (+0)
        + needsDevAdvice: 11 (+0)
        + documentation:  22 (+3)
        + android:  5 (+0)
        + iOS:  0 (+0)
        + Online:  14 (-1)


    + Most pressing bugs:
     New:
        + Crash when I press down arrow in edit header dialog using e.g, Japanese keyboard
            + https://bugs.documentfoundation.org/show_bug.cgi?id=129620
            + will try to bisect (Xisco)

     Old:
       + macOS: Can't Save As after installing language pack on Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=132025
           + more info here: “Subject: Budget 2020 proposals and macOS Catalina support / 
onboarding” on the dev list (Heiko)

       + Notarize LibreOffice builds so that it launches without warnings on macOS 10.15 Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126409
           + Cloph?

       + Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
           + https://bugs.documentfoundation.org/show_bug.cgi?id=116079
           + regression from the fastparser gsoc work from 2016
          + Mohammed is no longer around, Julien is asking for tips

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it


    + New high severity bugs of the week:
        + Crash: "vector::_M_fill_insert" with large sumifs
            + https://bugs.documentfoundation.org/show_bug.cgi?id=132431
            + Dennis will take a look

        + Crash when deleting table-row used for diagram generation.
            + https://bugs.documentfoundation.org/show_bug.cgi?id=132714
            + regression, not yet bisected

        + Crash in: BigPtrArray::Index2Block(unsigned __int64) anchor to character
            + https://bugs.documentfoundation.org/show_bug.cgi?id=132724
          + regression, Lubos ?

        + Crash in: BigPtrArray::Index2Block(unsigned __int64) anchor to paragraph
            + https://bugs.documentfoundation.org/show_bug.cgi?id=132725
            + regression, Michael S

        + Crash clicking chart after deleting table
            + https://bugs.documentfoundation.org/show_bug.cgi?id=132731
            + regression, not yet bisected


* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +242  -51 (-206) overall)
      many thanks to the top bug squashers:
       Buovjaga                23
       Heiko Tietze            19
       Julien Nabet            15
       Ming Hua                14
       Timur                   12
       QA Administrators       7
       Caolán McNamara         6
       eisa01                  6
       Telesto                 5
       andreas_k               5

    + top 10 bugs reporters:
       Telesto                 47
       Gerald Pfeifer          7
       NISZ LibreOffice Team   6
       andreas_k               6
       Regina Henschel         4
       Rhys Young              4
       Aron Budea              3
       KrauseM                 3
       Rizal Muttaqin          3
       Timur                   3

    + top 10 bugs fixers:
       Heiko Tietze            7
       McNamara, Caolán        6
       Nabet, Julien           5
       Kainz, Andreas          3
       Németh, László          3
       Rizal Muttaqin          3
       Budea, Áron             2
       Luboš Luňák             2
       Michael Stahl           2
       Ming Hua                2

    + top 10 bugs confirmers:
       Ilmari Lauhakangas      43
       Dieter Praas            24
       Heiko Tietze            19
       eisa01                  19
       Bart                    14
       *UNKNOWN*               12
       Nabet, Julien           11
       Budea, Áron             6
       Timur                   6
       MM                      5


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/52 -     1 %  (+0)
     5.4 : 2/41 -     4 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 1/36 -     2 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 1/133 -    0 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 3/82 -     3 %  (+0)
     old : 6/245 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 728/4195 708/4160 704/4138 699/4119 713/4113 715/4104 719/4091

     done by:
        Ilmari Lauhakangas    13
        barakso.attila         7
        Telesto                4
        Budea, Áron            3
        Weghorn, Michael       1
        Marco Menardi          1
        Xisco Faulí            1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 905/5045 883/5006 877/4982 870/4962 885/4957 892/4954 895/4940

     done by:
        Ilmari Lauhakangas    15
        barakso.attila         7
        Budea, Áron            5
        Telesto                4
        Weghorn, Michael       1
        Marco Menardi          1
        Xisco Faulí            1


* all bugs tagged with 'regression'
   + 1161(+11) bugs open of 9599(+36) total 5(+3) high prio.

     done by:
        Telesto               16
        Ilmari Lauhakangas     7
        Budea, Áron            2
        eisa01                 2
        Roman Kuznetsov        1
        Gerald Pfeifer         1
        Weghorn, Michael       1
        Ming Hua               1
        Marco Menardi          1
        Nabet, Julien          1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Calc          - 2(+1)
     Impress       - 1(+1)
     LibreOffice   - 1(+0)
     Writer        - 1(+1)

   by OS:
     All           - 2(+1)
     Linux         - 1(+1)
     Mac OS X      - 1(+1)
     Windows       - 1(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 332(+8)
     Calc                     - 222(+3)
     Impress                  - 133(+0)
     LibreOffice              - 66(+0)
     Writer: docx filter      - 58(+0)
     Crashes                  - 47(+7)
     Draw                     - 47(+0)
     Borders                  - 41(+1)
     UI                       - 39(-4)
     Writer: perf             - 36(-1)
     Base                     - 32(-3)
     graphics stack           - 29(+0)
     Writer: other filter     - 27(+0)
     Writer: doc filter       - 25(+0)
     Printing and PDF export  - 24(+0)
     Chart                    - 23(+0)
     RTL                      - 22(+0)
     filters and storage      - 22(+0)
     BASIC                    - 16(+0)
     framework                - 2(+0)
     Installation             - 1(+0)
     sdk                      - 1(+0)