ESC meeting minutes: 2020-04-30

* Present:
    + Cloph, Ilmari, Caolan, Stephan, Michael W, Olivier, Miklos, Eike, Xisco, Michael S, Heiko, 
Gabriel, Kendy, Michael M

* Completed Action Items:
    + None

* Pending Action Items:
    + None

* Release Engineering update (Cloph)
    + 7.0 status: alpha next week, feature freeze is last week of May
    + 6.4 status: 6.4.4 rc1 is tagged yesterday
    + 6.3 status: last release is out
    + Remotes
    + Android viewer
      + Android tinderbox has problems, need HW help -> still broken
      + maybe it’ll be moved to TDF infra
    + Online

* Documentation (Olivier)
    + New Help
      + updated icon replacement table (ohallot)
      + Added module brand color to module’s help page (ohallot)
    + Helpcontent2
      + Updates and fixes (ohallot, LibreOfficiant, fitoshido, A. Gelmini)
    + Guides
      + work in progress.

    + Google Season of Doc
      +  How about API documentation?
         + opportunity for external tech writer to address $subject
         + need to format as project
         + scenario: basic or python macro author, too much details, no overview
           + somebody who comes from the VBA world
         + then the project would not be about the specific UNOIDL interfaces (Stephan)
           + rather how to use it from basic/python, it’s a question how to scope such a project
           + it’s not clear if somebody external can author such documentation
         + typical scenario: inspect UNO objects, then go to interface documentation (Olivier)
           + want to help from-VBA migration
         + DevGuide addresses part of that (Stephan)
           + if you want some higher level documentation, not individual interfaces
           + interface vs object is not that separate for basic/python (compared to Java/C++)
         + autodoc was a bit easier (Olivier)
           + think doxygen makes this harder now
         + agrees with Stephan (Michael S)
           + would it be possible to put comments from IDL into RDB and access them via reflection?
           + or have some mechanism, so you can go from an interface name and open online 
documentation (Stephan)
       + do you have any other idea in mind? (Xisco)
         + have to think about it (Olivier)

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        245(245) (topicUI) bugs open, 269(269) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months
             added      18(9)     30(10)     88(11)    172(10)
         commented     136(61)   425(70)   1069(58)   3329(119)
           removed       1(1)      2(0)      36(1)      44(1)
          resolved       8(0)     48(4)     121(3)     314(6)
    + top 10 contributors:
          Heiko Tietze made 276 changes in 1 month, and 1831 changes in 1 year
          Kainz, Andreas made 141 changes in 1 month, and 432 changes in 1 year
          Dieter Praas made 78 changes in 1 month, and 526 changes in 1 year
          Ilmari Lauhakangas made 47 changes in 1 month, and 103 changes in 1 year
          Foote, V Stuart made 46 changes in 1 month, and 551 changes in 1 year
          Telesto made 35 changes in 1 month, and 64 changes in 1 year
          Timur made 27 changes in 1 month, and 202 changes in 1 year
          Rizal Muttaqin made 17 changes in 1 month, and 63 changes in 1 year
          Thomas Lendo made 16 changes in 1 month, and 256 changes in 1 year
          NISZ LibreOffice Team made 15 changes in 1 month, and 34 changes in 1 year

    + New tickets with needsUXEval Apr/23-30

  ->  * UX: Ignore all option in spell check is an unexpected full session
        setting
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132505
        + dev input is much appreciated
      * When in text edit mode, ignore the hit area of other text boxes that
        overlap with the box being edited
        + https://bugs.documentfoundation.org/show_bug.cgi?id=126874
      * Unable to control table formatting in Writer
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132313
      * IMPRESS: drag and drop of an image into a text field results in display
        of file name instead of image
        + https://bugs.documentfoundation.org/show_bug.cgi?id=126860
      * Colibre: Too large size for Impress' Display Views icons
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132399
      * When protecting image content, you cannot add a caption
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132315
      * Track changes submenu is missing
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132168
      * Adopt new application icons for LibreOffice 7.0
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132398
      * Font feature dialog: Reimplement some checkboxes as tri-state
        + https://bugs.documentfoundation.org/show_bug.cgi?id=127423
      * On new installation, why not ask user for his name as it would be used
        in the identification form
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132357
 ->   * EDITING Remove Blinking character property from UI/Editor
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132373
        + deprecate/hide blinking text feature
      => unconfirmed/new, in discussion
        + MS canceled the actual effect in MSO
        + do we want to retire this feature? (Heiko)
          + <blink> is ignored by browsers (Ilmari)
          + helps a11y as well (if removal happens)
          + Regina is against the removal, it’s a working feature
          + it was a feature from ‘97 when Writer wanted to be a html editor (Michael S)
            + could just not blink the text + hide UI
            + still retain the char property
          => OK to remove rendering + UI, but keep the actual data (all)

      * FILEOPEN DOCX: No continuous line at the left side
        + https://bugs.documentfoundation.org/show_bug.cgi?id=104346
      * Handle line attributes like area fill when merging shapes
        + https://bugs.documentfoundation.org/show_bug.cgi?id=127753
      * "Find and replace" finds/replaces text deleted with "record/track
        changes"
        + https://bugs.documentfoundation.org/show_bug.cgi?id=36582
      * Image rotation broken when caption is added (portrait vs. landscape)
        + https://bugs.documentfoundation.org/show_bug.cgi?id=132314
      => bug/enhancement, accepted

      * Opentype features window is longer than screen size and it is difficult
        to reach ok/cancel buttons
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128176
      => easyhack

* Crash Testing (Caolan)
    + 16(-1) import failure, 7(-1) export failures
    + 1 coverity issues
    + 9 ossfuzz issues
    + crashtesting script is now improved: we now also re-import our own output (Xisco)

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.3.5.2
        + (+57) 1828 1771 1474 1755 1845 1565 1167 961 635 312 0
    + https://crashreport.libreoffice.org/stats/version/6.4.1.2
        + (-35) 2195 2230 1961 2884 4166 5344 5609 3687 2052 0
    + https://crashreport.libreoffice.org/stats/version/6.4.2.2
        + (-1104) 5765 6869 6527 8046 6988 3716 0
    + https://crashreport.libreoffice.org/stats/version/6.4.3.2
        + (+2129) 4328 2199 0
    + non-resolved dll names are depending on the Windows version used for reporting, possibly 
(Xisco)
      + hard to see the trend till this is unresolved

* GSoC 2020 (Ilmari)
    + Proposal selection will be submitted to Google today, everything is ready
    + April 30 - May 4: Google Program Admins will do another review of student eligibility
    + May 4: Accepted GSoC 2020 students/projects are announced
    + June 1, 2020 - July 3, 2020: Students work on their projects

* Mentoring/easyhack update
    + reviewing patches from first contributors is much appreciated (Muhammet)
    + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers

          committer...   1 week     1 month      3 months     12 months
                  open      88(-9)     137(-21)     142(-22)      158(-24)
               reviews     450(-56)   1486(-136)   4716(-344)   22559(-330)
                merged     377(13)    1528(37)     4538(35)     18726(-8)
             abandoned      26(-3)     119(5)       295(9)       1014(-12)
           own commits     355(42)    1285(101)    3799(30)     15422(64)
        review commits     119(49)     348(23)     1182(-26)     4646(33)
        contributor...   1 week     1 month     3 months     12 months
                  open       27(-8)     64(-10)      65(-11)      68(-10)
               reviews     1128(48)   3958(76)    10751(-18)   38372(142)
                merged       36(11)    119(15)      332(-41)     885(22)
             abandoned       11(4)      44(6)       139(-7)      544(8)
           own commits       37(6)     158(4)       434(-37)    1091(12)
        review commits        0(0)       0(0)         0(0)         0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 2(2)   cleanup_comments 219(219)
       total 263(263)   assigned 22(22)   open 222(222)
    + top 10 contributors:
          LibreOfficiant made 36 patches in 1 month, and 118 patches in 1 year
          Pranam Lashkari made 24 patches in 1 month, and 59 patches in 1 year
          Johnny_M made 16 patches in 1 month, and 22 patches in 1 year
          Steve Fanning made 14 patches in 1 month, and 26 patches in 1 year
          Weblate made 8 patches in 1 month, and 49 patches in 1 year
          Szabolcs Tóth (NISZ) made 5 patches in 1 month, and 22 patches in 1 year
          Attila Bakos made 4 patches in 1 month, and 11 patches in 1 year
          Gökay ŞATIR made 4 patches in 1 month, and 6 patches in 1 year
          Balázs regényi made 4 patches in 1 month, and 4 patches in 1 year
          Marco A.G.Pinto made 3 patches in 1 month, and 17 patches in 1 year
    + top 10 reviewers:
          Michael Stahl made 144 review comments in 1 month, and 1502 in 1 year
          Timar, Andras made 142 review comments in 1 month, and 1317 in 1 year
          Behrens, Thorsten made 122 review comments in 1 month, and 1248 in 1 year
          Nabet, Julien made 80 review comments in 1 month, and 2194 in 1 year
          Meeks, Michael made 76 review comments in 1 month, and 910 in 1 year
          Adolfo Jayme Barrientos made 76 review comments in 1 month, and 1032 in 1 year
          Vajna, Miklos made 72 review comments in 1 month, and 1330 in 1 year
          Xisco Faulí made 62 review comments in 1 month, and 872 in 1 year
          Németh, László made 58 review comments in 1 month, and 519 in 1 year
          Weghorn, Michael made 56 review comments in 1 month, and 356 in 1 year
    + Patches automatically abandoned:
        tdf#112620 Make sdi accel, menu, and toolbox config settings functional ( Jim Raykowski )
            - https://gerrit.libreoffice.org/#/c/65990
        tdf#107038 Poco::DateTime replacement with std::chrono ( Shivansh )
            - https://gerrit.libreoffice.org/#/c/84090
        Uppercase typo ( Sophia Schröder )
            - https://gerrit.libreoffice.org/#/c/88023
        Whitespace issue ( Sophia Schröder )
            - https://gerrit.libreoffice.org/#/c/88024
        Improve visiblity and consistency ( Sophia Schröder )
            - https://gerrit.libreoffice.org/#/c/88031
        Visibility and cleanups ( Sophia Schröder )
            - https://gerrit.libreoffice.org/#/c/88057
        tdf#124443 Below methods removed ( Advait Ranade )
            - https://gerrit.libreoffice.org/#/c/88345
        Refactor bookmark export stuff in ww8 ( Björn Michaelsen )
            - https://gerrit.libreoffice.org/#/c/89109
        Move DeleteOutlineSelections to SwContentTree::EditEntry ( Jim Raykowski )
            - https://gerrit.libreoffice.org/#/c/89289
        Reformatting of source files. ( Sophia Schröder )
            - https://gerrit.libreoffice.org/#/c/89567
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          scito

* Commit Access
    + proposal: Pranam Lashkari (Kendy)
      + 50+ commits in online.git, also a few commits in core.git
      + also needed to cherry-pick somebody else’s work
      + has proved to be responsible
    => no objections
AI:      + send the new-committer mail (Kendy)
AI:      + toggle the button (Cloph)

* Developer Certification (Stephan/Kendy/Thorsten)
    + sleep 20 weeks
    + seeking for a new person as a replacement for Bjoern, who is currently
      inactive

* Jenkins / CI update (Christian)
    from:Thu Apr 23 13:56:49 2020
    master linux rel  jobs:  67 ok:  63 ko:   4 fail ratio:  5.97 % break:   3 broken duration: 
3.74%
    master linux dbg  jobs:  61 ok:  57 ko:   3 fail ratio:  4.92 % break:   3 broken duration: 
2.55%
    master mac rel    jobs:  81 ok:  81 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master mac dbg    jobs:  83 ok:  83 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master win rel    jobs: 111 ok: 111 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master win dbg    jobs: 114 ok: 114 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master win64 dbg  jobs: 109 ok: 109 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master gerrit lin jobs: 559 ok: 439 ko:  83 fail ratio: 14.85% time for ok: mean:  23 median:  
23
    master gerrit plg jobs: 515 ok: 359 ko:  83 fail ratio: 16.12% time for ok: mean:  33 median:  
29
    master gerrit win jobs: 570 ok: 401 ko: 122 fail ratio: 21.40% time for ok: mean:  51 median:  
51
    master gerrit mac jobs: 551 ok: 458 ko:  50 fail ratio:  9.07% time for ok: mean:  26 median:  
21
    master gerrit all jobs: 526 ok: 313 ko: 128 fail ratio: 24.33% time for ok: mean:  98 median:  
74
  + https://dev-www.libreoffice.org/tmp/gerrit_200430.html
  + tests that failed more than twice in last seven days
      3 CppunitTest_sc_subsequent_export_test
      3 CppunitTest_smoketest
      3 CppunitTest_sw_mailmerge
      4 CppunitTest_sc_mathematical_functions_test
      4 CppunitTest_sw_ww8export
      5 CppunitTest_sw_uiwriter
      5 CppunitTest_sw_uwriter
  + for some time, all macOS bots were offline, now fixed
  + callgrind job now fails for 2 weeks (Stephan)
    + think it was a perl → python conversion (Cloph)
    + possibly something (Stephan)
    + nominally Norbert and Markus are the owners
AI:    + hope to fix it at some stage (Cloph)

* l10n (Sophie)
  + work as usual
  + Calc formula names how have a test for the translations (tdf#128200)
    + weblate now provides feedback
    + did you see the regex I posted to the bug? (Eike)
      + not yet (Cloph)
      + if there is no translation, then the English one is used
      + that might lead to duplicated function names (Eike)
        + would be good to check with the provided documents

* Graphics architecture (Thorsten)
  * https://pad.documentfoundation.org/p/ESC_graphics_architecture
  * skia / vulkan: to try it on master (Lubos)
    + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
      + 8 (+2) open bugs, 51 total (+8)

* Require clang-cl from VS2019 on Windows (Miklos, Lubos)
  + proposed change: https://gerrit.libreoffice.org/c/core/+/93194
  + dev ML discussion: https://lists.freedesktop.org/archives/libreoffice/2020-April/084929.html
  + benefit would be much improved skia/raster rendering performance
  + cost is one more checkbox to tick when installing VS2019
  + next step would be to update the build bots, so the change can go in
AI:  + will install clang-cl on the Windows bots (Cloph)

* Use TDF nextcloud/Online instance for ESC too (easier access for non-regular attendees) (Thorsten)
  + Now the agenda is at 
<https://nextcloud.documentfoundation.org/apps/files/?dir=/Shared/Common/ESC-minutes>
  + How does it compare to the old instance? (Miklos)
    + 10 seconds to save a document, Guilhem will look at it
    + autocorrect won’t turn URLs into hyperlinks (Heiko)
      + fixed on master (Michael M)

* QA update (Xisco)

    + Please help flesh out the monthly reports:
          https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 858 (-29)
        + enhancements: 112  (-14)
        + needsUXEval: 15 (+10)
        + haveBackTrace: 1 (+0)
        + needsDevAdvice: 11 (+0)
        + documentation:  19 (+0)
        + android:  5 (+1)
        + iOS:  0 (+0)
        + Online:  16 (+2)
        + Ilmari now helps out with unconfirmed bugs, closed lots of them

    + Most pressing bugs:
     New:
        None

     Old:
       + macOS: Can't Save As after installing language pack on Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=132025
           + more info here: “Subject: Budget 2020 proposals and macOS Catalina support / 
onboarding” on the dev list (Heiko)

       + Notarize LibreOffice builds so that it launches without warnings on macOS 10.15 Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126409
           + Cloph?

       + Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
           + https://bugs.documentfoundation.org/show_bug.cgi?id=116079
           + regression from the fastparser gsoc work from 2016
          + Mohammed is no longer around, Julien is asking for tips

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it
    + New high severity bugs of the week:
        + "Find and replace" finds/replaces text deleted with "record/track changes"
            + https://bugs.documentfoundation.org/show_bug.cgi?id=36582
            + not a regression


* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +203  -5 (-236) overall)
      many thanks to the top bug squashers:
       Buovjaga                58
       QA Administrators       21
       Justin L                15
       Heiko Tietze            11
       V Stuart Foote          8
       Julien Nabet            7
       Dieter                  6
       Caolán McNamara         5
       Luboš Luňák             5
       Mike Kaganski           5

    + top 10 bugs reporters:
       Telesto                 37
       NISZ LibreOffice Team   12
       Regina Henschel         4
       sergio.callegari        4
       Aron Budea              3
       Gerald Pfeifer          3
       Mike Kaganski           3
       Rhys Young              3
       Jim Raykowski           2
       Midon                   2

    + top 10 bugs fixers:
       McNamara, Caolán        5
       Nabet, Julien           5
       Luboš Luňák             4
       Rizal Muttaqin          4
       Justin Luth             3
       Tünde Tóth              3
       Xisco Faulí             3
       *UNKNOWN*               2
       Balazs Varga            2
       Grandin, Noel           2

    + top 10 bugs confirmers:
       Ilmari Lauhakangas      41
       Dieter Praas            17
       Nabet, Julien           11
       Budea, Áron             10
       m.a.riosv               7
       Heiko Tietze            6
       *UNKNOWN*               5
       Foote, V Stuart         5
       Olivier Hallot          5
       Roman Kuznetsov         4


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/52 -     1 %  (+0)
     5.4 : 2/41 -     4 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 1/36 -     2 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 1/133 -    0 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 3/82 -     3 %  (+0)
     old : 6/245 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        barakso.attila          6
        Budea, Áron             4
        Ilmari Lauhakangas      3
        Raal                    2
        NISZ LibreOffice Team   1
        Telesto                 1
        Xisco Faulí             1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        barakso.attila          6
        Budea, Áron             5
        Ilmari Lauhakangas      3
        Raal                    2
        NISZ LibreOffice Team   1
        Brinzing, Oliver        1
        Telesto                 1
        Xisco Faulí             1


* all bugs tagged with 'regression'
   + 1148(-1) bugs open of 9566(+22) total 2(-1) high prio.

     done by:
        Budea, Áron            5
        Telesto                5
        Dieter Praas           2
        Ilmari Lauhakangas     2
        Heiko Tietze           1
        Brinzing, Oliver       1
        Henschel, Regina       1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Calc          - 1(+0)
     LibreOffice   - 1(+0)
     Writer        - 0(-1)

   by OS:
     All           - 1(-1)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)
     Windows       - 1(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 324(+6)
     Calc                     - 220(+3)
     Impress                  - 132(-1)
     LibreOffice              - 66(-1)
     Writer: docx filter      - 58(-1)
     Draw                     - 47(+0)
     UI                       - 41(-3)
     Borders                  - 40(+1)
     Crashes                  - 40(-3)
     Writer: perf             - 37(+0)
     Base                     - 35(+0)
     graphics stack           - 29(+0)
     Writer: other filter     - 27(+0)
     Writer: doc filter       - 25(-3)
     Printing and PDF export  - 24(+1)
     Chart                    - 23(+0)
     RTL                      - 22(+0)
     filters and storage      - 22(+0)
     BASIC                    - 16(-1)
     framework                - 2(+0)
     Installation             - 1(+0)
     sdk                      - 1(+0)