macOS support; agenda item ESC

Verified with LO 6.4.3 downloaded form libreoffice.org which should be built with SDK 10.15 and 
hack. Concerning dark mode behaviour is the same as built with SDK 10.13. Color changes by the OS 
do not take place. Prior to switching to SDK 10.13 or using hack there were some color changes 
required for dark mode (see tdf#131286 for an example).

On 27. Apr 2020, at 12:58, Thorsten Wagner <thorsten.wagner.4@gmail.com> wrote:

When building LO without hack and SDK 10.15 UI coloring changes after switching to dark mode (e.g. 
toolbar and sidebar shading, highlight color).  As there is no specific implementation of LO's 
native colors for dark mode currently, this looks very incomplete. Color changes done by macOS 
disapper when building with SDK 10.13. For now this is reasonable as of missing specific 
implementation - better no dark mode than very incomplete dark mode. As I am building with SDK 
10.13 for the time being, I can do a retest with SDK 10.15 and hack occasionally - only to be 
really sure that behaviour of building with SDK 10.13 has no difference from building with SDK 
10.15 and hack for this case.

On 27. Apr 2020, at 12:05, Stephan Bergmann <sbergman@redhat.com> wrote:

On 27/04/2020 11:50, Thorsten Wagner wrote:
> Exactly - system behaves as is was built with SDK 10.13. Blurry text is avoided, but other 
> features, e.g. dark mode, are not accessible too. For now this is well as dark mode 
> implementation has not been done currently. To move forward issue needs to be resolved without 
> hack.

Are you sure that the stripped LC_VERSION_MIN_MACOSX 10.15 load command would negatively impact 
dark mode if dark mode were actually implemented (at all or correctly---I have no idea about the 
status there) in LO, or is that speculation on your part?

What are other features besides the "e.g. dark mode" that are negatively affected by the stripped 
LC_VERSION_MIN_MACOSX 10.15 load command?

> On 27. Apr 2020, at 09:11, Stephan Bergmann <sbergman@redhat.com> wrote:
> On 25/04/2020 12:12, Thorsten Wagner wrote:
> > (1) It is still not possible to use macOS SDK 10.15 due to blurry text on retina displays. 
> > Current workaround is using SDK 10.13. SDK 10.15 is a prerequisite to support current features 
> > like dark mode, which is not implemented today.
> Can you clarify what exactly you mean with "not possible to use macOS SDK 10.15" in the light of 
> <https://git.libreoffice.org/core/+/645fe53be0dc36535dba0ed684e21ca4cda80d70%5E!/> "tdf#122218: 
> Hack to avoid blurry text with macOS SDK 10.15"?  My understanding is that that commit does allow 
> to build with SDK 10.15 and at the same time avoid blurry text.  But, as it strips a 
> LC_VERSION_MIN_MACOSX 10.15 load command from the soffice executable, it might negatively affect 
> other macOS 10.15 features, is that what you mean?