ESC meeting minutes: 2020-03-19

* Present:
    + Stephan, Ilmari, Heiko, Caolan, Michael W, Gabriel, Cloph, Olivier, Miklos, Xisco, Eike, 
Thorsten, Kendy

* Completed Action Items:
   + Update Jenkins slaves for the new default make target (Cloph)

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)
     [ expect progress next week ]

* Release Engineering update (Cloph)
   + 7.0 status: feature freeze is last week of May
   + 6.4 status: 6.4.3 rc1 will be tagged by Xisco next week
   + 6.3 status: 6.3.6 in April
   + Remotes
   + Android viewer
   + Online

* Documentation (Olivier)
   + New Help
      + Change in CSS (fitoshido)
   + Helpcontent2
      + several updates (LibreOfficiant, buovjaga, S. Chaiklin, ohallot)
   + Guides
      + All guides under work by doc team.

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       238(238) (topicUI) bugs open, 260(260) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month   3 months   12 months
            added     11(-31)    56(1)     83(3)      155(2)
        commented     84(-5)    372(10)   959(-14)   2976(-33)
          removed      1(-29)    33(1)     34(-2)      44(-1)
         resolved     16(5)      56(7)    111(6)      283(8)
   + top 10 contributors:
         Heiko Tietze made 328 changes in 1 month, and 1563 changes in 1 year
         Xisco Faulí made 197 changes in 1 month, and 596 changes in 1 year
         Kainz, Andreas made 48 changes in 1 month, and 328 changes in 1 year
         Dieter Praas made 46 changes in 1 month, and 446 changes in 1 year
         Roman Kuznetsov made 41 changes in 1 month, and 354 changes in 1 year
         Foote, V Stuart made 36 changes in 1 month, and 533 changes in 1 year
         Timur made 27 changes in 1 month, and 156 changes in 1 year
         Ilmari Lauhakangas made 23 changes in 1 month, and 52 changes in 1 y
         Rizal Muttaqin made 21 changes in 1 month, and 44 changes in 1 year
         Justin Luth made 20 changes in 1 month, and 32 changes in 1 year

    + New tickets with needsUXEval Mar/12-19

       * Musical notes as a gallery
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131418
       * Unify terms in dialog to search text
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131369
       => unconfirmed / in discussion

       * Hyperlnks in Calc cannot created over more than one cell. (like in ms
         excel via cells selection)
         + https://bugs.documentfoundation.org/show_bug.cgi?id=130946
       => needinfo

       * COSTUMIZE DIALOG: Feature Request for key sequence mapping
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131316
       * "Load styles" should not import content
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131347
       * Line styles (under "text box and shape") do not allow for multiple
         parallel lines
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131322
       => dup, nab

       * Sifr: Missing Large (128px) for The Start Center's Recent File
         + https://bugs.documentfoundation.org/show_bug.cgi?id=130898
       * Positioning of comments in documents with two and more text columns is
         confusing
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131383
       * Toolbar arrows too large on 200% scaling
         + https://bugs.documentfoundation.org/show_bug.cgi?id=130991
       * Right end of toolbar background is white despite using preinstalled
         theme
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131023
       * WRITER: Numbering should be separate for table columns and inserting a
         new row shouldn't increase number in vertically merged cell where rows
         don't change
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131126
       * gallery: update Symbol gallery
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131319
       * gallery: add Widget gallery
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131318
       * Gallery: update Computer gallery
         + https://bugs.documentfoundation.org/show_bug.cgi?id=131308
       => new

       * Overwriting Writer styles does not overwrite changes to Marginalia
         paragraph style
         + https://bugs.documentfoundation.org/show_bug.cgi?id=130719
       => new / easyhack

   ->  * Rename UNO command
         + https://gerrit.libreoffice.org/c/core/+/90324
         + "Show Whitespace" instead of "Hide Whitespace"
         + also rename the UNO command and internal vars such as
           FN_VIEW_HIDE_WHITESPACE

       + Word UI shows “hide whitespace”, FWIW (Miklos)
       + How far should we go? (Heiko)
         + Why renaming is needed? (Eike)
           + Menu probably has a hardcoded idea when a comment is “on” (Kendy)
       + It’s not so long in the code, you could go ahead (Thorsten)
         + Ash added it ~4 years ago (Kendy)
       + conclusion: just don’t show the old command in the menu, add the new one in the menu 
config (Thorsten, Miklos)
         + Heiko appreciates comments on the patch

    -> * tdf#102011 RES_POOLFRM_GRAPHIC: add 3.2mm spacing by default
         + https://gerrit.libreoffice.org/c/core/+/90495
         + accept the potential regression?

      + problem: currently the default and load-from-doc value is the same
         + can try to push patch author that way (Heiko)

* Crash Testing (Caolan)
   + 1(+0) import failure, 2(+0) export failures
     + have the HW now in the datacenter, expect progress here soon (Cloph)
   + 0 coverity issues
   + 10 oss-fuzz issues, 1 crash, 1 leak, 8 timeouts

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.3.4.2
        + (-265) 2211 2476 3050 2829 2188 3301 3769 3222 2057 984 0
    + https://crashreport.libreoffice.org/stats/version/6.3.5.2
        + (+206) 1167 961 635 312 0
    + https://crashreport.libreoffice.org/stats/version/6.4.0.3
        + (+59) 7488 7429 8772 9464 6774 4842 419 0
    + https://crashreport.libreoffice.org/stats/version/6.4.1.2
        + (+1922) 5609 3687 2052 0
    + https://crashreport.libreoffice.org/stats/version/6.4.2.2
        + (-) 0

   + 6.4 crash count is quite high (Xisco)
     + no clear reason identified so far

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
         + if you have the time, please do mentoring!
       + Student Application Period March 16 - 31, 2020
       + Application Review Period March 31, 2020 - April 27, 2020
   + students contacting potential mentors already, as usual
   + all the mentors have been invited (Ilmari)
   + 6 proposals submitted (draft or final)

* mentoring/easyhack update
   + reviewing patches from first contributors is much appreciated (Muhammet)
   + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers

         committer...   1 week      1 month      3 months     12 months
                 open      84(-16)     150(-7)      157(-4)       174(-3)
              reviews     460(-128)   1954(-282)   5743(-350)   23389(-252)
               merged     314(-1)     1528(-103)   4299(-67)    18399(16)
            abandoned      13(-3)      100(-20)     274(-9)      1007(4)
          own commits     271(-4)     1271(-71)    3701(-22)    15191(31)
       review commits      84(10)      391(-37)    1250(-43)     4587(37)
       contributor...   1 week      1 month      3 months      12 months
                 open      33(-7)       85(-6)        89(-5)        91(-5)
              reviews     924(-188)   4104(-302)   10314(-185)   37232(138)
               merged      24(3)       126(-10)      396(-7)       924(12)
            abandoned      13(-18)      71(7)        130(9)        532(10)
          own commits      37(9)       155(-3)       443(4)       1090(22)
       review commits       0(0)         0(0)          0(0)          0(0)
   + easyHack statistics:
      needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 208(208)
      total 255(255)   assigned 21(21)   open 217(217)
   + top 10 contributors:
         Ilmari Lauhakangas made 11 patches in 1 month, and 40 patches in 1 year
         Sophia Schröder made 10 patches in 1 month, and 18 patches in 1 year
         Pranam Lashkari made 10 patches in 1 month, and 34 patches in 1 year
         Balazs Varga made 9 patches in 1 month, and 65 patches in 1 year
         Weblate made 9 patches in 1 month, and 36 patches in 1 year
         LibreOfficiant made 7 patches in 1 month, and 89 patches in 1 year
         Pelin, Rabia Kuran made 6 patches in 1 month, and 12 patches in 1 year
         Tünde Tóth made 5 patches in 1 month, and 48 patches in 1 year
         Shivam Kumar Singh made 5 patches in 1 month, and 8 patches in 1 year
         Marco A.G.Pinto made 4 patches in 1 month, and 15 patches in 1 year
   + top 10 reviewers:
         Behrens, Thorsten made 162 review comments in 1 month, and 1370 in 1 year
         Michael Stahl made 156 review comments in 1 month, and 1518 in 1 year
         Meeks, Michael made 134 review comments in 1 month, and 922 in 1 year
         Adolfo Jayme Barrientos made 122 review comments in 1 month, and 1014 in 1 year
         Nabet, Julien made 114 review comments in 1 month, and 2404 in 1 year
         Kaganski, Mike made 106 review comments in 1 month, and 876 in 1 year
         Timar, Andras made 106 review comments in 1 month, and 1233 in 1 year
         Grandin, Noel made 102 review comments in 1 month, and 1143 in 1 year
         Vajna, Miklos made 100 review comments in 1 month, and 1444 in 1 year
         Xisco Faulí made 84 review comments in 1 month, and 916 in 1 year
   + Patches automatically abandoned:
       EMF investigation ( Bartosz Kosiorek )
           - https://gerrit.libreoffice.org/#/c/68180
       commit-msg ( shubham goyal )
           - https://gerrit.libreoffice.org/#/c/68813
       tdf#92619 Paragraph's list styles will have link with List's styles ( Roman Kuznetsov )
           - https://gerrit.libreoffice.org/#/c/70379
       vcl: add unit tests for AnimationRenderers ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/76274
       Removed "if" statement ( Andrea Gelmini )
           - https://gerrit.libreoffice.org/#/c/77647
       just a test change. ( shubham goyal )
           - https://gerrit.libreoffice.org/#/c/78874
       test: Insert QR code in Impress, Draw ( shubham goyal )
           - https://gerrit.libreoffice.org/#/c/78897
       LibO Basic Collection object ( LibreOfficiant )
           - https://gerrit.libreoffice.org/#/c/83938
       tdf#129366 Basic Resume statement TestCases ( LibreOfficiant )
           - https://gerrit.libreoffice.org/#/c/85099
       tdf#12999 Basic 'Resume statement' new help ( LibreOfficiant )
           - https://gerrit.libreoffice.org/#/c/85100
       Is Basic keyword/operator ( LibreOfficiant )
           - https://gerrit.libreoffice.org/#/c/85665
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Rutuja Kendre
         Yukio Siraichi
         TJ Holt

Commit Access
   + Balázs Varga (NISZ) (Stephan)
   + Tünde Tóth (NISZ)
AI: give the actual permission (Cloph)

* Developer Certification (Stephan/Kendy/Thorsten)
   + sleep -14 weeks
   + seeking for a new person as a replacement for Bjoern, who is currently inactive

   + have 2 candidates
   + no objections (All)

* Jenkins / CI update (Christian)
   from:Thu Mar 12 14:52:12 2020
   master linux rel  jobs:  78 ok:  76 ko:   2 fail ratio:  2.56 % break:   1 broken duration: 5.66%
   master linux dbg  jobs:  77 ok:  64 ko:  12 fail ratio: 15.58 % break:   2 broken duration:19.14%
   master mac rel    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master win rel    jobs: 102 ok:  96 ko:   6 fail ratio:  5.88 % break:   5 broken duration: 7.61%
   master win dbg    jobs: 100 ok:  96 ko:   4 fail ratio:  4.00 % break:   3 broken duration: 6.83%
   master win64 dbg  jobs:  99 ok:  92 ko:   7 fail ratio:  7.07 % break:   5 broken duration:12.85%
   master gerrit lin jobs: 384 ok: 307 ko:  52 fail ratio: 13.54% time for ok: mean:  19 median:  18
   master gerrit plg jobs: 378 ok: 223 ko:  91 fail ratio: 24.07% time for ok: mean:  27 median:  25
   master gerrit win jobs: 387 ok: 293 ko:  47 fail ratio: 12.14% time for ok: mean:  43 median:  41
   master gerrit mac jobs: 387 ok: 297 ko:  43 fail ratio: 11.11% time for ok: mean:  31 median:  31
   master gerrit all jobs: 371 ok: 197 ko:  98 fail ratio: 26.42% time for ok: mean:  52 median:  46
  + https://dev-www.libreoffice.org/tmp/gerrit_200319.html
  + tests that failed more than twice in last seven days:
     3 CppunitTest_sal_osl
     3 CppunitTest_sd_filters_test
     3 CppunitTest_sw_odfexport
     3 CppunitTest_vcl_pdfexport
     3 UITest_impress_tests
     3 UITest_writer_demo5
     4 CppunitTest_svl_urihelper
     4 CppunitTest_sw_uiwriter

 + fewer builds than usual this week (Cloph)
   + faster completion time due to this

* l10n (Sophie)
 + work as usual

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia / vulkan: to try it on master (Lubos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
     + 2 open bugs (20 total)
   + fixed tdf#131287 Skia: slow page scaling in Writer (and with some delays)
   + fixed tdf#130233 Skia: quality of font rendering to canvas is degraded

* docx/xlsx competitive marketing issues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 6 open bugs (0)
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs (0)

 + no change since last week
 + poke Marketing? (Thorsten)
   + just 2 fixed docx bugs (Miklos)
   + ~20 pptx bugs were fixed in the first post (Ilmari)

* QA update (Xisco)
   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 709 (+15)
       + enhancements: 96  (+7)
       + needsUXEval: 9 (+2)
       + haveBackTrace: 1 (+0)
       + needsDevAdvice: 11 (+0)
       + documentation:  26 (+7)
       + android:  7 (+1)
       + iOS:  0 (+0)
       + Online:  13 (-2)


   + Most pressing bugs:
   New:
        [None]

   Old:
       + Notarize LibreOffice builds so that it launches without warnings on macOS 10.15 Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126409
           + Cloph?

       + Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
           + https://bugs.documentfoundation.org/show_bug.cgi?id=116079
           + regression from the fastparser gsoc work from 2016
          + Mohammed is no longer around, Julien is asking for tips

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone


   + New high severity bugs of the week:
       + Highlight, cut & paste from a bullet list to same list changes indent of pasted line 
(moving line)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=77651
           + not a regression, inherited from OOo
           + Heiko is annoyed by this

* QA stats

   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +125  +34 (-114) overall)
     many thanks to the top bug squashers:
      QA Administrators       21
      Timur                   11
      Heiko Tietze            7
      Julien Nabet            6
      Xisco Faulí             6
      Justin L                5
      László Németh           5
      Michael Weghorn         4
      Yukio Siraichi          4
      Eike Rathke             3

   + top 10 bugs reporters:
      Mike Kaganski           7
      Steve Fanning           5
      NISZ LibreOffice Team   4
      andreas_k               4
      b.                      4
      John                    3
      Jim Raykowski           2
      Michael Weghorn         2
      R. Green                2
      Regina Henschel         2

   + top 10 bugs fixers:
      Nabet, Julien           4
      Németh, László          4
      Yukio Siraichi          4
      Justin Luth             3
      Rathke, Eike            3
      Xisco Faulí             3
      Andras Timar            2
      Heiko Tietze            2
      Le Grand, Armin         2
      McNamara, Caolán        2

   + top 10 bugs confirmers:
      Xisco Faulí             28
      Dieter Praas            19
      Nabet, Julien           14
      Heiko Tietze            11
      Timur                   5
      Roman Kuznetsov         3
      *UNKNOWN*               2
      Olivier Hallot          2
      Abby Kuma               1
      Budea, Áron             1


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 2/41 -     4 %  (+0)
    5.3 : 0/54 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 6/245 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  + 710/4070 708/4049 705/4029 707/4002 702/3978 708/3954 705/3930

    done by:
       Xisco Faulí             9
       Timur                   8
       Budea, Áron             2
       NISZ LibreOffice Team   1
       Weghorn, Michael        1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  + 885/4918 885/4897 882/4876 886/4850 881/4824 884/4796 878/4772

    done by:
       Timur                   8
       Xisco Faulí             8
       Budea, Áron             2
       NISZ LibreOffice Team   1
       Weghorn, Michael        1


* all bugs tagged with 'regression'
  + 1126(-7) bugs open of 9440(+20) total 1(+0) high prio.

    done by:
       Xisco Faulí            7
       Timur                  3
       Budea, Áron            2
       Roman Kuznetsov        1
       Cor Nouws              1
       steve -_-              1
       Weghorn, Michael       1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    Calc          - 1(+0)

  by OS:
    All           - 1(+0)
    Linux         - 0(+0)
    Mac OS X      - 0(+0)
    Windows       - 0(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 307(-2)
    Calc                     - 214(-4)
    Impress                  - 132(-1)
    LibreOffice              - 67(+1)
    Writer: docx filter      - 66(-3)
    Draw                     - 46(-2)
    UI                       - 40(+0)
    Borders                  - 38(+0)
    Writer: perf             - 35(+1)
    Base                     - 34(+0)
    Crashes                  - 33(+0)
    Writer: doc filter       - 31(+0)
    Writer: other filter     - 28(-1)
    graphics stack           - 28(+0)
    RTL                      - 23(+0)
    filters and storage      - 23(+0)
    Printing and PDF export  - 21(+0)
    Chart                    - 20(+0)
    BASIC                    - 17(+0)
    framework                - 2(+0)
    Extensions               - 1(+0)
    Installation             - 1(+0)
    sdk                      - 1(+0)