ESC meeting minutes: 2020-03-12

* Present:
    + Olivier, Caolan, Justin, Gabriel, Michael W, Heiko, Sophie, Ilmari,
      Miklos, Xisco, Cloph, Kendy

* Completed Action Items:

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)

* Release Engineering update (Cloph)
   + 7.0 status: feature freeze is last week of May
   + 6.4 status: 6.4.2 rc2 was tagged this week
   + 6.3 status: 6.3.6 in April
   + Remotes
   + Android viewer
   + Online

* Documentation (Olivier)
   + New Help (No news)
   + Helpcontent2
       + Updates and fixes (S. Chaiklin, LibreOfficiant, buovjaga, Fitoshido)
   + Guides
       + Progress in all books, closing gap to LO 6.4
       + Extension website will have Literaure to download
          vm135.documentfoundation.org

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       238(238) (topicUI) bugs open, 262(262) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week   1 month    3 months   12 months
            added     42(36)    55(32)     80(33)     153(35)
        commented     89(10)   362(-17)   973(-21)   3009(76)
          removed     30(29)    32(29)     36(28)      45(27)
         resolved     11(0)     49(1)     105(2)      275(6)
   + top 10 contributors:
         Heiko Tietze made 260 changes in 1 month, and 1501 changes in 1 year
         Xisco Faulí made 183 changes in 1 month, and 600 changes in 1 year
         Foote, V Stuart made 61 changes in 1 month, and 534 changes in 1 year
         Roman Kuznetsov made 45 changes in 1 month, and 353 changes in 1 year
         Dieter Praas made 38 changes in 1 month, and 425 changes in 1 year
         Kainz, Andreas made 37 changes in 1 month, and 316 changes in 1 year
         Timur made 23 changes in 1 month, and 155 changes in 1 year
         Rizal Muttaqin made 22 changes in 1 month, and 45 changes in 1 year
         Justin Luth made 15 changes in 1 month, and 27 changes in 1 year
         Seth Chaiklin made 15 changes in 1 month, and 168 changes in 1 year

   + New tickets with needsUXEval Mar/05-12

     * print dialog sidebar width change when window size change
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131272
     * Update Bullet and Numbering Image presets
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131224
     => assigned

     * Insert comment shortcut doesn't let me edit existing comment
       + https://bugs.documentfoundation.org/show_bug.cgi?id=95854
     => fixed

     * FORMATTING Pasting text changes paragraph format in older LO document
       + https://bugs.documentfoundation.org/show_bug.cgi?id=105550
     * add visio like shapes to LibO gallery
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131226
     => DUP, WF

     * improve UX around info message "Missing hyphenation info – please
       install the hyphenation package for locale "de"
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131233
  -> * Change .uno: command for Protect Cells in Writer from .uno:Protect
       to .uno:CellProtection
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130783
       + good to keep the old name working, in-doc macros and extensions can refer to the old name 
(Miklos)

     * Replace Hard-Coded Tips of The Day's Bulb by Themeable Icon
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131177
     => in discussion, unconfirmed

     * Remove More Fields sub menu and move its content to the parent
       form/dialog main menu
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131239
     * new menu item: DOCUMENT, or a new sub-menu item FILES / Outline
       (enhancement, development)
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131182
     * request for a more intuitive behavior when search in document has zero
       results ("search key not found") -- and at displaying matches
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131142
     => needinfo

     * Gallery: add SmartArt gallery theme
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131245
     * Add the possibility to name "text" elements in the master document
       Navigator
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131227
     * Function wizard not correctly using the Add-In category
       + https://bugs.documentfoundation.org/show_bug.cgi?id=131169
     => new/decided

* Crash Testing (Caolan)
   + 1(+0) import failure, 2(+0) export failures
     + still the mini-run, due to failing HW
   + 0 coverity issues
   + 9 oss-fuzz issues

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.3.4.2
        + (-574) 2476 3050 2829 2188 3301 3769 3222 2057 984 0
    + https://crashreport.libreoffice.org/stats/version/6.3.5.2
        + (+326) 961 635 312 0
    + https://crashreport.libreoffice.org/stats/version/6.4.0.3
        + (-1343) 7429 8772 9464 6774 4842 419 0
    + https://crashreport.libreoffice.org/stats/version/6.4.1.2
        + (+1635) 3687 2052 0

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
         + if you have the time, please do mentoring!
       + Student Application Period March 16 - 31, 2020
       + Application Review Period March 31, 2020 - April 27, 2020
   + students contacting potential mentors already, as usual

* mentoring/easyhack update
   + reviewing patches from first contributors is much appreciated (Muhammet)
   + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers
         committer...   1 week     1 month      3 months     12 months
                 open     100(25)     157(26)      161(25)       177(25)
              reviews     588(-92)   2236(-280)   6093(-238)   23641(-30)
               merged     315(-60)   1631(-98)    4366(-180)   18383(-34)
            abandoned      16(-7)     120(1)       283(-11)     1003(-4)
          own commits     275(-4)    1342(-92)    3723(-98)    15160(-91)
       review commits      74(-29)    428(-62)    1293(-36)     4550(-1)
       contributor...   1 week      1 month      3 months      12 months
                 open       40(-17)     91(-20)       94(-21)       96(-21)
              reviews     1112(-72)   4406(-113)   10499(-286)   37094(82)
               merged       21(-14)    136(-3)       403(5)        912(6)
            abandoned       31(15)      64(28)       121(30)       522(28)
          own commits       28(-14)    158(-5)       439(10)      1068(5)
       review commits        0(0)        0(0)          0(0)          0(0)
   + easyHack statistics:
      needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 207(207)
      total 257(257)   assigned 20(20)   open 221(221)
   + top 10 contributors:
         Weblate made 12 patches in 1 month, and 33 patches in 1 year
         Balazs Varga made 9 patches in 1 month, and 66 patches in 1 year
         Ilmari Lauhakangas made 7 patches in 1 month, and 40 patches in 1 year
         LibreOfficiant made 7 patches in 1 month, and 87 patches in 1 year
         Pranam Lashkari made 7 patches in 1 month, and 29 patches in 1 year
         Pelin, Rabia Kuran made 7 patches in 1 month, and 12 patches in 1 year
         Sophia Schröder made 6 patches in 1 month, and 12 patches in 1 year
         Marco A.G.Pinto made 6 patches in 1 month, and 15 patches in 1 year
         Tünde Tóth made 6 patches in 1 month, and 48 patches in 1 year
         PhD. Ayhan YALÇINSOY made 5 patches in 1 month, and 12 patches in 1 year
   + top 10 reviewers:
         Behrens, Thorsten made 194 review comments in 1 month, and 1406 in 1 year
         Michael Stahl made 186 review comments in 1 month, and 1528 in 1 year
         Adolfo Jayme Barrientos made 146 review comments in 1 month, and 1030 in 1 year
         Meeks, Michael made 130 review comments in 1 month, and 900 in 1 year
         Nabet, Julien made 128 review comments in 1 month, and 2414 in 1 year
         Timar, Andras made 114 review comments in 1 month, and 1255 in 1 year
         Kaganski, Mike made 112 review comments in 1 month, and 870 in 1 year
         Grandin, Noel made 112 review comments in 1 month, and 1151 in 1 year
         Xisco Faulí made 104 review comments in 1 month, and 922 in 1 year
         Holešovský, Jan made 100 review comments in 1 month, and 1015 in 1 year
   + Patches automatically abandoned:
       tdf#50916 Increase maximum number of columns from 1024 to 16384 ( Bartosz Kosiorek )
           - https://gerrit.libreoffice.org/#/c/76193
       Fix typos ( Andrea Gelmini )
           - https://gerrit.libreoffice.org/#/c/77203
       tdf#97361: Changed getCount to len ( Mayank Suman )
           - https://gerrit.libreoffice.org/#/c/80112
       drawinglayer: improve EMFPPath::Read() ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/84843
       tdf#129308 drawinglayer: not reading EmfPlusPath records correctly ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/84844
       tdf#129342 drawinglayer: extract EMFPPlusDrawImage() function ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85143
       tdf#129342 drawinglayer: extract EMFPBrush::GetTextureTransformation() function ( Chris 
Sherlock )
           - https://gerrit.libreoffice.org/#/c/85144
       drawinglayer: move EMF+ enums, constants and helpers to enum helper files ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85231
       tdf#129342 drawinglayer: improve logging in EMFPImage::Read() ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85232
       tdf#129342 drawinglayer: read in uncompressed bitmap ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85233
       tdf#129342: drawinglayer: fill polygon with texture brush ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85239
       drawinglayer: improve EMF+ logging ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85548
       drawinglayer: convert object type defines to ObjectType enum ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85666
       drawinglayer: extract ObjectContinues() ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85667
       drawinglayer: EmfPlusImage's first field is a graphics version ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85668
       tdf#101639 drawinglayer: better logging for unimplemented EMF+ hatch styles ( Chris Sherlock 
)
           - https://gerrit.libreoffice.org/#/c/85669
       wip: weld StylesPropertyPanel ( Caolán McNamara )
           - https://gerrit.libreoffice.org/#/c/85720
       tdf#101639 drawinglayer: partially implement fill with hatching ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85796
       drawinglayer: initialize EMFPImage struct with constructor ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85845
       tdf#129342 vcl: migrate DIBV5Header functions ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/85904
       tdf#96505:Get rid of cargo cult long integer literals ( Batuhan, Görkem Benzer )
           - https://gerrit.libreoffice.org/#/c/85942
       tdf#75280 - Convert inappropriate use of sal_uIntPtr to better integer types ( Gökay ŞATIR )
           - https://gerrit.libreoffice.org/#/c/86072
       tdf#124176: Use pragma once instead of include guards ( Elzem Atay )
           - https://gerrit.libreoffice.org/#/c/86220
       tdf#124176: Use pragma once instead of include guards ( aleyna  doğrucan )
           - https://gerrit.libreoffice.org/#/c/86231
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Andrew Lee (Collabora)
         Fred Kruse

Commit Access
   + None

* Developer Certification (Stephan/Kendy/Thorsten)
   + sleep -13 weeks
   + seeking for a new person as a replacement for Bjoern, who is currently inactive

* Jenkins / CI update (Christian)
   from:Thu Mar  5 12:03:52 2020
   master linux rel  jobs:  77 ok:  77 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master linux dbg  jobs:  72 ok:  69 ko:   2 fail ratio:  2.78 % break:   2 broken duration: 0.46%
   master mac rel    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master win rel    jobs: 111 ok:  98 ko:  13 fail ratio: 11.71 % break:  11 broken duration:11.70%
   master win dbg    jobs: 113 ok: 105 ko:   8 fail ratio:  7.08 % break:   7 broken duration: 3.88%
   master win64 dbg  jobs: 114 ok: 105 ko:   9 fail ratio:  7.89 % break:   8 broken duration: 8.35%
   master gerrit lin jobs: 489 ok: 382 ko:  82 fail ratio: 16.77% time for ok: mean:  19 median:  19
   master gerrit plg jobs: 462 ok: 288 ko: 137 fail ratio: 29.65% time for ok: mean:  27 median:  25
   master gerrit win jobs: 502 ok: 395 ko:  80 fail ratio: 15.94% time for ok: mean:  46 median:  44
   master gerrit mac jobs: 494 ok: 385 ko:  64 fail ratio: 12.96% time for ok: mean:  27 median:  24
   master gerrit all jobs: 477 ok: 260 ko: 162 fail ratio: 33.96% time for ok: mean:  99 median:  63
  + tests that failed more than twice in last seven days:
     3 CppunitTest_sal_osl
     3 CppunitTest_sd_filters_test
     3 CppunitTest_sw_odfexport
     3 CppunitTest_vcl_pdfexport
     3 UITest_impress_tests
     3 UITest_writer_demo5
     4 CppunitTest_svl_urihelper
     4 CppunitTest_sw_uiwriter

   + nothing unusual

* l10n (Sophie)
 + working on user documentation, almost finished
 + work as usual

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia / vulkan: to try it on master (Miklos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
     + 4 open bugs (20 total)
   + Lubos is working on better text rendering (on top of harfbuzz)

* docx/xlsx competitive marketing issues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 6 open bugs (-1)
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs (0)

* Changing the default ‘make’ target (Lubos)
 + https://gerrit.libreoffice.org/c/core/+/89820
 + waiting for LODE changes to be deployed on Jenkins slaves
 + will update macOS/Windows slaves later today or tomorrow (Cloph)

* Superscript in editeng (Kendy)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=89849
   + fixed with 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ba09d436dfd1f0b07b95aad3d375e7cd7318440b 
by Justin
   + Fixes a regression that was in the codebase since 4.1
       + people might have manually tweaked the superscript in the documents
   + More info:
       + https://wiki.documentfoundation.org/ReleaseNotes/7.0#Impress_.26_Draw
   + Proposal: Just release note this, not introduce a check for this in the
     import filters & try to tweak this etc.
   + does this improve / not improve MSO interop? (Miklos)
     + may improve things (Kendy)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=80194 affected/related?
     + Justin looked at both bugs (Kendy)

=> sounds like a good proposal (all)

* QA update (Xisco)

   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 694 (+32)
       + enhancements: 89  (+8)
       + needsUXEval: 7 (+5)
       + haveBackTrace: 1 (+0)
       + needsDevAdvice: 11 (-1)
       + documentation:  19 (+3)
       + android:  6 (-1)
       + iOS:  0 (+0)
       + Online:  15 (+3)

   + Most pressing bugs:
   New:
       + Notarize LibreOffice builds so that it launches without warnings on macOS 10.15 Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126409
           + Cloph?

    Old:
       + Opening ODS file rise Incorrect Format exception. Opened well with OpenOffice 4.1.3
           + https://bugs.documentfoundation.org/show_bug.cgi?id=116079
           + regression from the fastparser gsoc work from 2016
          + Mohammed is no longer around, Julien is asking for tips

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone
  Fixed:
       + FILEOPEN: Some labels in charts are not displayed by default
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117088
           + Thanks to Balazs Varga


   + New high severity bugs of the week:
       + Crash on double click to paragraph style
           + https://bugs.documentfoundation.org/show_bug.cgi?id=131208
           + Already fixed, thanks to Jim
       + Paste special sometimes not available (like for web content) -
           + https://bugs.documentfoundation.org/show_bug.cgi?id=65606
           + not a regression
       + Insert comment shortcut doesn't let me edit existing comment
           + https://bugs.documentfoundation.org/show_bug.cgi?id=95854
           + Already fixed. Thanks to Maxim Monastirsky

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +159  +9 (-144) overall)
     many thanks to the top bug squashers:
      QA Administrators       12
      Timur                   11
      Xisco Faulí             9
      Michael Weghorn         8
      V Stuart Foote          7
      Julien Nabet            6
      Caolán McNamara         5
      Noel Grandin            5
      Heiko Tietze            4
      Jan-Marek Glogowski     4

   + top 10 bugs reporters:
      Xisco Faulí             13
      Regina Henschel         7
      Julien Nabet            4
      Mike Kaganski           3
      Rizal Muttaqin          3
      Samuel Mehrbrodt (CIB)  3
      Timur                   3
      andreas_k               3
      Gerald Pfeifer          2
      Justin L                2

   + top 10 bugs fixers:
                              5
      Grandin, Noel           5
      McNamara, Caolán        5
      Nabet, Julien           5
      Adolfo Jayme Barrientos 3
      Balazs Varga            3
      Glogowski, Jan-Marek    3
      Gülşah Köse             3
      Henschel, Regina        3
      Ahmad Ganzouri          2

   + top 10 bugs confirmers:
      Xisco Faulí             20
      Dieter Praas            13
      Nabet, Julien           8
      *UNKNOWN*               6
      Brinzing, Oliver        6
      Weghorn, Michael        6
      m.a.riosv               5
      Heiko Tietze            4
      Oliver Grimm            4
      Roman Kuznetsov         4


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 2/41 -     4 %  (+0)
    5.3 : 0/54 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 6/245 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  + 708/4049 705/4029 707/4002 702/3978 708/3954 705/3930 695/3907

    done by:
       Xisco Faulí           15
       Budea, Áron            2
       Timur                  1
       Justin Luth            1
       Brinzing, Oliver       1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  + 885/4897 882/4876 886/4850 881/4824 884/4796 878/4772 870/4750

    done by:
       Xisco Faulí           15
       Budea, Áron            2
       Timur                  2
       Justin Luth            1
       Brinzing, Oliver       1


* all bugs tagged with 'regression'
  + 1133(-1) bugs open of 9420(+22) total 1(+0) high prio.

    done by:
       Xisco Faulí           15
       Brinzing, Oliver       2
       Cor Nouws              1
       Timur                  1
       Justin Luth            1
       Nabet, Julien          1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    Calc          - 1(+0)

  by OS:
    All           - 1(+0)
    Linux         - 0(+0)
    Mac OS X      - 0(+0)
    Windows       - 0(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 309(-5)
    Calc                     - 218(-2)
    Impress                  - 133(+1)
    Writer: docx filter      - 69(+3)
    LibreOffice              - 66(+2)
    Draw                     - 48(+3)
    UI                       - 40(+0)
    Borders                  - 38(+0)
    Base                     - 34(-1)
    Writer: perf             - 34(-1)
    Crashes                  - 33(-1)
    Writer: doc filter       - 31(+0)
    Writer: other filter     - 29(+0)
    graphics stack           - 28(-1)
    RTL                      - 23(+0)
    filters and storage      - 23(+0)
    Printing and PDF export  - 21(+0)
    Chart                    - 20(+2)
    BASIC                    - 17(+0)
    framework                - 2(+0)
    Extensions               - 1(+0)
    Installation             - 1(+0)
    sdk                      - 1(+0)