Re: Changing default make target (=>buildbot maintainers)

On Tuesday 03 of March 2020, Miklos Vajna wrote:
> On Tue, Mar 03, 2020 at 11:24:17AM +0100, Luboš Luňák 
<l.lunak@collabora.com> wrote:
> >  so at https://ci.libreoffice.org/job/gerrit_master/51044/ is a change
> > that makes plain 'make' just build and that's it. Unless somebody speaks
> > up, I'll submit it on Monday.
>
> I agree that the current "run some tests, but not all" default is not
> great, so your <https://gerrit.libreoffice.org/c/core/+/89820> change
> looks like an improvement. :-)

 Oops, wrong URL. Thanks.

> >  Buildbot maintainers, if your build uses plain 'make' and you still want
> > to keep running the tests, please update to use targets that are invoked
> > now by the default target (what it is exactly is non-trivial, because it
> > depends, but if I'm reading the Makefile correctly, 'make unitcheck'
> > should generally be it).
>
> Please don't forget about "slowchecks", which are currently part of
> "make", but not part of "make unitcheck". Would buildbot owners then run
> "make unitcheck slowcheck"? I'm not sure.

 Yes, sorry, I read it incorrectly, it's indeed "make unitcheck slowcheck" if 
called from the toplevel. Well, I said the thing was a confusing mess (uh, I 
mean, I said it was non-trivial it-depends).

-- 
 Luboš Luňák
 l.lunak@collabora.com