ESC meeting minutes: 2020-02-27

* Present:
    + Cloph, Michael W, Heiko, Lubos, Caolan, Stephan, Xisco, Ilmari, Jan-Marek, Eike, Michael S, 
Olivier, Sophie, Miklos

* Completed Action Items:
   + Automated reminder email to the dev list for this meeting (Xisco)
     + not done, but now Miklos does it
   + Require xcode 11 on core.git master (Stephan)
   + get back to Julien wrt firebird experimental mode (Xisco)

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)
     + still waiting

* Release Engineering update (Cloph)
   + 7.0 status: feature freeze is last week of May
   + 6.4 status: 6.4.1 final announced today
      + 6.4.2 rc1 tagging later today
      + still working on the SDK signing
   + 6.3 status: 6.3.6 in April
   + Remotes
   + Android viewer: core.git java viewer is currently broken on master
     + both arch64 and x86 (crash on doc load, will investigate)
   + Online

* Documentation (Olivier)
   + New Help
      + Fix in xapian search (ohallot)
      + Some CSS/HTML refactors (removing old cruft)
   + Helpcontent2
      + Several updates by S. Chaiklin, M. Sameh, LibreOfficiant, Stephan)
   + Guides
      + progress in Draw, Base, Impress guides to 6.4 release.

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       240(240) (topicUI) bugs open, 261(261) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month   3 months   12 months
            added      10(9)     25(2)      50(4)     120(9)
        commented     119(65)   393(29)   1034(78)   2908(154)
          removed       0(-1)     2(0)       8(0)      18(0)
         resolved      21(15)    45(7)     106(14)    267(17)
   + top 10 contributors:
         Heiko Tietze made 257 changes in 1 month, and 1439 changes in 1 year
         Dieter Praas made 78 changes in 1 month, and 430 changes in 1 year
         Foote, V Stuart made 74 changes in 1 month, and 521 changes in 1 year
         Seth Chaiklin made 68 changes in 1 month, and 168 changes in 1 year
         Roman Kuznetsov made 60 changes in 1 month, and 343 changes in 1 year
         Xisco Faulí made 52 changes in 1 month, and 463 changes in 1 year
         锁琨珑 made 30 changes in 1 month, and 34 changes in 1 year
         Kainz, Andreas made 25 changes in 1 month, and 283 changes in 1 year
         Timur made 16 changes in 1 month, and 143 changes in 1 year
         Muhammet Kara made 14 changes in 1 month, and 45 changes in 1 year

   + New tickets with needsUXEval Feb/20-27

     * New table style via Sidebar-Styles-Table Styles not in
       Table-Insert Table-Styles
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130953
     * Enabling Autotext to work on single characters
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130916
     * Ability to remove one specific direct formatting
       + https://bugs.documentfoundationy.org/show_bug.cgi?id=130930
     * Tabbed interface: Add subscript in Calc Home Tab
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130909
     * Area Fill update presets
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130928
     * Add "View graphic after save" to graphic export window
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130894
     * UI Create a better UX for "Tracking Changes" mode
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130840
     * Add GUI option to rotate text in table as icons in table toolbar
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130807
     => unconfirmed, in discussion

     * AUTO-REDACT: enhance GUI and term
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130862
     => assigned

     * TABLES text in cells behaves wrong when rotated
       + https://bugs.documentfoundation.org/show_bug.cgi?id=34436
     * Hex color in Formular Editor
       + https://bugs.documentfoundation.org/show_bug.cgi?id=130779
     * SCROLLING: Optimal View Zoom Moves Left-Right
       + https://bugs.documentfoundation.org/show_bug.cgi?id=127801
     => duplicate, rejected, NAB

* Crash Testing (Caolan)
   + 1(+0) import failure, 2(+0) export failures
     + still a reduced set because of HW reasons
     + waiting feedback from the sponsoring offer (Cloph)
       + hopefully they will reply in a few days
   + 1 coverity issue
   + 11 oss-fuzz issues (1 serious)

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.3.3.2
        + (+223) 1653 1430 2359 2830 3068 2555 3302 4368 3674 3312 2629 1820 854 0
    + https://crashreport.libreoffice.org/stats/version/6.3.4.2
        + (+641) 2829 2188 3301 3769 3222 2057 984 0
    + https://crashreport.libreoffice.org/stats/version/6.3.5.2
        + (+312) 312 0
    + https://crashreport.libreoffice.org/stats/version/6.4.0.3
        + (+2690) 9464 6774 4842 419 0
    + https://crashreport.libreoffice.org/stats/version/6.4.1.2
        + (+0) 0

   + nothing too unusual

* Update baseline to VS2019 on master before 7.0 (Cloph)
   + Noel lists benefits on the list:
     + ASan support, faster linking, better C++ conforming
   + Did somebody tried the Asan support? (Michael S)
     + no idea yet (Stephan)
   + what patch level? (Stephan)
     + check what’s the current patch level, require that? (Miklos)

=> no objections (all)

AI: do the actual gerrit change (Stephan)
AI: please install current VS2019 on build bots / Jenkins (Cloph, Thorsten)

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
         + if you have the time, please do mentoring!
       + Student Application Period March 16 - 31, 2020
       + Application Review Period March 31, 2020 - April 27, 2020
   + students contacting potential mentors already, as usual

* GSoC 2020: offer meson build system transition as an idea? (Jan-Marek)
   + I’m interested in mentoring this.
       - anybody else interested as a 2nd mentor?
   + there is private/jmux/meson, based on https://github.com/jpakkane/core
       - just my playground for a day to get a feeling for meson
           - had some minor problems because of missing cmake error logging
             (got help in #mesonbuild and from jpakkane)
           - separate target for install / instdir
           - didn’t yet check alias target for gbuild module emulation
           - not sure, if partial builds work, ignoring depends?!
               - add a function to include/ header
               - just build some modules, not all dependencies
               - maybe just a use case I’m used to rely on for VCL changes
       - added instdir as install target and VCL qt5 + kf5 builds
       - currently builds ~80 of ~200 LO libraries
         (includes offapi and officecfg generation)
       - contains a few pre-generated headers like sfx slots
         (~ 95k of 120k lines overall change are pre-generated headers)
       - needs externals as system libraries
         (I used an Ubuntu focal schroot; can share setup, if wanted)
       - always builds out-of-tree
       - working with it “feels” a lot like high-level gbuild
   + I won’t add it to ideas, if ESC doesn’t think it’s worth a slot
   + want to evaluate other build systems instead? Not my GSoC idea.

   + question: do we want to offer a slot for the meson topic?
     + need a mentor → Jan-Marek could do that
     + need a secondary mentor
     + make it explicit that this is a test on a feature branch (Stephan)
       + a feasibility study
       + since there is no consensus that we want to switch
     + issue: student does the project → we need to maintain it (Stephan)
     + we have people around who understand gbuild, e.g. Michael S, Lubos (Lubos)
     + the risk is: the student builds a lot of custom stuff on top of meson (Ilmari)
     + a dozen import filters are built using autotools on Windows with gcc-wrapper (Michael S)

=> with the above limits, no objections (all)

* mentoring/easyhack update
   + reviewing patches from first contributors is much appreciated (Muhammet)
+      + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers

         committer...   1 week     1 month     3 months     12 months
                 open       73(21)    133(38)      140(34)      154(37)
              reviews      612(58)   2556(-14)    6313(-95)   23751(104)
               merged      404(19)   1639(60)     4612(-171)  18395(133)
            abandoned       40(8)     112(19)      304(19)      998(26)
          own commits      324(-20)  1415(-3)     3848(-151)  15243(53)
       review commits       99(-5)    510(20)     1285(4)      4514(5)
       contributor...   1 week     1 month     3 months     12 months
                 open       30(-2)    107(-4)      112(0)       114(0)
              reviews     1146(88)   4309(224)   10800(-90)   36718(416)
               merged       40(11)    170(4)       380(27)      882(20)
            abandoned       10(4)      42(6)        81(6)       483(8)
          own commits       42(13)    185(3)       404(27)     1031(15)
       review commits        0(0)       0(0)         0(0)         0(0)
   + easyHack statistics:
      needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 208(208)
      total 254(254)   assigned 18(18)   open 221(221)
   + top 10 contributors:
         Weblate made 13 patches in 1 month, and 31 patches in 1 year
         Pranam Lashkari made 11 patches in 1 month, and 25 patches in 1 year
         Sophia Schröder made 8 patches in 1 month, and 8 patches in 1 year
         Onur Yılmaz made 8 patches in 1 month, and 19 patches in 1 year
         Pelin, Rabia Kuran made 8 patches in 1 month, and 9 patches in 1 year
         Balazs Varga made 7 patches in 1 month, and 60 patches in 1 year
         LibreOfficiant made 7 patches in 1 month, and 93 patches in 1 year
         Tünde Tóth made 5 patches in 1 month, and 44 patches in 1 year
         Yusuf Keten made 5 patches in 1 month, and 15 patches in 1 year
         PhD. Ayhan YALÇINSOY made 5 patches in 1 month, and 10 patches in 1 year
   + top 10 reviewers:
         Michael Stahl made 200 review comments in 1 month, and 1526 in 1 year
         Behrens, Thorsten made 194 review comments in 1 month, and 1426 in 1 year
         Nabet, Julien made 188 review comments in 1 month, and 2416 in 1 year
         Adolfo Jayme Barrientos made 162 review comments in 1 month, and 1000 in 1 year
         Meeks, Michael made 145 review comments in 1 month, and 876 in 1 year
         Holešovský, Jan made 142 review comments in 1 month, and 999 in 1 year
         Muhammet Kara made 132 review comments in 1 month, and 356 in 1 year
         Bergmann, Stephan made 120 review comments in 1 month, and 1037 in 1 year
         Kaganski, Mike made 116 review comments in 1 month, and 846 in 1 year
         Vajna, Miklos made 116 review comments in 1 month, and 1476 in 1 year
   + Patches automatically abandoned:
       tdf#124424 tdf#55058 EMF+ Add transparency support for LinearGradient Brush ( Bartosz 
Kosiorek )
           - https://gerrit.libreoffice.org/#/c/66932
       tdf#42112 Add transparency support for Custom Line Cap ( Bartosz Kosiorek )
           - https://gerrit.libreoffice.org/#/c/83439
       vcl: split metaact.hxx into seperate includes ( Chris Sherlock )
           - https://gerrit.libreoffice.org/#/c/83953
       tdf#127815 Revert "tdf#124118 Qt5 post non-code keys via ExtTextInput" ( Jan-Marek Glogowski 
)
           - https://gerrit.libreoffice.org/#/c/84821
       tdf#124176: Use pragma once instead of include guards ( Alakbar Alikperov )
           - https://gerrit.libreoffice.org/#/c/85467
       tdf#124176: Use pragma once instead of include guards ( Alakbar Alikperov )
           - https://gerrit.libreoffice.org/#/c/85469
       tdf#124176: Use pragma once instead of include guards-3rd-try ( Alakbar Alikperov )
           - https://gerrit.libreoffice.org/#/c/85480
=> Muhammet would be nice to take a look
       Drop checking for user extensions w/ the same ID on every synchronization ( Katarina Behrens 
)
           - https://gerrit.libreoffice.org/#/c/85609
       => merged
       convert SvXMLNumFmtElementContext to FastParser API ( Noel Grandin )
           - https://gerrit.libreoffice.org/#/c/85649
       Add uno command .uno:DockAllToolbars to dock all toolbars ( Jim Raykowski )
           - https://gerrit.libreoffice.org/#/c/85727
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Adam Majer (SUSE)
         Marco Marinello
         NienTsu Wu (OSSII)
         Jussi Pakkanen (meson)

Commit Access
   +  None

* Developer Certification (Stephan/Kendy/Thorsten)
   + sleep -11 weeks
   + seeking for a new person as a replacement for Bjoern, who is currently inactive

* Jenkins / CI update (Christian)
   from:Thu Feb 20 14:27:17 2020
   master linux rel  jobs:  88 ok:  86 ko:   1 fail ratio:  1.14 % break:   1 broken duration: 0.32%
   master linux dbg  jobs:  85 ok:  81 ko:   3 fail ratio:  3.53 % break:   3 broken duration: 5.19%
   master mac rel    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master win rel    jobs: 109 ok:  85 ko:  24 fail ratio: 22.02 % break:   7 broken duration:18.02%
   master win dbg    jobs: 119 ok:  99 ko:  19 fail ratio: 15.97 % break:   3 broken duration:12.84%
   master win64 dbg  jobs: 116 ok:  94 ko:  21 fail ratio: 18.10 % break:   6 broken duration:13.94%
   master gerrit lin jobs: 505 ok: 430 ko:  46 fail ratio:  9.11% time for ok: mean:  19 median:  19
   master gerrit plg jobs: 438 ok: 305 ko:  92 fail ratio: 21.00% time for ok: mean:  28 median:  26
   master gerrit win jobs: 515 ok: 402 ko:  73 fail ratio: 14.17% time for ok: mean:  57 median:  52
   master gerrit mac jobs: 511 ok: 408 ko:  57 fail ratio: 11.15% time for ok: mean:  30 median:  28
   master gerrit all jobs: 446 ok: 267 ko: 117 fail ratio: 26.23% time for ok: mean: 129 median:  80
  + https://dev-www.libreoffice.org/tmp/gerrit_200227.html
  + tests that failed more than twice in last seven days:
     3 CppunitTest_sw_odfexport
     3 CppunitTest_sw_ooxmlexport7
     5 CppunitTest_writerperfect_impress

  + nothing unusual

* l10n (Sophie)
 + working on user documentation

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia / vulkan: to try it, export SAL_ENABLESKIA=1 on master (Miklos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
     + 18 bugs total (2 open)
   + opengl transitions now work in Impress, even when skia/vulkan is active (Lubos)
   + Lubos proposes to turn it on by default on Windows on master:
     + https://gerrit.libreoffice.org/c/core/+/89549
     + benefits:
       + opengl is going away, vulkan replaces it → stay relevant
       + allows later removal of lots of own opengl code, use skia’s vulkan code instead
       + later would allow phasing out GDI, allowing the removal of application-level double 
buffering (skia has a raster renderer)
       + GL was the default only on Windows, propose to do the same with Vulkan as well

     + questions:
       + Vulkan on Linux works better than GL on Linux (Ilmari)
       + works fine for me, obviously (Lubos)
       + flipping the default now is better than 1 w before the branch-off (Miklos)
       + GL on windows was bad due to bad drivers (Ilmari)
       + Vulkan drivers should be simpler then OpenGL – less bugs (Jan-Marek)
       + unit tests usually use the headless code, even on Windows (Lubos)
         + not bad on Windows, but on Linux, make check does not pass if you don’t stick to headless
         + ran make check with Skia test-enabled → everything passes except for Windows clipboard 
code lockup on exit
       + Linux has most of the test coverage (Michael S)
         + it’s a general problem (Jan-Marek)

=> no loud objections (all)
AI: push the change flipping the default (Lubos)

* docx/xlsx competitive marketing issues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs (0)
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs (0)
 + no change since last week

* QA update (Xisco)
   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 640 (+31)
       + enhancements: 73  (+2)
       + needsUXEval: 4 (+2)
       + haveBackTrace: 1 (+0)
       + needsDevAdvice: 11 (+0)
       + documentation:  12 (+0)
       + android:  8 (+0)
       + iOS:  0 (+0)
       + Online:  10 (-1)


   + Most pressing bugs:
    New:
       + there was one, but Noel already fixed it, thanks!

    Old:
       + FILEOPEN: Some labels in charts are not displayed by default
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117088
           + Tamas Buth will take a look

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

    Fixed:
        + LibreOffice crashes when opening files with non-existing hyperlinks
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130959
           + Thanks to Noel


   + New high severity bugs of the week:
       1. File dialogs in Mac OS are in German
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130809
           + regression, needs bisecting

       2. edit / track changes / compare documents does not work
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130960
           + Fixed by Noel

       3. Report does not show label-fields when run in 7.0
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130878
           + Noel working on it

       4. FILEOPEN: DOCX: picture does not display doc saved by MSWord
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130951
           + Armin working on it

       5. FILESAVE DOCX Signature line export creates invalid document
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130917
           + Samuel ?

       6. Images right-click save in wrong format as PNG in all modules
           + https://bugs.documentfoundation.org/show_bug.cgi?id=60684
           + Tomaz?

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +175  -19 (-166) overall)
     many thanks to the top bug squashers:
      Heiko Tietze            20
      Xisco Faulí             13
      Jan-Marek Glogowski     9
      Timur                   7
      Caolán McNamara         6
      Eike Rathke             6
      Michael Stahl (CIB)     6
      V Stuart Foote          6
      Dieter                  5
      Rizal Muttaqin          5

   + top 10 bugs reporters:
      Rizal Muttaqin          9
      Xisco Faulí             9
      stdedos                 8
      NISZ LibreOffice Team   5
      Jan-Marek Glogowski     4
      Kevin Suo               3
      Mike Kaganski           3
      Roman Kuznetsov         3
      Timur                   3
      Aron Budea              2

   + top 10 bugs fixers:
      Glogowski, Jan-Marek    6
      McNamara, Caolán        6
      Heiko Tietze            5
      Michael Stahl           5
      Rizal Muttaqin          5
      Németh, László          3
      Rathke, Eike            3
      Xisco Faulí             3
      Balazs Varga            2
      Bergmann, Stephan       2

   + top 10 bugs confirmers:
      Xisco Faulí             31
      Heiko Tietze            17
      Nabet, Julien           13
      Dieter Praas            9
      Brinzing, Oliver        6
      *UNKNOWN*               4
      Budea, Áron             4
      Glogowski, Jan-Marek    4
      Raal                    4
      Weghorn, Michael        3


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 1/40 -     2 %  (+0)
    5.3 : 0/54 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 5/244 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  + 707/4002 702/3978 708/3954 705/3930 695/3907 694/3890 698/3876

    done by:
       Xisco Faulí            16
       Timur                   2
       Weghorn, Michael        2
       Justin Luth             1
       NISZ LibreOffice Team   1
       Raal                    1
       锁琨珑                     1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  + 886/4850 881/4824 884/4796 878/4772 870/4750 868/4733 870/4715

    done by:
       Xisco Faulí            17
       Timur                   2
       Weghorn, Michael        2
       Drew Jensen             1
       Justin Luth             1
       NISZ LibreOffice Team   1
       Raal                    1
       锁琨珑                     1


* all bugs tagged with 'regression'
  + 1142(+5) bugs open of 9372(+29) total 1(-1) high prio.

    done by:
       Xisco Faulí            18
       Roman Kuznetsov         2
       Robert Großkopf         2
       Budea, Áron             1
       eisa01                  1
       hansk                   1
       Alex Thurgood           1
       Justin Luth             1
       NISZ LibreOffice Team   1
       Weghorn, Michael        1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    Calc          - 1(+0)
    UI            - 0(-1)

  by OS:
    All           - 1(+0)
    Linux         - 0(+0)
    Mac OS X      - 0(-1)
    Windows       - 0(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 319(+3)
    Calc                     - 221(+1)
    Impress                  - 131(-1)
    Writer: docx filter      - 68(+1)
    LibreOffice              - 64(-1)
    Draw                     - 46(+0)
    UI                       - 42(+1)
    Borders                  - 38(+0)
    Base                     - 35(+1)
    Writer: perf             - 35(+1)
    Crashes                  - 32(-5)
    Writer: doc filter       - 30(+0)
    Writer: other filter     - 29(-1)
    graphics stack           - 28(+1)
    RTL                      - 23(+0)
    filters and storage      - 22(+0)
    Printing and PDF export  - 21(+0)
    BASIC                    - 18(+1)
    Chart                    - 17(+0)
    framework                - 2(+0)
    Extensions               - 1(+0)
    Installation             - 1(+0)
    sdk                      - 1(+0)