ESC meeting minutes: 2020-02-20

* Present:
    + Michael W, Ilmari, Cloph, Michael S, Sophie, Heiko, Thorsten, Xisco, Stephan, Miklos, 
Gabriel, Eike, Kendy, Michael M

* Completed Action Items:
   + None

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)
     + still waiting
   + Automated reminder email to the dev list for this meeting (Xisco)

* Release Engineering update (Cloph)
   + 7.0 release plan added to the wiki
     + feature freeze is last week of May
   + 6.4 status
     + 6.4.1 rc2 will be tagged later today
     + please review patches! 
https://gerrit.libreoffice.org/q/project:core+branch:libreoffice-6-4-1+status:open
     + 6.4.2 would be built with xcode11 on macOS (Mojave/10.14)
   + 6.3 status
     + 6.3.5 final is now announced
     + 6.3.<next> in April
   + Remotes
   + Android viewer: core.git java viewer is currently broken on master
     + both arch64 and x86 (crash on doc load, will investigate)
   + Online

* Documentation (Olivier)
   + absent (sick)

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       241(241) (topicUI) bugs open, 263(263) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week   1 month   3 months   12 months
            added      7(-6)    30(-9)     53(-8)    121(-6)
        commented     96(17)   443(49)   1039(31)   2864(79)
          removed      4(4)      5(3)      11(3)      21(3)
         resolved     13(1)     44(6)      99(2)     258(8)
   + top 10 contributors:
         Heiko Tietze made 260 changes in 1 month, and 1371 changes in 1 year
         Seth Chaiklin made 101 changes in 1 month, and 182 changes in 1 year
         Dieter Praas made 84 changes in 1 month, and 422 changes in 1 year
         Foote, V Stuart made 79 changes in 1 month, and 515 changes in 1 year
         Xisco Faulí made 71 changes in 1 month, and 452 changes in 1 year
         Roman Kuznetsov made 53 changes in 1 month, and 328 changes in 1 year
         Kainz, Andreas made 40 changes in 1 month, and 270 changes in 1 year
         锁琨珑 made 28 changes in 1 month, and 32 changes in 1 year
         Cor Nouws made 15 changes in 1 month, and 170 changes in 1 year
         Muhammet Kara made 13 changes in 1 month, and 44 changes in 1 year

   + 22 new tickets with needsUXEval since Feb/07

   + Add Sukapura icon Theme to Core and Set It to Default for macOS
     + https://bugs.documentfoundation.org/show_bug.cgi?id=130500
     + make it the default on macOS
     + mostly UX domain (Miklos)
       => no objections (all)

   + Add possibility to define tab positions in percentage of paragraph area
     width
     + https://bugs.documentfoundation.org/show_bug.cgi?id=130420
     + needsDevEval
     + Word has something similar, paragraph tabs (can e.g. center)
       + if somebody wants to work on this, go ahead (Miklos)

   * Dark theme for the welcome window
     + https://bugs.documentfoundation.org/show_bug.cgi?id=129725
     + accepted regression
     + would suggest checking why it was introduced, to understand who needs it (Miklos)


* Crash Testing (Caolan)
   + we’re missing Caolan
   + 1(-26) import failure, 2(-2) export failures
   + ??? coverity issues
   + Google / ossfuzz: ?? fuzzers active now
   + crashtesting machine status
     + probably nothing changed, still no results (Michael S)
     + https://dev-builds.libreoffice.org/crashtest/?C=M&O=D
       + result from yesterday? (Miklos)
         + it’s probably the limited set (Cloph)

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.8.2
        + (-537) 1045 1582 1639 1645 1157 1172 1195 1082 973 815 568 375 320 198
    + https://crashreport.libreoffice.org/stats/version/6.3.3.2
        + (-929) 1430 2359 2830 3068 2555 3302 4368 3674 3312 2629 1820 854 0
    + https://crashreport.libreoffice.org/stats/version/6.3.4.2
        + (-1113) 2188 3301 3769 3222 2057 984 0
    + https://crashreport.libreoffice.org/stats/version/6.4.0.3
        + (+1932) 6774 4842 419 0

   + numbers are lower then usual, service was down for 2 days (Xisco)
     + the reproducible crashes are now fixed, waiting for the next release

* Update baseline to VS2019 on master before 7.0 (Cloph)
   + Noel lists benefits on the list:
     + ASan support, faster linking, better C++ conforming
   + Did somebody tried the Asan support? (Michael S)
     + no idea yet (Stephan)

=> re-visit this in 1 week, make a decision by then / by 27th

Update macOS Xcode baseline to 11 (Stephan)
   + and build-baseline to macOS 10.14.4
   + assumed that TDF Macs are using xcode11 anyway
   + benefits: we know how to fix the blurry text issue with Xcode 11
       (but not with Xcode 10)
     + also better c++ library support (e.g. std::optional)
   + OK to require xcode 11 on master (Cloph)
AI: + actually require xcode 11 on master (Stephan)

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
         + if you have the time, please do mentoring!
       + next deadline: 20th Feb, accepted organizations announced (Thorsten)
       + then student application period
   + students contacting potential mentors already, as usual

* mentoring/easyhack update
   + reviewing patches from first contributors is much appreciated (Muhammet)
+      + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers

         committer...   1 week      1 month      3 months     12 months
                 open      81(7)       125(7)       139(8)        150(10)
              reviews     546(-416)   2602(-154)   6426(-216)   23699(2)
               merged     396(-67)    1601(38)     4781(-83)    18294(106)
            abandoned      21(-17)      90(1)       284(-4)       972(11)
          own commits     354(26)     1448(126)    4018(80)     15211(106)
       review commits      87(-48)     490(39)     1280(39)      4505(40)
       contributor...   1 week       1 month    3 months      12 months
                 open       36(-14)     115(4)      118(6)        120(6)
              reviews     1054(-319)   4159(40)   10954(-148)   36426(250)
               merged       24(-11)     165(0)      355(11)       862(9)
            abandoned        8(1)        39(-1)      77(-142)     478(1)
          own commits       24(-10)     177(8)      375(14)      1015(18)
       review commits        0(0)         0(0)        0(0)          0(0)
   + easyHack statistics:
      needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 206(206)
      total 254(254)   assigned 18(18)   open 221(221)
   + top 10 contributors:
         Pranam Lashkari made 13 patches in 1 month, and 24 patches in 1 year
         Weblate made 10 patches in 1 month, and 28 patches in 1 year
         Onur Yılmaz made 9 patches in 1 month, and 19 patches in 1 year
         Sophia Schröder made 8 patches in 1 month, and 8 patches in 1 year
         Balazs Varga made 6 patches in 1 month, and 59 patches in 1 year
         PhD. Ayhan YALÇINSOY made 6 patches in 1 month, and 10 patches in 1 year
         Batuhan Taskaya made 6 patches in 1 month, and 6 patches in 1 year
         Pelin, Rabia Kuran made 6 patches in 1 month, and 6 patches in 1 year
         Mehmet Emin Başoğlu made 6 patches in 1 month, and 6 patches in 1 year
         İrfan Akarsu made 6 patches in 1 month, and 6 patches in 1 year
   + top 10 reviewers:
         Behrens, Thorsten made 224 review comments in 1 month, and 1438 in 1 year
         Michael Stahl made 204 review comments in 1 month, and 1524 in 1 year
         Nabet, Julien made 184 review comments in 1 month, and 2412 in 1 year
         Adolfo Jayme Barrientos made 164 review comments in 1 month, and 1006 in 1 year
         Muhammet Kara made 158 review comments in 1 month, and 352 in 1 year
         Meeks, Michael made 141 review comments in 1 month, and 848 in 1 year
         Holešovský, Jan made 138 review comments in 1 month, and 989 in 1 year
         Vajna, Miklos made 134 review comments in 1 month, and 1496 in 1 year
         Bergmann, Stephan made 124 review comments in 1 month, and 1047 in 1 year
         Kaganski, Mike made 120 review comments in 1 month, and 834 in 1 year
   + Patches automatically abandoned:
       tdf#127815 Revert "tdf#124118 Qt5 post non-code keys via ExtTextInput" ( Jan-Marek Glogowski 
)
           - https://gerrit.libreoffice.org/#/c/84821
       tdf#127706 Work around clearing direct formatting breaks undo ( Jim Raykowski )
           - https://gerrit.libreoffice.org/#/c/85195
       tdf#124176: Use pragma once instead of include guards ( Alakbar Alikperov )
           - https://gerrit.libreoffice.org/#/c/85467
       tdf#124176: Use pragma once instead of include guards ( Alakbar Alikperov )
           - https://gerrit.libreoffice.org/#/c/85469
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Pranesh Ulleri
         Marina Latini
         Mohamed Sameh
         NienTsu Wu

Commit Access
   +  None

* Developer Certification (Stephan/Kendy/Thorsten)
   + sleep -10 weeks
   + seeking for a new person as a replacement for Bjoern, who is currently inactive

* Jenkins / CI update (Christian)
   from:Thu Feb 13 15:15:58 2020
   master linux rel  jobs:  86 ok:  86 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master linux dbg  jobs:  81 ok:  74 ko:   6 fail ratio:  7.41 % break:   5 broken duration: 7.53%
   master mac rel    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master win rel    jobs: 113 ok: 103 ko:  10 fail ratio:  8.85 % break:  10 broken duration:12.44%
   master win dbg    jobs: 119 ok: 114 ko:   5 fail ratio:  4.20 % break:   5 broken duration: 5.79%
   master win64 dbg  jobs: 115 ok: 103 ko:  11 fail ratio:  9.57 % break:  10 broken duration: 5.85%
   master gerrit lin jobs: 507 ok: 434 ko:  50 fail ratio:  9.86% time for ok: mean:  20 median:  20
   master gerrit plg jobs: 473 ok: 312 ko: 119 fail ratio: 25.16% time for ok: mean:  28 median:  26
   master gerrit win jobs: 520 ok: 371 ko:  92 fail ratio: 17.69% time for ok: mean:  59 median:  54
   master gerrit mac jobs: 531 ok: 408 ko:  61 fail ratio: 11.49% time for ok: mean:  34 median:  33
   master gerrit all jobs: 485 ok: 261 ko: 147 fail ratio: 30.31% time for ok: mean:  81 median:  65
  + https://dev-www.libreoffice.org/tmp/gerrit_200220.html
  + tests that failed more than twice in last seven days:
     3 CppunitTest_sc_subsequent_export_test
     3 CppunitTest_sw_ooxmlexport3
     5 CppunitTest_basic_macros
     6 CppunitTest_sw_odfexport
     6 CppunitTest_sw_uwriter
     6 JunitTest_forms_unoapi_2
    10 JunitTest_toolkit_unoapi_1
    19 UITest_impress_tests

  + unstable UI test was the only source of failure failures (Cloph)
    + already fixed, thanks Xisco

* l10n (Sophie)
  + update to Weblate 3.10.3 done
    + worked well, nicely, fast
    + now translations.documentfoundation.org, not weblate.tdf

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia / vulkan: to try it, export SAL_ENABLESKIA=1 on master (Miklos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
     + 18 bugs total (2 open)
   + Lubos works on making it the default on Windows on master (in a few weeks)
     + skia blacklisting is now complete
     + working on opengl transitions in Impress

* docx/xlsx competitive marketing issues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs (0)
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs (0)

* request from board regarding general OOXML improvements (Thorsten)
   + are there larger areas that needs huge work?
     + floating tables in Writer (Michael S)
     + table change tracking in Writer (Michael M)
     + page styles vs section breaks (Miklos)
     + smartart editing in Impress
     + table feature from Excel
       + formulas are working, but nothing else (Eike)
     + Calc column limit
     + Calc’s table styles (Eike)
     + Theming (Michael, Thorsten)
     + PowerPoint’s automatic layout (Kendy)
       + guidelines, though that’s more UI
=> more than enough :) (Thorsten)
     + perhaps in the future, put some ballparks for these and prioritize, but not yet

* Meson build system experiments by Jussi Pakkanen (Ilmari)
   + Project interviews and benefits/concerns here: 
https://nextcloud.documentfoundation.org/apps/files/?dir=/Shared/Common/Meson%20evaluation&fileid=275581
   + Kohei gives thumbs up (Ilmari)
   + Thanks Ilmari a lot for investing time into doing the interviews (all)

* Putting firebird creation option to experimental (Xisco)
        * 
http://document-foundation-mail-archive.969070.n3.nabble.com/About-putting-Firebird-creation-option-experimental-td4274028.html
     * post from Julien
     * is there a list of unfixed problems? (Miklos)
     * https://bugs.documentfoundation.org/show_bug.cgi?id=51780 Default to Firebird not HSQLDB in 
Base (for _new_ files) (33 open, 86 total bugs)

     * https://bugs.documentfoundation.org/show_bug.cgi?id=116968 Migrating existing embedded 
HSQLDB databases to Firebird, but this is already experimental

     * when creating a new embedded DB, default is hsqldb, but firebird is available
     * possibly only Julien fixes firebird bugs (Michael S)
AI:   * get back to Julien ask ask to propose a gerrit change (Xisco)

* QA update (Xisco)
   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 621 (-32)
       + enhancements: 70  (-13)
       + needsUXEval: 2 (-12)
       + haveBackTrace: 1 (+1)
       + needsDevAdvice: 11 (+0)
       + documentation:  12 (+0)
       + android:  8 (+2)
       + iOS:  0 (+0)
       + Online:  12 (+3)


   + Most pressing bugs:
    New:
       None

    Old:
       + FILEOPEN: Some labels in charts are not displayed by default
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117088
           + Tamas Buth will take a look

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

        Fixed:

        + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
            + Thanks to Stephan
                + still affecting users while mac builds are done with xcode10
           + Still, my fix only fixes the symptoms with Xcode 11 (and who knows
             what bad side effects it could eventually have), not the
             underlying cause (whatever that is exactly, probably related to
             "Layer-Backed Views",
             <https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c172>)
             which should still be fixed. (Stephan)
           + this is just a band-aid, at some stage the root cause has to be fixed (Stephan)


   + New high severity bugs of the week:
       + Default buttons have the wrong text color on macOS
           + https://bugs.documentfoundation.org/show_bug.cgi?id=125088
           + Review needed: https://gerrit.libreoffice.org/c/core/+/87001

       + Writer crashes when Alt+Arrow Up keys are pressed within a table row spanning two pages
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130746
           + not a regression?
           + 700 crashes reported using crash reporter

       + Impress crashes on broken hyperlink click
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130760
           + Samuel?

       + Importing autofiltered XLSX and selecting cells copies hidden cells, too
           + https://bugs.documentfoundation.org/show_bug.cgi?id=99913
           + not new, was in 3.4 already?

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +160  +2 (-154) overall)
     many thanks to the top bug squashers:
      Xisco Faulí             21
      Heiko Tietze            16
      Dieter                  10
      Caolán McNamara         9
      Julien Nabet            8
      eisa01                  7
      Timur                   5
      Eike Rathke             4
      Michael Stahl (CIB)     4
      Buovjaga                3

   + top 10 bugs reporters:
      Roman Kuznetsov         9
      Xisco Faulí             8
      Nick Levinson           4
      Mike Kaganski           3
      NISZ LibreOffice Team   3
      Rizal Muttaqin          3
      Armin Le Grand          2
      Aron Budea              2
      Dr. Frank P Ferraro     2
      Eduardo Ramos           2

   + top 10 bugs fixers:
      McNamara, Caolán        9
      Xisco Faulí             8
      Heiko Tietze            5
      Michael Stahl           3
      Adolfo Jayme Barrientos 2
      Grandin, Noel           2
      Nabet, Julien           2
      Rathke, Eike            2
      Rizal Muttaqin          2
      Seth Chaiklin           2

   + top 10 bugs confirmers:
      Xisco Faulí             64
      Heiko Tietze            17
      Dieter Praas            13
      Nabet, Julien           11
      eisa01                  6
      Brinzing, Oliver        3
      Ilmari Lauhakangas      3
      Olivier Hallot          3
      *UNKNOWN*               2
      Ahmad Haris             2


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 1/40 -     2 %  (+0)
    5.3 : 0/54 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 5/244 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  +

    done by:
       Xisco Faulí            18
       Brinzing, Oliver        2
       Budea, Áron             1
       Kelemen, Gabor          1
       NISZ LibreOffice Team   1
       Raal                    1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  +

    done by:
       Xisco Faulí            20
       Budea, Áron             2
       Brinzing, Oliver        2
       Kelemen, Gabor          1
       NISZ LibreOffice Team   1
       Raal                    1


* all bugs tagged with 'regression'
  + 1137(-6) bugs open of 9343(+28) total 2(+0) high prio.

    done by:
       Xisco Faulí            16
       eisa01                  3
       Roman Kuznetsov         2
       Brinzing, Oliver        2
       Budea, Áron             1
       Kelemen, Gabor          1
       NISZ LibreOffice Team   1
       Michael Stahl           1
       Raal                    1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    Calc          - 1(+0)
    UI            - 1(+0)

  by OS:
    All           - 1(+0)
    Linux         - 0(+0)
    Mac OS X      - 1(+0)
    Windows       - 0(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 317(+3)
    Calc                     - 220(-4)
    Impress                  - 132(+2)
    Writer: docx filter      - 67(-2)
    LibreOffice              - 65(+1)
    Draw                     - 46(-1)
    UI                       - 41(+0)
    Borders                  - 38(+1)
    Crashes                  - 37(+4)
    Base                     - 34(-2)
    Writer: perf             - 34(+1)
    Writer: doc filter       - 30(+0)
    Writer: other filter     - 30(+0)
    graphics stack           - 27(+0)
    RTL                      - 23(+0)
    filters and storage      - 22(+0)
    Printing and PDF export  - 21(+0)
    BASIC                    - 17(-2)
    Chart                    - 17(+0)
    framework                - 2(+0)
    Extensions               - 1(+0)
    Installation             - 1(+0)
    sdk                      - 1(+0)