ESC meeting minutes: 2020-02-13

* Present:
    + Ilmari, Michael W, Gabriel, Michael S, Cloph, Stephan, Caolan, Eike, Thorsten, Kendy, Miklos, 
Xisco, Olivier

* Completed Action Items:
   + None

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)
     + still waiting
   + Automated reminder email to the dev list for this meeting (Xisco)

* Release Engineering update (Cloph)
   + 7.0 release plan added to the wiki
     + feature freeze is last week of May
   + 6.4 status
     + 6.4.1 rc2 tagging is scheduled for next week
   + 6.3 status
     + 6.3.5 rc2 tagged on Tue
     + 6.3.<next> in April
   + Remotes
   + Android viewer: core.git java viewer is currently broken on master
     + both arch64 and x86 (crash on doc load, will investigate)
   + Online

* Documentation (Olivier)
   + New Help
      + XHP editor quite usable, please test
      + some optimizations in XSLT (m kaganski)
      + discussion on improvements in new help (buovjaga)
   + Helpcontent 2
      + Many fixes and updates (S. Chaiklin, ohallot, Fitoshido)
      + issues with screenshots

   + Guides
      + team actively updating several books
      + L10n teams jumping in for translation


* UX Update (Heiko)
   + Heiko missing
   + Bugzilla (topicUI) statistics
       236(236) (topicUI) bugs open, 271(271) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month   3 months   12 months
            added     13(5)      39(10)     61(9)     127(10)
        commented     79(-10)   394(13)   1008(37)   2785(75)
          removed      0(-2)      2(-2)      8(-2)     18(-2)
         resolved     12(3)      38(3)      97(6)     250(5)
   + top 10 contributors:
         Heiko Tietze made 176 changes in 1 month, and 1251 changes in 1 year
         Seth Chaiklin made 98 changes in 1 month, and 167 changes in 1 year
         Xisco Faulí made 73 changes in 1 month, and 434 changes in 1 year
         Dieter Praas made 72 changes in 1 month, and 412 changes in 1 year
         Foote, V Stuart made 71 changes in 1 month, and 510 changes in 1 year
         Roman Kuznetsov made 51 changes in 1 month, and 325 changes in 1 year
         Kainz, Andreas made 45 changes in 1 month, and 269 changes in 1 year
         锁琨珑 made 30 changes in 1 month, and 34 changes in 1 year
         Cor Nouws made 23 changes in 1 month, and 162 changes in 1 year
         Ilmari Lauhakangas made 17 changes in 1 month, and 34 changes in 1 year

* Crash Testing (Caolan)
   + 1(+0) import failure, 2(+0) export failures
     - mini-runs on last failures of last successful megarun
     - plan is to move this to a dedicated host in a few weeks (Cloph)
   + 0 coverity issues
   + 10 ossfuzz issues (-3 thanks to mst)
   + no full run of the full crashtesting, still
     + mini-run is done, though

* Crash Reporting (Xisco)
        - Service is down. No data at the moment
     - 6.4.0 crash → signature → already fixed on libreoffice-6-4
       - Xisco reverted the problematic commit – author not available anymore

Update baseline to VS2019 on master before 7.0 (Cloph)
   + Noel lists benefits on the list:
     + ASan support, faster linking, better C++ conforming
   + Did somebody tried the Asan support? (Michael S)
     + no idea yet (Stephan)

=> re-visit this in 2 weeks, make a decision by then / 27th

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
         + if you have the time, please do mentoring!
       + next deadline: 20th Feb, accepted organizations announced (Thorsten)
       + then student application period

* mentoring/easyhack update
   + reviewing patches from first contributors is much appreciated (Muhammet)
     + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers

         committer...   1 week     1 month     3 months      12 months
                 open      74(-8)     118(-36)    131(-43)       140(-45)
              reviews     962(318)   2756(-68)   6642(-4994)   23697(-28911)
               merged     463(181)   1563(95)    4864(50)      18188(292)
            abandoned      38(31)      89(13)     288(20)        961(33)
          own commits     328(80)    1322(47)    3938(-10)     15105(107)
       review commits     135(57)     451(23)    1241(49)       4465(77)
       contributor...   1 week      1 month      3 months      12 months
                 open       50(-20)    111(1)        112(-6)       114(-7)
              reviews     1373(365)   4119(-101)   11102(4345)   36176(26246)
               merged       35(12)     165(8)        344(16)       853(-71)
            abandoned        7(0)       40(-2)       219(-2)       477(-12)
          own commits       34(3)      169(0)        361(-12)      997(2)
       review commits        0(0)        0(0)          0(0)          0(0)
   + easyHack statistics:
      needsDevEval 6(6)   needsUXEval 1(1)   cleanup_comments 206(206)
      total 251(251)   assigned 18(18)   open 220(220)
   + top 10 contributors:
         Pranam Lashkari made 13 patches in 1 month, and 23 patches in 1 year
         Onur Yılmaz made 10 patches in 1 month, and 19 patches in 1 year
         Sophia Schröder made 8 patches in 1 month, and 8 patches in 1 year
         Adrien Ollier made 6 patches in 1 month, and 27 patches in 1 year
         Weblate made 6 patches in 1 month, and 22 patches in 1 year
         mesut çifci made 6 patches in 1 month, and 12 patches in 1 year
         Batuhan Taskaya made 6 patches in 1 month, and 6 patches in 1 year
         Pelin, Rabia Kuran made 6 patches in 1 month, and 6 patches in 1 year
         Mehmet Emin Başoğlu made 6 patches in 1 month, and 6 patches in 1 year
         İrfan Akarsu made 6 patches in 1 month, and 6 patches in 1 year
   + top 10 reviewers:
         Behrens, Thorsten made 216 review comments in 1 month, and 1424 in 1 year
         Michael Stahl made 212 review comments in 1 month, and 1522 in 1 year
         Adolfo Jayme Barrientos made 184 review comments in 1 month, and 1000 in 1 year
         Nabet, Julien made 178 review comments in 1 month, and 2404 in 1 year
         Muhammet Kara made 160 review comments in 1 month, and 350 in 1 year
         Holešovský, Jan made 154 review comments in 1 month, and 1001 in 1 year
         Meeks, Michael made 151 review comments in 1 month, and 832 in 1 year
         Kaganski, Mike made 150 review comments in 1 month, and 830 in 1 year
         Bergmann, Stephan made 150 review comments in 1 month, and 1065 in 1 year
         Vajna, Miklos made 134 review comments in 1 month, and 1486 in 1 year
   + Patches automatically abandoned:
       tdf#126742: sc: GetVisArea is the same for normal and embedded mode. ( Vasily Melenchuk )
           - https://gerrit.libreoffice.org/#/c/77002
       tdf#128276 Font names are not localized on macOS Catalina ( Tomofumi Yagi )
           - https://gerrit.libreoffice.org/#/c/81145 → restored
       lok: on insert image rotate automatically based on EXIF orientation tag ( Mert Tümer )
           - https://gerrit.libreoffice.org/#/c/82085
       tdf#47065:Notify user about document closure for locked document ( Aditya Sahu )
           - https://gerrit.libreoffice.org/#/c/84919
           => might make sense to restore this
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Michel Thomas

* Commit Access
   +  None

* Developer Certification (Stephan/Kendy/Thorsten)
   + sleep -9 weeks
   + seeking for a new person as a replacement for Bjoern, who is currently inactive

* Jenkins / CI update (Christian)
   from:Thu Feb  6 14:50:04 2020
   master linux rel  jobs:  64 ok:  63 ko:   1 fail ratio:  1.56 % break:   1 broken duration: 0.00%
   master linux dbg  jobs:  57 ok:  56 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac rel    jobs:  25 ok:  25 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:  30 ok:  28 ko:   1 fail ratio:  3.33 % break:   1 broken duration: 0.57%
   master win rel    jobs:  72 ok:  68 ko:   4 fail ratio:  5.56 % break:   4 broken duration: 1.83%
   master win dbg    jobs:  76 ok:  72 ko:   4 fail ratio:  5.26 % break:   3 broken duration: 2.06%
   master win64 dbg  jobs:  74 ok:  69 ko:   5 fail ratio:  6.76 % break:   5 broken duration: 3.84%
   master gerrit lin jobs: 660 ok: 554 ko:  72 fail ratio: 10.91% time for ok: mean:  20 median:  20
   master gerrit plg jobs: 606 ok: 450 ko: 107 fail ratio: 17.66% time for ok: mean:  29 median:  26
   master gerrit win jobs: 761 ok: 501 ko: 199 fail ratio: 26.15% time for ok: mean:  64 median:  58
   master gerrit mac jobs: 672 ok: 500 ko: 129 fail ratio: 19.20% time for ok: mean:  34 median:  26
   master gerrit all jobs: 615 ok: 328 ko: 217 fail ratio: 35.28% time for ok: mean: 145 median: 130
  + https://dev-www.libreoffice.org/tmp/gerrit_200213.html
  + tests that failed more than twice in last seven days:
     3 CppunitTest_sc_financial_functions_test
     4 CppunitTest_basic_macros
     4 CppunitTest_sw_ooxmlexport5
     5 CppunitTest_sw_uibase_shells
     5 CppunitTest_sw_uwriter
     5 UITest_impress_tests
     5 UITest_writer_tests
     7 CppunitTest_vcl_pdfexport

   + one macOS box was broken, now taken offline
   + glm update / vcl pdf export test is still an effect from last week

* l10n (Sophie)
  + update to 3.10.3 scheduled for this Friday

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia / vulkan: to try it, export SAL_ENABLESKIA=1 on master (Miklos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
     + 18 bugs total (3 open)
   + Lubos works on making it the default on Windows on master (in a few weeks)
     + opengl transitions in Impress
     + ability to blacklist mis-rendering drivers from config

* docx/xlsx competitive marketing issues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs (0)
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs (0)

tdf#130453 - [MacOS] Convert from Carbon to Cocoa framework (Miklos)
   + Julien asks the ESC (in comment 7) to provide input
   + great to migrate away from Carbon (Cloph)
   + don’t believe we still use Carbon (Michael S)
   + would be great to at least consider going the skia way (Miklos)

* Meson build system experiments by Jussi Pakkanen (Ilmari)
   + Meson creator Jussi has done preliminary feasibility evaluation for free
   + https://nibblestew.blogspot.com/2020/02/building-very-small-subset-of.html
   + https://nibblestew.blogspot.com/2020/02/trying-to-build-slightly-larger-slice.html
   + if there is interest in principle, we can seek independent funding for a prototype
   + prototype would make it easier to evaluate benefits
   + Ilmari’s perspective: want to make the codebase more approachable for newcomers

   + understand that we don’t want to drop something that works already (Ilmari)
   + not yet asking for a decision, but please think about this
   + what problem does this solve? (Kendy)
     + usually LO breaks the tools
   + GNOME / wayland is moving to this from autotools (Ilmari)
   + sitting on the fence (Thorsten)
     + significant cost to migrate to anything
     + there are load of unsolved problems with the build system, though
   + would not be great to pay some external developers to do the migration and then let us 
maintain it (Stephan)
     + agreed (Kendy, Cloph)
   + better spend funding money elsewhere (Kendy)
     + e.g. external libs that can’t build in parallel

* Bugzilla’s Antispam plugin (Xisco)
        - 
http://document-foundation-mail-archive.969070.n3.nabble.com/Bugzilla-tweaking-Antispam-plugin-td4273683.html
     - if you see URL-spam on a bug → set the resolved/verified to closed → no more spam will 
appear there
     - NEW bug → let Xisco know, he’ll extend the blacklist

* QA update (Xisco)
   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 653 (+16)
       + enhancements: 83  (+6)
       + needsUXEval: 14 (+9)
       + haveBackTrace: 0 (+0)
       + needsDevAdvice: 11 (+0)
       + documentation:  12 (+2)
       + android:  6 (+0)
       + iOS:  0 (+0)
       + Online:  9 (-8)


   + Most pressing bugs:
    New:
         [None]
    Old:
       + FILEOPEN: Some labels in charts are not displayed by default
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117088
           + Tamas Buth will take a look

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

        + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notarization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)
               + found out: not a regression, but it is from a user’s PoV

  Fixed:
       + Can't align text in a textbox
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130482
           + Thanks to Miklos

       + Crash in: SfxItemPool::IsInRange(unsigned short)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130614
           + Thanks to Xisco. Commit Reverted


   + New high severity bugs of the week:
       + Print a calc document is hanging in LO 6.4 (print ranges) (gen)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130412
           + Ilhan?
             + a colleague of mine (Michael W)
           + should we just revert this for now? (Eike)
             + no problem, could be reverted for now (Michael W)
AI:              + revert on master + backport to have it in 6.4.1 (Xisco)

       + Crash on pasting a table from Writer
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130483
           + Mark?

       + Since update, substitute color only works if left set to transparent.
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130373
           + Noel?

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +162  +36 (-152) overall)
     many thanks to the top bug squashers:
      Xisco Faulí             20
      QA Administrators       12
      Caolán McNamara         9
      Andras Timar            6
      Timur                   6
      Dieter                  5
      Julien Nabet            4
      Maxim Monastirsky       4
      Michael Weghorn         4
      V Stuart Foote          4

   + top 10 bugs reporters:
      Xisco Faulí             7
      Roman Kuznetsov         6
      Robert Großkopf         5
      NISZ LibreOffice Team   4
      sdc.blanco              4
      Kevin Suo               3
      Maxim Monastirsky       3
      Aron Budea              2
      Jean-Philippe MENGUAL   2
      Ken Gramm               2

   + top 10 bugs fixers:
      McNamara, Caolán        8
      Adolfo Jayme Barrientos 3
      Andras Timar            2
      Bergmann, Stephan       2
      Monastirsky, Maxim      2
      Seth Chaiklin           2
      Timur                   2
      Vajna, Miklos           2
      *UNKNOWN*               1
      Andreas Heinisch        1

   + top 10 bugs confirmers:
      Xisco Faulí             18
      Dieter Praas            11
      *UNKNOWN*               7
      Nabet, Julien           6
      Budea, Áron             5
      Andras Timar            4
      Raal                    4
      Brinzing, Oliver        3
      Foote, V Stuart         3
      Ilmari Lauhakangas      3


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 1/40 -     2 %  (+0)
    5.3 : 0/54 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 5/244 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  +

    done by:
       Xisco Faulí            16
       Budea, Áron             4
       Raal                    4
       NISZ LibreOffice Team   1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  +

    done by:
       Xisco Faulí            16
       Budea, Áron             4
       Raal                    4
       NISZ LibreOffice Team   1


* all bugs tagged with 'regression'
  + 1143(+5) bugs open of 9315(+23) total 2(+0) high prio.

    done by:
       Xisco Faulí             9
       Raal                    4
       Timur                   2
       Roman Kuznetsov         1
       Budea, Áron             1
       Dieter Praas            1
       Strba, Fridrich         1
       NISZ LibreOffice Team   1
       Monastirsky, Maxim      1
       Brinzing, Oliver        1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    Calc          - 1(+0)
    UI            - 1(+0)

  by OS:
    All           - 1(+0)
    Linux         - 0(+0)
    Mac OS X      - 1(+0)
    Windows       - 0(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 314(+1)
    Calc                     - 224(-1)
    Impress                  - 130(+2)
    Writer: docx filter      - 69(-2)
    LibreOffice              - 64(+0)
    Draw                     - 47(+2)
    UI                       - 41(+0)
    Borders                  - 37(+0)
    Base                     - 36(+2)
    Crashes                  - 33(+2)
    Writer: perf             - 33(+0)
    Writer: doc filter       - 30(+1)
    Writer: other filter     - 30(+0)
    graphics stack           - 27(+0)
    RTL                      - 23(+0)
    filters and storage      - 22(-1)
    Printing and PDF export  - 21(+1)
    BASIC                    - 19(+1)
    Chart                    - 17(-1)
    framework                - 2(+0)
    Extensions               - 1(+0)
    Installation             - 1(+0)
    sdk                      - 1(+0)