ESC meeting minutes: 2020-02-06

* Present:
    + Gabriel, Heiko, Sophie, Michael W, Caolan, Stephan, Cloph, Miklos, Thorsten, Xisco, Kara, 
Kendy, Michael S

* Completed Action Items:
   + take care of the GSoC 2020 application process till 5th Feb (Thorsten)
   + click the button for Seth Chaiklin commit access (Miklos)
     + now done by infra; guilhem pressed the button

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)
     + still waiting

* Release Engineering update (Cloph)
   + 6.4 status
     + 6.4.1 rc1 tag done yesterday; rc2 in 2 weeks
   + 6.3 status
     + 6.3.5 rc2 tagging next week
   + Remotes
   + Android viewer: core.git java viewer is currently broken on master
     + both arch64 and x86 (crash on doc load, will investigate)
   + Online

* Documentation (Olivier)
   + Missing Olivier

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       239(239) (topicUI) bugs open, 259(259) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month   3 months   12 months
            added      8(-5)     29(1)     52(1)      117(-2)
        commented     89(-20)   381(18)   971(18)    2710(55)
          removed      2(1)       4(2)     10(2)       20(2)
         resolved      9(-1)     35(4)     91(4)      245(7)
   + top 10 contributors:
         Heiko Tietze made 227 changes in 1 month, and 1247 changes in 1 year
         Seth Chaiklin made 85 changes in 1 month, and 144 changes in 1 year
         Xisco Faulí made 71 changes in 1 month, and 433 changes in 1 year
         Foote, V Stuart made 58 changes in 1 month, and 479 changes in 1 year
         Dieter Praas made 54 changes in 1 month, and 397 changes in 1 year
         Kainz, Andreas made 48 changes in 1 month, and 269 changes in 1 year
         kompilainenn made 32 changes in 1 month, and 308 changes in 1 year
         Cor Nouws made 22 changes in 1 month, and 160 changes in 1 year
         Thomas Lendo made 17 changes in 1 month, and 245 changes in 1 year
         Jim Raykowski made 16 changes in 1 month, and 55 changes in 1 year

   + New tickets with needsUXEval since 23/Jan

      * 24 (no details due to FOSDEM)

   -> * Interrupt underlining for characters with descenders
        + https://bugs.documentfoundation.org/show_bug.cgi?id=130419
        + ideally realized per OpenType property similar to CSS
          text-decoration-skip-ink
        + break the underlining for letters like ‘f’ or ‘g’ (
        => no objections in general if somebody wants to work on this

* Crash Testing (Caolan)
   + 27(+0) import failure, 4(+0) export failures
     + still no complete run!; the box has to be stable for 2-3 days at least
     + failed the same way in the last couple of weeks
     + plan to move it to an independent machine (Cloph)
     + should happen in February
   + 4 coverity issues
   + 15 ossfuzz issues
     + new lwps leaks

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.8.2
        + (-57) 1582 1639 1645 1157 1172 1195 1082 973 815 568 375 320 198 0
    + https://crashreport.libreoffice.org/stats/version/6.3.3.2
        + (-471) 2359 2830 3068 2555 3302 4368 3674 3312 2629 1820 854 0
    + https://crashreport.libreoffice.org/stats/version/6.3.4.2
        + (-468) 3301 3769 3222 2057 984 0
    + https://crashreport.libreoffice.org/stats/version/6.4.0.3
        + (+4423) 4842 419 0

   + 6.4: quite some crashes, most of them related to a bug already fixed (change alignment of 
textboxes)

    + Recent regressions without steps to reproduce
1.
https://crashreport.libreoffice.org/stats/signature/ScDocument::RemoveSubTotalCell(ScFormulaCell%20*)

2. Only linux
https://crashreport.libreoffice.org/stats/signature/SfxItemPool::GetFrozenIdRanges


   + if you have an idea, please create a list of reproducer steps!

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
       + Please review the ideas for any obsolete ones
         + Not much has happened (Ilmari)
       + next deadline will be: 20th Feb, accepted organizations accounced (Thorsten)
       + then student application period

* mentoring/easyhack update
   + reviewing patches from first contributors is much appreciated (Muhammet)
     + 
https://gerrit.libreoffice.org/q/status:open+-label:Code-Review=-1+-label:Verified=-1+-ownerin:Committers

         committer...   1 week      1 month     3 months      12 months
                 open      82(14)      154(20)      174(29)       185(29)
              reviews     644(-174)   2824(90)    11636(-312)   52608(-484)
               merged     282(-73)    1468(96)     4814(-5)     17896(71)
            abandoned       7(-11)      76(-6)      268(9)        928(-2)
          own commits     248(-73)    1275(109)    3948(16)     14998(82)
       review commits      78(-66)     428(7)      1192(6)       4388(29)
       contributor...   1 week       1 month     3 months    12 months
                 open       70(15)      110(5)      118(12)     121(12)
              reviews     1008(-248)   4220(118)   6757(575)   9930(661)
               merged       23(-61)     157(-32)    328(-42)    924(-71)
            abandoned        7(-15)      42(-4)     221(-11)    489(-14)
          own commits       31(-56)     169(-50)    373(-58)    995(-64)
       review commits        0(0)         0(0)        0(0)        0(0)
   + easyHack statistics:
      needsDevEval 6(6)   needsUXEval 1(1)   cleanup_comments 208(208)
      total 255(255)   assigned 19(19)   open 223(223)
   + top 10 contributors:
         Pranam Lashkari made 12 patches in 1 month, and 22 patches in 1 year
         Onur Yılmaz made 11 patches in 1 month, and 18 patches in 1 year
         mesut çifci made 10 patches in 1 month, and 12 patches in 1 year
         Weblate made 7 patches in 1 month, and 20 patches in 1 year
         Yusuf Keten made 7 patches in 1 month, and 12 patches in 1 year
         Adrien Ollier made 7 patches in 1 month, and 27 patches in 1 year
         İrfan Akarsu made 6 patches in 1 month, and 6 patches in 1 year
         Batuhan Taskaya made 6 patches in 1 month, and 6 patches in 1 year
         Sarper Akdemir made 5 patches in 1 month, and 5 patches in 1 year
         Balazs Varga made 5 patches in 1 month, and 61 patches in 1 year
   + top 10 reviewers:
         Michael Stahl made 212 review comments in 1 month, and 1572 in 1 year
         Adolfo Jayme Barrientos made 206 review comments in 1 month, and 1022 in 1 year
         Bergmann, Stephan made 172 review comments in 1 month, and 1152 in 1 year
         Kaganski, Mike made 162 review comments in 1 month, and 886 in 1 year
         Nabet, Julien made 160 review comments in 1 month, and 2384 in 1 year
         Muhammet Kara made 154 review comments in 1 month, and 364 in 1 year
         Behrens, Thorsten made 154 review comments in 1 month, and 1463 in 1 year
         Vajna, Miklos made 150 review comments in 1 month, and 1542 in 1 year
         Holešovský, Jan made 138 review comments in 1 month, and 1070 in 1 year
         Meeks, Michael made 136 review comments in 1 month, and 850 in 1 year
   + Patches automatically abandoned:
       tdf#51611 - Macros: Cursor's GotoEndOfWord selects dot ( Andreas Heinisch )
           - https://gerrit.libreoffice.org/#/c/78269
           - concern: does not look ideal, best would be some new opt-in way to have the new 
behavior (Michael S)
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Emiliano Vavassori
         Daniel Lohmann
         Buğra Kurt
         Gabriele Ponzo

* Commit Access
   +  None

* Developer Certification (Stephan/Kendy/Thorsten)
   + sleep -8 weeks
   + seeking for a new person as a replacement for Bjoern, who is currently inactive

* Jenkins / CI update (Christian)
   from:Thu Jan 30 15:14:41 2020
   master linux rel  jobs:  70 ok:  70 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master linux dbg  jobs:  69 ok:  68 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac rel    jobs:  34 ok:  34 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:  38 ok:  38 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master win rel    jobs:  57 ok:  43 ko:  14 fail ratio: 24.56 % break:   8 broken duration:21.98%
   master win dbg    jobs:  68 ok:  53 ko:  15 fail ratio: 22.06 % break:   6 broken duration:27.75%
   master win64 dbg  jobs:  63 ok:  43 ko:  20 fail ratio: 31.75 % break:  12 broken duration:41.45%
   master gerrit lin jobs: 492 ok: 411 ko:  59 fail ratio: 11.99% time for ok: mean:  20 median:  19
   master gerrit plg jobs: 456 ok: 351 ko:  70 fail ratio: 15.35% time for ok: mean:  28 median:  26
   master gerrit win jobs: 604 ok: 330 ko: 222 fail ratio: 36.75% time for ok: mean:  56 median:  58
   master gerrit mac jobs: 486 ok: 404 ko:  39 fail ratio:  8.02% time for ok: mean:  40 median:  24
   master gerrit all jobs: 464 ok: 250 ko: 135 fail ratio: 29.09% time for ok: mean: 120 median:  96
  + https://dev-www.libreoffice.org/tmp/gerrit_200206.html
  + tests that failed more than twice in last seven days:
     3 CppunitTest_sc_subsequent_filters_test
     4 CppunitTest_sw_uwriter
    10 CppunitTest_vcl_pdfexport

  + code issue with the glm update that sometimes broke the Windows pdf export tests
   + Stephan tracked it down, thanks!
 + Jenkins was updated, couple of in-progress builds were lost

* l10n (Sophie)
  + Online.git creates Gerrit changes, so please don’t touch po files in git!
    + not a problem in core.git, have an interim repo there
  + translators are still working on 6.4
  + weblate update to 3.10.3 prepared on test instance
    requires database changes/scheduled downtime

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia / vulkan: to try it, export SAL_ENABLESKIA=1 on master (Miklos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
     + 15 fixed bugs (1 open)
   + Lubos works on this to make it the default on Windows (at some stage)
     + broken driver handling missing → abstracting away opengl/opencl zones
     + opengl transitions in Impress
   + 32bit Linux is broken again (Thorsten)
     + motivation is to just stay up to date with skia (Miklos)

* docx/xlsx competitive marketing issues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs (+1)
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs (0)

* QA update (Xisco)

   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 637 (+41)
       + enhancements: 77  (+5)
       + needsUXEval: 5 (-4)
       + haveBackTrace: 0 (+0)
       + needsDevAdvice: 11 (+0)
       + documentation:  10 (+3)
       + android:  6 (+0)
       + iOS:  0 (+0)
       + Online:  17 (-3)



   + Most pressing bugs:
    New:
       + Can't align text in a textbox
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130482
           + Szymon Kłos ?

    Old:
       + FILEOPEN: Some labels in charts are not displayed by default
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117088
           + Tamas Buth will take a look

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

        + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notarization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)
               + found out: not a regression, but it is from a user’s PoV


   + New high severity bugs of the week:
       + Calc: max. cpu load when defining 2 print ranges
           + https://bugs.documentfoundation.org/show_bug.cgi?id=130381
           + Needs bisecting?
           + macOS only


Reminders for this call in email each week? (Miklos)

  + like the idea (Thorsten)
  + why not a calendar invite? (Kendy)
  + script it perhaps
    + can go to the list, people don’t have to opt in
  + would just include the time and the jitsi link (Miklos)
  + AI: automate this (Xisco)
    + send it on Thur morning
    + include the time and the jitsi link

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +198  -59 (-139) overall)
     many thanks to the top bug squashers:
      Julien Nabet            10
      QA Administrators       10
      Xisco Faulí             9
      Caolán McNamara         6
      V Stuart Foote          5
      Timur                   5
      Dieter                  5
      Kevin Suo               5
      Aron Budea              4
      Jim Raykowski           4

   + top 10 bugs reporters:
      sdc.blanco              12
      NISZ LibreOffice Team   4
      Kevin Suo               4
      b.                      3
      Robert Großkopf         3
      V Stuart Foote          2
      Jacques Beckand         2
      Roman Kuznetsov         2
      lachend                 2
      Michael Meeks           2

   + top 10 bugs fixers:
      McNamara, Caolán        6
      Jim Raykowski           4
      kompilainenn            3
      Balazs Varga            3
      Glogowski, Jan-Marek    3
      Muhammet Kara           2
      Kaganski, Mike          2
      Xisco Faulí             2
      Bergmann, Stephan       2
      Németh, László          2

   + top 10 bugs confirmers:
      Dieter Praas            23
      Nabet, Julien           16
      锁琨珑                     11
      Heiko Tietze            10
      *UNKNOWN*               6
      Xisco Faulí             6
      Brinzing, Oliver        5
      m.a.riosv               4
      kompilainenn            4
      Timur                   3


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 1/40 -     2 %  (+0)
    5.3 : 0/54 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 5/244 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  +

    done by:
       Budea, Áron            11
       锁琨珑                     3
       Xisco Faulí             3
       NISZ LibreOffice Team   2
       Raal                    1
       Weghorn, Michael        1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  +

    done by:
       Budea, Áron            11
       Xisco Faulí             3
       NISZ LibreOffice Team   2
       锁琨珑                     1
       Raal                    1
       Weghorn, Michael        1


* all bugs tagged with 'regression'
  + 1138(+5) bugs open of 9292(+19) total 2(+0) high prio.

    done by:
       锁琨珑                     3
       Xisco Faulí             3
       Brinzing, Oliver        2
       m.a.riosv               2
       NISZ LibreOffice Team   2
       Dieter Praas            2
       Foote, V Stuart         1
       Henschel, Regina        1
       Robert Großkopf         1
       Raal                    1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    Calc          - 1(+0)
    UI            - 1(+0)

  by OS:
    All           - 1(+0)
    Linux         - 0(+0)
    Windows       - 0(+0)
    Mac OS X      - 1(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 313(-1)
    Calc                     - 225(+3)
    Impress                  - 128(-2)
    Writer: docx filter      - 71(+1)
    LibreOffice              - 64(+1)
    Draw                     - 45(+0)
    UI                       - 41(-1)
    Borders                  - 37(+0)
    Base                     - 34(+0)
    Writer: perf             - 33(+0)
    Crashes                  - 31(+0)
    Writer: other filter     - 30(+0)
    Writer: doc filter       - 29(+0)
    graphics stack           - 27(+0)
    filters and storage      - 23(+0)
    RTL                      - 23(+0)
    Printing and PDF export  - 20(-1)
    BASIC                    - 18(+0)
    Chart                    - 18(+1)
    framework                - 2(+0)
    sdk                      - 1(+0)
    Installation             - 1(+0)
    Extensions               - 1(+1)