On 20/01/2020 12:31, Guilhem Moulin wrote:
On Mon, 20 Jan 2020 at 10:50:34 +0100, Stephan Bergmann wrote:
But current
<https://gerrit.libreoffice.org/plugins/gitiles/gerrit-etc/+/refs/heads/master/mail/NewChange.vm>
still contains
[…]
(Oh, now that I spot the "patch from" vs. "patch by" difference, it is
obvious that those mails are not using the templates specified by the
gerrit-etc repo?)
Velocity mail templates are no longer used:
https://www.gerritcodereview.com/2.16.html#support-for-velocity-templates-removed
Had to manually convert them to Soy templates during the upgrade path,
and I guess I missed this line. Should be fixed now; IIRC there is no
need to reload/restart gerrit so the edit should be enough.
Yes, seen that working now, thanks.
And indeed gerrit-etc is no longer used either. Like for other
programs, gerrit's configuration files are now directly managed by salt
(our config management tool).
As discussed on IRC, would be nice to decommission that git repo then,
to avoid confusion.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.