ESC meeting minutes: 2019-12-19

Next meeting: 9th of January 2020, we’re skipping the next 2 weeks!

* Present:
    + Cloph, Michael W, Thorsten, Olivier, Heiko, Eike, Caolan, Ilmari, Miklos, Michael S, Xisco

* Completed Action Items:

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)
     + still waiting
   + make gnu make 4.0 a requirement on master (Michael S)

* Release Engineering update (Cloph)
   + 6.4 status
     + 6.4.0 rc1 is tagged, building
     + string freeze / feature freeze is over, libreoffice-6-4 now requires reviews!
     + Late features
       + ODF 1.3 possibly (Thorsten)
   + 6.3 status
     + 6.3.5 rc1 is end of January
   + Remotes
   + Android viewer
   + Online
     + libreoffice-6-4 branch is created

* Documentation (Olivier)
   * New Help
       + progress in Help Pages Editor
   * HelpContent2
       + Many updates/ housekeeping of pages (ohallot, S. Chaiklin. A timar, fitoshido, 
Libreofficiant)
   * Guides
      + Approaching final Calc Guide  6.2 revision
      + Revision 1 of LOOL Guide on going.


* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       234(234) (topicUI) bugs open, 250(250) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month    3 months   12 months
            added      3(-8)     19(-3)     40(-3)     102(-2)
        commented     53(-68)   330(-33)   854(8)     2396(22)
          removed      2(1)       4(2)       4(2)       15(1)
         resolved      7(-2)     35(-3)     85(-3)     225(1)
   + top 10 contributors:
         Heiko Tietze made 174 changes in 1 month, and 1000 changes in 1 year
         Timur made 86 changes in 1 month, and 154 changes in 1 year
         Xisco Faulí made 75 changes in 1 month, and 403 changes in 1 year
         Dieter Praas made 59 changes in 1 month, and 334 changes in 1 year
         Foote, V Stuart made 36 changes in 1 month, and 399 changes in 1 year
         kompilainenn made 22 changes in 1 month, and 283 changes in 1 year
         Muhammet Kara made 18 changes in 1 month, and 30 changes in 1 year
         Cor Nouws made 16 changes in 1 month, and 180 changes in 1 year
         Franklin Weng made 14 changes in 1 month, and 19 changes in 1 year
         Seth Chaiklin made 13 changes in 1 month, and 32 changes in 1 year

   + new needsUXEval Dec/12-19

     * Inserting of hyperlink into cell adds net address near text in cell
       instead adding a hyperlink to existing text in cell
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129493
     * Shape Styles
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129438
     * [UI] The term "table heading" should be "table header".
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129476
     => dup, wfm

     * Writer uses the last-used directory for opening and saving files,
       ignoring the setting in Options > Paths > My Documents
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129292
     * [UI] Improve slide ordering graphics in LO Impress
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129312
     * Rename PDF export option from "Full-sheet previews" to something another
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129417
     * Option to merge delimiters for text to table conversion
       (was: Text to Table: Option to add: Possibility to use all empty
      "spaces" in order to make TABLE from text)
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129338
  -> * Selection then Arrow-Move
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129426
     => no objections if somebody does the work (all)
     * Find and Replace for paragraph styles includes parent paragraph styles
       that are not in the Document
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129422
     => new

     * UI: Writer: illogical headers in Insert Bibliography Entry dialog
       + https://bugs.documentfoundation.org/show_bug.cgi?id=129444
     => fixed

* Crash Testing (Caolan)
   + 5(+0) import failure, 8(+0) export failures
   + 0 coverity issues, build in queue multiple days
   + 11 Google / ossfuzz issues, 2 crashes, both are fixed pending verify

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.8.2
        + (-23) 1172 1195 1082 973 815 568 375 320 198 0
    + https://crashreport.libreoffice.org/stats/version/6.3.2.2
        + (-601) 1962 2563 2578 2640 3124 3622 3487 4392 3950 3273 4801 1698 0
    + https://crashreport.libreoffice.org/stats/version/6.3.3.2
        + (-1066) 3302 4368 3674 3312 2629 1820 854 0
    + https://crashreport.libreoffice.org/stats/version/6.3.4.2
        + (+984) 984 0

    + Recent regressions without steps to reproduce

1. Since 6.3.4.2 -> Seems related to tdf#124270. Dennis ?
http://crashreport.libreoffice.org/stats/signature/ScRecursionHelper::PushFormulaGroup(ScFormulaCell%20*)
  + no steps to reproduce yet

2. https://crashreport.libreoffice.org/stats/signature/TypeDescriptor_Init_Impl::getMutex()
3.
https://crashreport.libreoffice.org/stats/signature/ScDocument::RemoveSubTotalCell(ScFormulaCell%20*)
4. Only linux
https://crashreport.libreoffice.org/stats/signature/SfxItemPool::GetFrozenIdRanges

* Hackfests & Events (Thorsten)
  + hope to have one each quarter.
  + plans for next year:
    + FOSDEM 2020
         + HackFest February 3rd and 4th, again probably in Beta Coworking (after FOSDEM)
      + devroom is approved, will be on Saturday
        + talks submitted: Caolan, Thorsten (will do the lightning), Ilmari,
          Kendy, Andras, Pedro, Michael, Heiko, Xisco
      + CMS room might be interesting too (Thorsten)

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + Ilmari cleaned up the ideas page regarding completed tasks
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
       + Please review the ideas for any obsolete ones
       + Would anyone want to mentor PPTX stuff like transitions or macro-related stuff? (Ilmari)

* mentoring/easyhack update
         committer...   1 week       1 month     3 months     12 months
                 open       65(-29)     131(-9)      138(-7)      148(-8)
              reviews     1661(-214)   6618(95)    15586(556)   55662(-48)
               merged      377(-115)   2064(-33)    5563(125)   17485(25)
            abandoned       17(-9)       99(3)       260(2)       865(3)
          own commits      282(-89)    1556(-49)    4688(119)   14619(-42)
       review commits      127(17)      430(61)     1127(102)    4194(12)
       contributor...   1 week     1 month      3 months   12 months
                 open      40(-1)      64(10)       65(10)     67(10)
              reviews     298(-75)   1108(114)    2451(89)   4683(167)
               merged      41(21)     103(22)      190(32)    893(7)
            abandoned       8(7)       24(-140)    186(6)     464(-4)
          own commits      44(24)     122(34)      250(57)    920(10)
       review commits       0(0)        0(0)         0(0)       0(0)
   + easyHack statistics:
      needsDevEval 6(6)   needsUXEval 1(1)   cleanup_comments 202(202)
      total 251(251)   assigned 6(6)   open 230(230)
   + top 10 contributors:
         Seth Chaiklin made 15 patches in 1 month, and 19 patches in 1 year
         LibreOfficiant made 14 patches in 1 month, and 86 patches in 1 year
         Corentin Noël made 8 patches in 1 month, and 9 patches in 1 year
         Weblate made 8 patches in 1 month, and 8 patches in 1 year
         Balazs Varga made 5 patches in 1 month, and 59 patches in 1 year
         Tünde Tóth made 3 patches in 1 month, and 37 patches in 1 year
         Ilmari Lauhakangas made 3 patches in 1 month, and 42 patches in 1 year
         Stepas Toliautas made 3 patches in 1 month, and 3 patches in 1 year
         Pranam Lashkari made 3 patches in 1 month, and 8 patches in 1 year
         Francis, Deena P. made 2 patches in 1 month, and 2 patches in 1 year
   + top 10 reviewers:
         Nabet, Julien made 207 review comments in 1 month, and 2351 in 1 year
         Xisco Faulí made 184 review comments in 1 month, and 1040 in 1 year
         Meeks, Michael made 164 review comments in 1 month, and 698 in 1 year
         Michael Stahl made 143 review comments in 1 month, and 1514 in 1 year
         McNamara, Caolán made 138 review comments in 1 month, and 1116 in 1 year
         Kaganski, Mike made 134 review comments in 1 month, and 784 in 1 year
         Grandin, Noel made 132 review comments in 1 month, and 1153 in 1 year
         Vajna, Miklos made 123 review comments in 1 month, and 1576 in 1 year
         Behrens, Thorsten made 118 review comments in 1 month, and 1573 in 1 year
         Bergmann, Stephan made 117 review comments in 1 month, and 1039 in 1 year
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Stepas Toliautas
         Yusuf Keten
         Desmin Alpaslan
         Kemal Ayhan
         Francis, Deena P.

* Commit Access
   + None

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
   + sleep -4 weeks

* Jenkins / CI update (Christian)
   from:Thu Dec 12 14:44:31 2019
   master linux rel  jobs:  64 ok:  60 ko:   4 fail ratio:  6.25 % break:   1 broken duration: 5.78%
   master linux dbg  jobs:  61 ok:  55 ko:   6 fail ratio:  9.84 % break:   2 broken duration: 5.90%
   master mac rel    jobs:  43 ok:  34 ko:   9 fail ratio: 20.93 % break:   3 broken duration: 8.04%
   master mac dbg    jobs:  46 ok:  39 ko:   7 fail ratio: 15.22 % break:   2 broken duration:15.93%
   master win rel    jobs:  76 ok:  66 ko:  10 fail ratio: 13.16 % break:   6 broken duration:14.85%
   master win dbg    jobs:  81 ok:  70 ko:  11 fail ratio: 13.58 % break:   8 broken duration:18.88%
   master win64 dbg  jobs:  78 ok:  65 ko:  13 fail ratio: 16.67 % break:   9 broken duration:14.17%
   master gerrit lin jobs: 579 ok: 459 ko:  84 fail ratio: 14.51% time for ok: mean:  20 median:  20
   master gerrit plg jobs: 500 ok: 356 ko: 107 fail ratio: 21.40% time for ok: mean:  29 median:  26
   master gerrit win jobs: 586 ok: 451 ko:  79 fail ratio: 13.48% time for ok: mean:  56 median:  57
   master gerrit mac jobs: 562 ok: 458 ko:  61 fail ratio: 10.85% time for ok: mean:  37 median:  23
   master gerrit all jobs: 501 ok: 308 ko: 125 fail ratio: 24.95% time for ok: mean:  87 median:  72
  + https://dev-www.libreoffice.org/tmp/gerrit_191219.html
  + tests that failed more than twice in last seven days:
     3 CppunitTest_sw_ooxmlexport5
     3 UITest_impress_demo
     5 CppunitTest_sw_uiwriter
     5 CppunitTest_writerperfect_writer
     8 CppunitTest_basic_macros

  + one of the Linux builders failed valid builds -> fixed

* Gerrit SSO (Cloph)
  + https://lists.freedesktop.org/archives/libreoffice/2019-December/083923.html
  + Switchover to ONLY TDF-SSO on Dec 25th
    other authentication methods will be removed
  + you will be locked out from your account if you don’t have TDF-account
    setup/infra will have to map it manually afterwards
  + Gerrit will be updated to 2.16
  + test instance: https://gerrit-stage.documentfoundation.org/

* l10n (Sophie)
  + weblate moved to final hardware
  + updated to 3.9.1
  + patched to allow translation propagation across projects
  + also created projects for the release branches
  + moved LO Online over, too (Cloph)
    + auto-push to gerrit
      + magic is: timeout after a few hours, currently set to 24h
      + if review is pending, it gets updated

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia: if you want to try it, export SAL_ENABLESKIA=1 on master (Miklos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
   + Lubos did GL-style GPU-backend text rendering on Windows this week

* docx/xlsx competitive marketing isues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs
  + unchanged from last week

* Possible workflow for subcomponents in Bugzilla (Ilmari)
  + Motivation is to move most of our meta bugs into the normal Bugzilla UI
  + Meta bug discoverability right now is horrible
  + Want to bring this up, so people can think of any problems or voice their objections - no 
intentions on moving forward any time soon
  + We could activate “Classifications” and shift our existing products and components upwards in 
the hierarchy
  + Would want components to be optional in the new system - might require patching
  + Pondered about this in more detail in a WONTFIXed BZ report: 
https://bugzilla.mozilla.org/show_bug.cgi?id=173133#c27
  + Red Hat BZ has subcomponents, but according to them, the implementation is so entangled with 
their patched system it is not realistic to separate it into an extension

  + please think about this, feedback welcome (Ilmari)
  + maybe we can investigate this in more detail at the FOSDEM hackfest (Xisco)
  + is it possible to get email notification for a component? (Michael W)
    + use that with metabugs
  + discoverability, how is it improved? (Heiko)
    + currently you have to do a query or go to the wiki (Ilmari)
    + with the proposed change, you would have everything in the bugzilla UI
    + see the RH bugzilla as an example on classification

* QA update (Xisco)
   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 546 (+11)
       + enhancements: 57  (-2)
       + needsUXEval: 0 (-5)
       + haveBackTrace: 1 (+1)
       + needsDevAdvice: 11 (-1)
       + documentation:  11 (+1)
       + android:  3 (-2)
       + iOS:  1 (+0)
       + Online:  12 (-1)


   + Most pressing bugs:
    New:
       + FILEOPEN: Some labels in charts are not displayed by default
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117088
           + Szymon?

    Old:
        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

        + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notorization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)
               + found out: not a regression, but it is from a user’s PoV

    Fixed:
        + Time required to export a large document has doubled for Latin (text layout issue)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=112989
            + Improved by Noel


   + New high severity bugs of the week:
       + menu bar is broken in RTL interface on Windows
           + https://bugs.documentfoundation.org/show_bug.cgi?id=127022
           + will look at it (Miklos)

       + Notebookbar context-Printpreview crash LO writer
           + https://bugs.documentfoundation.org/show_bug.cgi?id=129411
           + Muhammet?

       + Inserting image as background results in blue bg
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128449
           + Ashod?

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +148  -10 (-147) overall)
     many thanks to the top bug squashers:
      QA Administrators       17
      Xisco Faulí             14
      Michael Weghorn         12
      Caolán McNamara         6
      Tor Lillqvist           6
      Timur                   5
      Dieter Praas            5
      Heiko Tietze            5
      Buovjaga                5
      László Németh           4

   + top 10 bugs reporters:
      Nicolas Christener      18
      Xisco Faulí             8
      sdc.blanco              6
      DM                      4
      Mike Kaganski           3
      R. Green                3
      Roman Kuznetsov         3
      NISZ LibreOffice Team   3
      Chris Sherlock          2
      david.cortes.rivera     2

   + top 10 bugs fixers:
      McNamara, Caolán        6
      Lillqvist, Tor          6
      Xisco Faulí             4
      Balazs Varga            3
      Németh, László          3
      Kelemen, Gabor          3
      Michael Stahl           2
      Adolfo Jayme Barrientos 2
      Luboš Luňák             2
      Heiko Tietze            2

   + top 10 bugs confirmers:
      Xisco Faulí             39
      Nabet, Julien           14
      Heiko Tietze            12
      Dieter Praas            10
      Weghorn, Michael        5
      Timur                   5
      BogdanB                 4
      Brinzing, Oliver        4
      Raal                    3
      *UNKNOWN*               3


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 1/40 -     2 %  (+0)
    5.3 : 0/54 -     0 %  (-1)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 5/243 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  +

    done by:
       Xisco Faulí           14
       Raal                   4


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  +

    done by:
       Xisco Faulí           14
       Raal                   5


* all bugs tagged with 'regression'
  + 1143(-1) bugs open of 9166(+21) total 2(+0) high prio.

    done by:
       Xisco Faulí            13
       Timur                   1
       Nabet, Julien           1
       NISZ LibreOffice Team   1
       Dieter Praas            1
       kompilainenn            1
       m.a.riosv               1
       MM                      1
       Raal                    1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    Calc          - 1(+0)
    UI            - 1(+0)

  by OS:
    All           - 1(+0)
    Windows       - 0(+0)
    Mac OS X      - 1(+0)
    Linux         - 0(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 321(+3)
    Calc                     - 224(+0)
    Impress                  - 131(+0)
    Writer: docx filter      - 74(-1)
    LibreOffice              - 64(-2)
    Draw                     - 45(+0)
    Borders                  - 40(-2)
    UI                       - 40(+0)
    Base                     - 36(+1)
    Writer: perf             - 33(+0)
    Crashes                  - 33(+3)
    Writer: doc filter       - 32(+0)
    Writer: other filter     - 29(+0)
    graphics stack           - 26(-1)
    filters and storage      - 22(+0)
    RTL                      - 22(+0)
    Printing and PDF export  - 18(-1)
    Chart                    - 18(+0)
    BASIC                    - 18(+0)
    framework                - 2(+0)
    sdk                      - 1(+0)