Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index


Hi,
I'm trying to fix tdf#47065
<https://bugs.documentfoundation.org/show_bug.cgi?id=47065> as it's a
challenging *easyHack*. I have decided to move one step at a time in order
to resolve it at a slow and steady pace.
My first step is to find out a way to check if the lock from the previously
opened file is released and the file is now ready to use. In the change [1]
<https://gerrit.libreoffice.org/#/c/84919/4/sfx2/source/doc/docfile.cxx> ,
I have tried to check if the file lock has been disappeared, please let me
know if it is the right way to do it.  I also tested the change on my
local machine to see if it works.

I've made use of this expression:

*bool* bHandleSysLocked
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#bHandleSysLocked>
= ( bLoading 
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#bLoading>
&& bUseSystemLock
<https://opengrok.libreoffice.org/s?defs=bUseSystemLock&project=core>
&& !pImpl 
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#pImpl>->xStream
<https://opengrok.libreoffice.org/s?defs=xStream&project=core>.is
<https://opengrok.libreoffice.org/s?defs=is&project=core>() && !pImpl
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#pImpl>->m_pOutStream
<https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/docfile.cxx?r=cc4dbe47#m_pOutStream>
);


Also, when reviewing the change, please try to ignore the function and
variable names which were chosen arbitrarily..
Any given help is appreciated. Thanks!

--
Regards,
Aditya

[1] https://gerrit.libreoffice.org/#/c/84919/4/sfx2/source/doc/docfile.cxx

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.