ESC meeting minutes: 2019-10-10

* Present:
     + Caolan, Ilmari, Michael S, Heiko, Stephan, Miklos, Xisco, Olivier, Michael W, Gabriel, 
Cloph, Eike, Kendy

* Completed Action Items:
    + Improve the dev-tools python script for abandoned reviews (Xisco)
https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/commit/?id=ad2e9e582e1bbc9b1146cfe492b14b982425756e
    + filter out more Jenkins from the mentoring stats (Xisco)
https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/commit/?id=e31384ccc4c0eab44d9849fda18faa03bdfef51b
    + file remind ticket for “Big red warning on gerrit” wrt SSO (Xisco)
https://redmine.documentfoundation.org/issues/2995#change-17763

* Pending Action Items:
    + Collect summary / pictures for each GSoC project (Heiko)
      [ Some projects have text now, will be better for next week ]
      + draft: https://nextcloud.documentfoundation.org/s/XyMs94pqw5T44GW
      + still looking for input from everybody (except from Kendy and Heiko)

* Ilmari intro
  + just here to listen for now
  + doing Development Marketing for TDF

* Release Engineering update (Cloph)
    + 6.4 alpha: mid-October (week 42)
      + branch-off is planned for mid-November
    + 6.3.3 rc1 will be tagged this week (tomorrow)
    + 6.2.8 rc2 is tagged earlier today
    + macOS Catalina (10.15) problem, signatures seem to not work anymore
      + cmdline output is OK, notarization doesn’t show any errors
      + perhaps will switch the builder machines to investigate
    + Remotes
    + Android viewer
    + Online
    + daily builds status
      + Linux solved completely
      + Windows / macOS is solved completely as well

* Documentation (Olivier)
    + New Help
        + refactor CSS for online in new server configuration (ohallot)
    + Helpcontent2
        + Page maintenance (ohallot, M. Kaganski, K Yoshida)
    + Google Season of Doc
        + Ongoing book for Online
    + Guides
        + Ongoing


* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        230(230) (topicUI) bugs open, 236(236) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month    3 months   12 months
             added      3(3)     18(18)     46(46)      98(98)
         commented     61(61)   265(265)   800(800)   1964(1964)
           removed      0(0)      0(0)       0(0)       17(17)
          resolved      8(8)     33(33)     90(90)     185(185)
    + top 10 contributors:
          Heiko Tietze made 158 changes in 1 month, and 639 changes in 1 year
          Foote, V Stuart made 77 changes in 1 month, and 344 changes in 1 year
          Kainz, Andreas made 74 changes in 1 month, and 254 changes in 1 year
          Thomas Lendo made 47 changes in 1 month, and 323 changes in 1 year
          Cor Nouws made 39 changes in 1 month, and 172 changes in 1 year
          Dieter Praas made 37 changes in 1 month, and 217 changes in 1 year
          Xisco Faulí made 33 changes in 1 month, and 317 changes in 1 year
          *UNKNOWN* made 25 changes in 1 month, and 27 changes in 1 year
          Roman Kuznetsov made 21 changes in 1 month, and 275 changes in 1 year
          *UNKNOWN* made 15 changes in 1 month, and 15 changes in 1 year

    + New tickets with needsUXEval Oct/04-10

      * form exported as pdf does not embed all required fonts
        + https://bugs.documentfoundation.org/show_bug.cgi?id=50879
      * Cannot use Highlight Color (Yellow) with keyboard shortcut
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128052
      * conditional text in header/footer fields turned static
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128041
      => in discussion

  ->  * OPTIONS DIALOG: Impossibility to assign a precise tab stop and other
        values in mm
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128055
  ->  * Can't scale Equation Box when typing the equation
        + https://bugs.documentfoundation.org/show_bug.cgi?id=127956
      * Bullets once toggled in impress, do not toggle back.
        + https://bugs.documentfoundation.org/show_bug.cgi?id=127541
      * UI: Typeface and style names are not fully readable in GTK3
        + https://bugs.documentfoundation.org/show_bug.cgi?id=127406
      => NEW

  ->  * SharePoint integration for easy revision comparison
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128033
      * Font Awesome
        + https://bugs.documentfoundation.org/show_bug.cgi?id=127983
      * Please rename "Show formatting marks" to something correct!
        + https://bugs.documentfoundation.org/show_bug.cgi?id=127954
      => WF/WFM

      * CUSTOMIZE DIALOG: why is KEY_EQUAL not available for assignment to
        keyboard shortcuts
        + https://bugs.documentfoundation.org/show_bug.cgi?id=127903
      => FIXED

* Crash Testing (Caolan)
    + 4(+0) import failure, 2(+0) export failures
      + Dennis working on a Calc problem
      + Writer redline split problem (Laszlo)
    + 31(+0,-9) coverity issues
    + 14(+2,-6) ossfuzz issues

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.6.2
        + (+88) 445 357 310 364 507 509 311 246 12 0
    + https://crashreport.libreoffice.org/stats/version/6.2.7.1
        + (+1172) 2481 1309 959 673 186 0
    + https://crashreport.libreoffice.org/stats/version/6.3.0.4
        + (+60) 5401 5341 5370 5708 7000 6967 6267 4942 2052 0
    + https://crashreport.libreoffice.org/stats/version/6.3.1.2
        + (+710) 3406 2696 2886 2262 820 0
    + https://crashreport.libreoffice.org/stats/version/6.3.2.2
        + (+3103) 4801 1698 0
    + Huge increase in all versions due to jscript.dll
        + Combination of HP printer driver version and some MS update related to jscript, that 
don't co-exist (Mike K.) → NOTOURBUG

* Hackfests & Events (Thorsten)
   + hope to have one each quarter.
   + Google Mentor summit happening in Europe end of October
       + Michael & Thorsten going there
   + plans for next year:
     + FOSDEM 2020
       + devroom is approved, will be on Saturday

* mentoring/easyhack update
          committer...   1 week       1 month      3 months       12 months
                  open       71(71)      124(124)      132(132)       145(145)
               reviews     1562(1562)   4635(4635)   14198(14198)   54677(54677)
                merged      425(425)    1640(1640)    4597(4597)    16730(16730)
             abandoned       17(17)       79(79)       211(211)       874(874)
           own commits      492(492)    1314(1314)    3692(3692)    14721(14721)
        review commits      157(157)     297(297)     1023(1023)     4243(4243)
        contributor...   1 week     1 month    3 months     12 months
                  open      11(11)     26(26)      27(27)       28(28)
               reviews     223(223)   952(952)   1980(1980)   3357(3357)
                merged      60(60)     92(92)     223(223)     780(780)
             abandoned       4(4)      14(14)     145(145)     341(341)
           own commits      64(64)     95(95)     249(249)    1014(1014)
        review commits       0(0)       0(0)        0(0)         0(0)
    + easyHack statistics:
       needsDevEval 6(6)   needsUXEval 1(1)   cleanup_comments 195(195)
       total 242(242)   assigned 5(5)   open 220(220)
    + top 10 contributors:
          Pedro Pinto da Silva made 52 patches in 1 month, and 53 patches in 1 year
          Tünde Tóth made 7 patches in 1 month, and 29 patches in 1 year
          Balazs Varga made 5 patches in 1 month, and 50 patches in 1 year
          LibreOfficiant made 4 patches in 1 month, and 54 patches in 1 year
          Szabolcs Tóth (NISZ) made 3 patches in 1 month, and 7 patches in 1 year
          himajin100000 made 3 patches in 1 month, and 24 patches in 1 year
          Shivansh made 2 patches in 1 month, and 9 patches in 1 year
          DrRobotto made 2 patches in 1 month, and 13 patches in 1 year
          Scott Clarke made 2 patches in 1 month, and 12 patches in 1 year
          shubham goyal made 1 patches in 1 month, and 35 patches in 1 year
    + top 10 reviewers:
          Vajna, Miklos made 148 review comments in 1 month, and 1524 in 1 year
          Kłos, Szymon made 145 review comments in 1 month, and 345 in 1 year
          Grandin, Noel made 122 review comments in 1 month, and 1164 in 1 year
          Timar, Andras made 108 review comments in 1 month, and 1172 in 1 year
          Michael Stahl made 103 review comments in 1 month, and 1434 in 1 year
          Nabet, Julien made 99 review comments in 1 month, and 2314 in 1 year
          Holešovský, Jan made 98 review comments in 1 month, and 802 in 1 year
          Bergmann, Stephan made 94 review comments in 1 month, and 1027 in 1 year
          Kaganski, Mike made 88 review comments in 1 month, and 736 in 1 year
          Behrens, Thorsten made 87 review comments in 1 month, and 1628 in 1 year
    + Patches automatically abandoned:
        tdf#126742: sc: GetVisArea is the same for normal and embedded mode. ( Vasily Melenchuk )
            - https://gerrit.libreoffice.org/#/c/77002
        ODF-imported textboxes identify themselves as such ( Katarina Behrens )
            - https://gerrit.libreoffice.org/#/c/77103
            - restored already
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          - Christian Barth
          - Dennis Schridde

* Commit Access
    + None

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + sleep 0 weeks
    + AI: run the script (Kendy)

* Jenkins / CI update (Christian)
    from:Thu Oct  3 13:52:33 2019
    master linux rel  jobs: 192 ok: 192 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master linux dbg  jobs:  71 ok:  69 ko:   2 fail ratio:  2.82 % break:   2 broken duration: 
4.81%
    master mac rel    jobs:  11 ok:  10 ko:   1 fail ratio:  9.09 % break:   1 broken duration: 
0.00%
    master mac dbg    jobs:  12 ok:  12 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master win rel    jobs:  89 ok:  83 ko:   6 fail ratio:  6.74 % break:   6 broken duration: 
5.20%
    master win dbg    jobs: 102 ok:  95 ko:   7 fail ratio:  6.86 % break:   5 broken duration: 
8.68%
    master win64 dbg  jobs: 100 ok:  88 ko:  12 fail ratio: 12.00 % break:   9 broken 
duration:10.94%
    lo-5.3 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    lo-5.4 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master gerrit lin jobs: 570 ok: 368 ko:   7 fail ratio:  1.23% time for ok: mean:  25 median:  
25
    master gerrit plg jobs: 568 ok: 361 ko:  96 fail ratio: 16.90% time for ok: mean:  34 median:  
32
    master gerrit win jobs: 573 ok: 339 ko:  96 fail ratio: 16.75% time for ok: mean:  57 median:  
59
    master gerrit mac jobs: 567 ok: 367 ko:  39 fail ratio:  6.88% time for ok: mean:  50 median:  
29
    master gerrit all jobs: 555 ok: 295 ko: 161 fail ratio: 29.01% time for ok: mean: 145 median: 
118
   + https://dev-www.libreoffice.org/tmp/gerrit_191010.html
   + tests that failed more than twice in last seven days:
      3 CppunitTest_sw_uwriter
      3 CppunitTest_xmloff_uxmloff
      3 UITest_demo_ui
      4 UITest_writer_tests
      5 CppunitTest_sw_mailmerge
   + 3 disconnected macs caused some larger queue, fixed now

* l10n (Sophie)
   + weblate instance status: still discovering, feedback collection
   + already migrated from pootle for master, 6.3 may or may not be migrated
   + pondering also importing the old history, not sure if it will be worth it

* TDF-SSO for gerrit (cloph)
   + gerrit was updated to use TDF-accounts
     https://lists.freedesktop.org/archives/libreoffice/2019-September/083474.html
   + old login methods will be deprecated/switch to TDF-SSO is prerequisite
     for updating to current version of gerrit
   + please link accounts using Settings → Identities → Link Another Identity
   + Will be a hard requirement later this year

* Graphics architecture (Thorsten)
  * https://pad.documentfoundation.org/p/ESC_graphics_architecture
  * skia status: see the updated private/llunak/skia branch in core.git (Miklos)
    + after Linux polygons/bitmaps/text, initial Windows bits

* QA update (Xisco)
    + Please help flesh out the monthly reports:
          https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 578 (-5)
        + enhancements: 70  (-1)
        + needsUXEval: 6 (-3)
        + haveBackTrace: 4 (-1)
        + needsDevAdvice: 14 (+0)
        + documentation:  7 (-2)
        + android:  16 (+0)
        + iOS:  3 (+1)
        + Online:  12 (+0)
    + Most pressing bugs:
     New:
        [none]
     Old:
       + After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notorization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)
               + found out: not a regression, but it is from a user’s PoV

       + button flashing - mouse wheel zooming breaks
           + https://bugs.documentfoundation.org/show_bug.cgi?id=121963
               + Armin ?
     Fixed:
        + Crash when linking an odp file
            + https://bugs.documentfoundation.org/show_bug.cgi?id=128013
                + Thansk to Julien Nabet

    + New high severity bugs of the week:
        + EDITING: Paste stops working after several copy-paste (steps: comment 28)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=57147
            + Not a regression

        + main menu and context menus empty when using form elements and OpenGL
            + https://bugs.documentfoundation.org/show_bug.cgi?id=127910
            + Would be great to bisect this


* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +122  +43 (-159) overall)
      many thanks to the top bug squashers:
       QA Administrators       29
       Buovjaga                17
       Xisco Faulí             15
       Caolán McNamara         13
       Heiko Tietze            7
       NISZ LibreOffice Team   7
       V Stuart Foote          5
       Timur                   5
       Tünde Tóth              5
       Eike Rathke             4

    + top 10 bugs reporters:
       Nicolas Christener      8
       Xisco Faulí             6
       Mike Kaganski           6
       andreas_k               5
       Roman Kuznetsov         4
       NISZ LibreOffice Team   3
       Buovjaga                2
       Thomas Lendo            2
       LibreOfficiant            2
       severin.kunz            2

    + top 10 bugs fixers:
       McNamara, Caolán        13
       Tünde Tóth              5
       Xisco Faulí             4
       NISZ LibreOffice Team   4
       Rathke, Eike            3
       Heiko Tietze            3
       Balazs Varga            3
       Lillqvist, Tor          2
       Grandin, Noel           2
       Németh, László          2

    + top 10 bugs confirmers:
       Xisco Faulí             38
       Heiko Tietze            11
       Brinzing, Oliver        10
       dieterp                 9
       Nabet, Julien           8
       McNamara, Caolán        5
       Foote, V Stuart         3
       Raal                    3
       *UNKNOWN*               3
       Rathke, Eike            3


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/52 -     1 %  (+0)
     5.4 : 1/40 -     2 %  (+0)
     5.3 : 0/53 -     0 %  (+0)
     5.2 : 1/44 -     2 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 1/76 -     1 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 2/133 -    1 %  (+0)
     4.1 : 1/83 -     1 %  (+0)
     4.0 : 3/82 -     3 %  (+0)
     old : 5/243 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 693/3601 690/3582 686/3562 673/3539 673/3534 667/3506 672/3500

     done by:
        Xisco Faulí           11
        Raal                   3
        Budea, Áron            1
        Weghorn, Michael       1
        Justin L               1
        Brinzing, Oliver       1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 865/4421 864/4401 859/4378 846/4353 849/4348 845/4320 852/4315

     done by:
        Xisco Faulí           12
        Raal                   4
        Budea, Áron            1
        Weghorn, Michael       1
        Brinzing, Oliver       1


* all bugs tagged with 'regression'
   + 1146(+1) bugs open of 8911(+34) total 3(-2) high prio.

     done by:
        Xisco Faulí           13
        Brinzing, Oliver       4
        Timur                  3
        Alex Thurgood          2
        dieterp                2
        m.a.riosv              2
        Pierre C               1
        Dan K                  1
        Rathke, Eike           1
        Roman Kuznetsov        1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Calc          - 2(+0)
     UI            - 1(+0)
     Writer        - 0(-1)
     LibreOffice   - 0(-1)

   by OS:
     All           - 2(-2)
     Linux         - 0(+0)
     Mac OS X      - 1(+0)
     Windows       - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 307(+1)
     Calc                     - 229(+0)
     Impress                  - 125(+3)
     Writer: docx filter      - 82(+0)
     LibreOffice              - 70(-2)
     Draw                     - 44(+0)
     UI                       - 41(-1)
     Borders                  - 40(+0)
     Base                     - 36(+0)
     Writer: doc filter       - 35(+0)
     Writer: perf             - 34(+0)
     Writer: other filter     - 29(+0)
     Crashes                  - 29(-2)
     graphics stack           - 25(+0)
     filters and storage      - 24(+1)
     RTL                      - 22(+0)
     Printing and PDF export  - 19(+1)
     Chart                    - 18(+1)
     BASIC                    - 17(+0)
     framework                - 2(+0)
     sdk                      - 1(+0)
     Linguistic               - 1(+0)
     Formula Editor           - 0(-1)