ESC meeting minutes: 2019-09-11

* Present:
     + Kendy, Stephan, Caolan, Michael M, Cloph, Miklos, Thorsten, Michael W, Lionel, Xisco, Eike, 
Bjoern, Gabriel

* Completed Action Items:
    + backport the hsqldb/firebird patch to 6.3 (Xisco)

* Pending Action Items:
    + None

* Release Engineering update (Christian)
    + 6.4 alpha: mid-October
    + 6.3.2 RC2 will be tagged next week
    + 6.2.8 RC1: in 2 weeks
    + Remotes
    + Android viewer
       + uploading a 64bit version – the new requirement
         + have a patch working, but NSS needs more love, in progress
       + arm / master crashes on every file operation → pending
    + Online
    + daily builds status
      + Linux solved completely
      + Windows / macOS needs integration into Jenkins
        + freedesktop anongit was offline → affected some tinderboxes
        + Thorsten: new Windows tinderbox, supposed to provide daily builds
          + blocked on packaging, but should be fixed now (Cloph)
        + other mirrors? (Michael)
          + we also have launchpad and github (Cloph)

* Documentation (Olivier)
  + maintenance & translation work continues for 6.3
  + more developments for the new help, but not yet ready
  + Google Seans of Docs: work of technical writer started, progressing


* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        235(235) (topicUI) bugs open, 227(227) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months
             added       9(3)     25(-3)    45(-6)      97(2)
         commented     102(34)   301(28)   738(34)    1832(71)
           removed       0(0)      0(0)      1(0)       18(0)
          resolved       9(2)     27(0)     66(6)      167(6)
    + top 10 contributors:
          Heiko Tietze made 189 changes in 1 month, and 493 changes in 1 year
          Thomas Lendo made 93 changes in 1 month, and 326 changes in 1 year
          Buovjaga made 43 changes in 1 month, and 85 changes in 1 year
          Foote, V Stuart made 43 changes in 1 month, and 296 changes in 1 year
          Dieter Praas made 35 changes in 1 month, and 181 changes in 1 year
          Xisco Faulí made 20 changes in 1 month, and 297 changes in 1 year
          Pedro Pinto da Silva made 17 changes in 1 month, and 17 changes in 1 year
          Kainz, Andreas made 17 changes in 1 month, and 189 changes in 1 year
          Cor Nouws made 15 changes in 1 month, and 145 changes in 1 year
          Nabet, Julien made 12 changes in 1 month, and 35 changes in 1 year

   * Impress crashes by changing the symbol of a bulleted list
     + https://bugs.documentfoundation.org/show_bug.cgi?id=127450
   * Choosing versions other than current version when opening file from inside LO doesn't work
     + https://bugs.documentfoundation.org/show_bug.cgi?id=127492
   …
    + UX on hold, expect updates next week

* Crash Reporting (Caolan)
    + 2(+0) import failure, 2(+0) export failures
    + 35 coverity issues
    + Google / ossfuzz: fuzzers active now
    + CVE-2019-9854, CVE-2019-9855
      + macro now warns even on script invocation, not when providing scripts in documents, should 
help in the long run

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.5.2
        + (-86) 2280 2366 2188 1865 1808 3000 2274 748 0
    + https://crashreport.libreoffice.org/stats/version/6.2.6.2
        + (-2) 507 509 311 246 12 0
    + https://crashreport.libreoffice.org/stats/version/6.2.7.1
        + (+186) 186 0
    + https://crashreport.libreoffice.org/stats/version/6.3.0.4
        + (+33) 7000 6967 6267 4942 2052 0
    + https://crashreport.libreoffice.org/stats/version/6.3.1.2
        + (+820) 820 0
        + lots of Calc dynamic column-related crashes fixed, thanks Noel


* Hackfests & Events (Sophie)
    + Google Mentor summit happening in Europe end of October
       + could be a fall-back for European meetup
       + Cafe Netzwerk / CIB office or something.
       + one slot for Mentor Summit available
       + call for Munich volunteers to organize something around this?
         (Thorsten)
          + https://wiki.documentfoundation.org/Hackfest/Muenchen2019
         + Mentor summit is Oct. 19th-20th, something around that weekend
           would be perfect
         + suggestion to have a small hackfest in Munich, before or after the
           GSoC summit,
           + proposal either before: 17/18th of Oct
               + works better for Michael W.
           + or after: 24/25th  of Oct
               + works better for Heiko
           + Heiko setting up a wiki page for this
               + <url>
           + interested if there are at least 10 attendees (Thorsten)
   + hope to have one each quarter.

* GSOC 2019 (Thorsten/Xisco/Moggi/Heiko)
   + Project page:
    https://summerofcode.withgoogle.com/organizations/5557591040589824/
   + Mentor Summit: Michael M & Thorsten going, event is Oct 19th and 20th in             Munich
   + 100% success rate this time
   + wrap-up blogpost would be great
   + GSoC panel:
     + mentors: if your student is not coming, please send slides to Thorsten later today
     + ideally mentors present work of missing students
     + big thanks to all mentors & students (Kendy)

* mentoring/easyhack update
          committer...   1 week      1 month      3 months      12 months
                  open      74(13)      124(15)       131(15)       142(15)
               reviews     934(-359)   4848(-491)   14819(-469)   53729(-306)
                merged     198(-197)   1447(-79)     4383(-140)   16146(-97)
             abandoned      17(5)        61(0)        222(2)        851(6)
           own commits     133(-131)   1078(-135)    3331(-123)   14699(-206)
        review commits      44(-40)     358(-78)     1121(-67)     4152(-30)
        contributor...   1 week      1 month    3 months   12 months
                  open       6(-1)      24(-6)      27(-6)     28(-6)
               reviews     155(-135)   761(-68)   1439(30)   3070(9)
                merged      13(-1)      71(-8)     194(8)     899(-14)
             abandoned       2(-3)      22(0)      161(-5)    359(-3)
           own commits      12(-6)      76(-17)    207(6)     961(-1)
        review commits       0(0)        0(0)        0(0)       0(0)
    + easyHack statistics:
       needsDevEval 6(6)   needsUXEval 0(0)   cleanup_comments 195(195)
       total 241(241)   assigned 6(6)   open 220(220)
    + top 10 contributors:
          shubham goyal made 8 patches in 1 month, and 34 patches in 1 year
          Balazs Varga made 8 patches in 1 month, and 49 patches in 1 year
          LibreOfficiant made 8 patches in 1 month, and 50 patches in 1 year
          Tünde Tóth made 7 patches in 1 month, and 23 patches in 1 year
          Adrien Ollier made 5 patches in 1 month, and 20 patches in 1 year
          Scott Clarke made 5 patches in 1 month, and 10 patches in 1 year
          Shivansh made 4 patches in 1 month, and 7 patches in 1 year
          Sumit Chauhan made 2 patches in 1 month, and 23 patches in 1 year
          DrRobotto made 2 patches in 1 month, and 11 patches in 1 year
          nd101 made 2 patches in 1 month, and 6 patches in 1 year
    + top 10 reviewers:
          Jenkins CollaboraOffice made 463 review comments in 1 month, and 876 in 1 year
          Nabet, Julien made 324 review comments in 1 month, and 2343 in 1 year
          Michael Stahl made 170 review comments in 1 month, and 1410 in 1 year
          McNamara, Caolán made 147 review comments in 1 month, and 1190 in 1 year
          Timar, Andras made 123 review comments in 1 month, and 1118 in 1 year
          Behrens, Thorsten made 111 review comments in 1 month, and 1650 in 1 year
          Bergmann, Stephan made 110 review comments in 1 month, and 995 in 1 year
          Adolfo Jayme Barrientos made 105 review comments in 1 month, and 967 in 1 year
          Xisco Faulí made 102 review comments in 1 month, and 941 in 1 year
          Vajna, Miklos made 91 review comments in 1 month, and 1456 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:

* Commit Access
    + None

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + sleep 4 weeks

* Jenkins / CI update (Christian)
  + nothing worth noting

* l10n (Sophie)
   + weblate instance is in live testing period
       + people using it & reporting inconveniences (Christian)
       + will have a talk on Friday morning, summarize feedback
       + in short, we will likely switch to weblate

* QA update (Xisco)

    + Please help flesh out the monthly reports:
          https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 560 (+28)
        + enhancements: 63  (+1)
        + needsUXEval: 3 (+3)
        + haveBackTrace: 3 (+0)
        + needsDevAdvice: 15 (+0)
        + documentation:  7 (+3)
        + android:  14 (+0)
        + iOS:  6 (+0)
        + Online:  14 (-1)
    + Most pressing bugs:
     New:
                [None]
     Old:

       + After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notorization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)

       + button flashing - mouse wheel zooming breaks
           + https://bugs.documentfoundation.org/show_bug.cgi?id=121963
               + Armin ?
        + CRASH: Closing LibreOffice after deleting a chart
            + https://bugs.documentfoundation.org/show_bug.cgi?id=127306
                + Samuel ?


    + New high severity bugs of the week:
        + Impress crashes by changing the symbol of a bulleted list
            + https://bugs.documentfoundation.org/show_bug.cgi?id=127450
        + Continue Previous Numbering Does Not Find Previous Number and Starts at 1. Again
            + https://bugs.documentfoundation.org/show_bug.cgi?id=122027
        + TABLES : jumps on selecting text in table in big cell on neighboring pages
            + https://bugs.documentfoundation.org/show_bug.cgi?id=49994
        + When creating a query in design view using MySQL, the Add Tables dialog only displays 
tables from, and allows interaction with, the first alphabetically sorted schema
            + https://bugs.documentfoundation.org/show_bug.cgi?id=127343


Questions from the audience
  + Ashod: configuration manager, does it need a re-design?
    + it was already re-written ~10 years ago (Stephan)
    + feature: configuration setting changes → notification → e.g. UI reacts
      + configmgr is just 1 piece of the puzzle (Stephan)
      + almost nobody reacts to those events (Michael)
    + Other example: How do we manage re-visiting major components, if they need some major 
investment. As going forward, a piece of code gets more and more messy. How do we deal with this 
problem?
      + we do quite well on that end (Stephan)
        + there are areas which are only in maintenance, but if somebody comes and wants to invest 
energy, that’s possible
        + sometimes a tender helps, sometimes not
        + some other areas are better maintained
        + no area is really totally hopeless (Stephan)
          + you can always ask, usually somebody has an answer or guess
          + proactive re-design may not be useful
        + nobody writes documentation, but not convinced that it gets better with money
    + some overview documentation would be helpful (Michael)
      + Chris S. started doing that in the past
    + if you deal with a large corpus of legacy code, the answer is always: write more tests 
(Bjoern)
      + if it was a design decision, then write a test to cover it
      + test is kind of a documentation
    + if you don’t understand it, you want to rewrite it (Thorsten)
      + but to rewrite it, first you have to understand it or you won’t do a better job
      + we’re under-resourced anyway
    + it does happen: VCL ui migration, welding, Calc core rewrite (Michael)
      + when there is a real-world need for that
  + Mike: regarding possible contributors, doing a drive-by contribution: why do they need a 
non-github account?
      + bugzilla, gerrit
      + could we have SSO?
        + you could already use your github account to log into gerrit (or google one) (Cloph)
      + create a change using a web ui?
        + you can create a change in gerrit (Cloph)
        + it works the other way around: first you create a bugzilla bug, then you refer to that in 
your gerrit change (Cloph)
        + bottleneck is mentoring / review part in many cases (Thorsten)
      + also: please file easy hacks (Kendy)
        + we’re running out of good easy hacks
      + most painful part: getting used to gerrit (Bjoern)
        + perhaps regularly re-visit if gerrit is the right tool for our needs
        + email a patch – that still could work…
        + could talk to gnome/kde and ask how gitlab works for them
    + newcomers are also not used to IRC (Xisco)
      + have nothing against it personally, though

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +157  -29 (-163) overall)
      many thanks to the top bug squashers:
       QA Administrators       20
       Xisco Faulí             14
       Timur                   14
       Heiko Tietze            12
       László Németh           10
       Regina Henschel         9
       V Stuart Foote          6
       Caolán McNamara         6
       Julien Nabet            5
       Gabor Kelemen           5

    + top 10 bugs reporters:
       NISZ LibreOffice Team   9
       nd101                   8
       Thomas Lendo            7
       Regina Henschel         6
       LE GARREC Vincent       3
       Heiko Tietze            3
       Gerhard Weydt           3
       Rizal Muttaqin          3
       Michael Weghorn         3
       Tamás Zolnai            2

    + top 10 bugs fixers:
       Németh, László          10
       Adolfo Jayme Barrientos 7
       Henschel, Regina        5
       Heiko Tietze            5
       McNamara, Caolán        5
       Weghorn, Michael        4
       Zolnai, Tamás           4
       Rathke, Eike            2
       Xisco Faulí             2
       Michael Stahl           2

    + top 10 bugs confirmers:
       Xisco Faulí             25
       Heiko Tietze            13
       Dieter Praas            11
       Foote, V Stuart         8
       Alex Thurgood           8
       Nabet, Julien           6
       m.a.riosv               5
       Roman Kuznetsov         5
       Brinzing, Oliver        5
       Weghorn, Michael        4


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/52 -     1 %  (+0)
     5.4 : 1/40 -     2 %  (+0)
     5.3 : 0/53 -     0 %  (+0)
     5.2 : 1/44 -     2 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 1/76 -     1 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 2/133 -    1 %  (+0)
     4.1 : 1/83 -     1 %  (+0)
     4.0 : 4/83 -     4 %  (+0)
     old : 6/244 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 670/3534 669/3516 671/3502 662/3483 665/3467 667/3443 658/3430

     done by:
        Xisco Faulí            11
        NISZ LibreOffice Team   6
        Weghorn, Michael        3
        Raal                    2
        Budea, Áron             1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 845/4348 847/4330 851/4317 842/4298 845/4281 848/4257 839/4244

     done by:
        Xisco Faulí            11
        NISZ LibreOffice Team   6
        Weghorn, Michael        3
        Raal                    2
        Budea, Áron             1


* all bugs tagged with 'regression'
   + 1119(-4) bugs open of 8810(+23) total 4(+0) high prio.

     done by:
        NISZ LibreOffice Team   7
        Xisco Faulí             5
        Timur                   3
        Alex Thurgood           3
        Foote, V Stuart         2
        Weghorn, Michael        2
        Brinzing, Oliver        1
        MM                      1
        m.a.riosv               1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Calc          - 2(+0)
     Writer        - 1(+0)
     UI            - 1(+0)

   by OS:
     Windows       - 0(+0)
     All           - 3(+0)
     Linux         - 0(+0)
     Mac OS X      - 1(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 295(-1)
     Calc                     - 223(-3)
     Impress                  - 115(-1)
     Writer: docx filter      - 78(+3)
     LibreOffice              - 71(-3)
     Draw                     - 44(-1)
     UI                       - 43(+0)
     Borders                  - 39(+0)
     Base                     - 37(+0)
     Writer: doc filter       - 36(+0)
     Writer: perf             - 34(+0)
     Writer: other filter     - 30(+0)
     Crashes                  - 28(+1)
     graphics stack           - 26(+0)
     filters and storage      - 25(+0)
     RTL                      - 22(+0)
     BASIC                    - 18(+1)
     Printing and PDF export  - 17(+0)
     Chart                    - 15(+0)
     framework                - 2(+0)
     Formula Editor           - 1(+0)
     Linguistic               - 1(+0)
     sdk                      - 1(+0)