Dear Michael, On 12.08.19 11:07, Michael Stahl wrote:
On 12.08.19 02:01, Paul Menzel wrote:On 12.08.19 00:05, Thorsten Behrens wrote:Paul Menzel wrote:Building LibreOffice 6.3.0.4 with `DISPLAY=` (unset) the test below fails. ```Can you run bin/odfvalidator.sh successfully from the shell? Possibly it does not find the right JRE (>=1.8).$ chmod +x bin/odfvalidator.sh $ ./bin/odfvalidator.sh -V odfvalidator v1.1.4libreoffice-6-3 branch contains the following commit, but it is missing in the 6.3.0.4 release. please apply it, it should give a better error message; if you still don't see any reason why the validator fails it's probably because the JVM doesn't even start. commit 53ca96a5e0a77cd077f9b5690302d10faf8c5247 Author: Michael Stahl <Michael.Stahl@cib.de> AuthorDate: Fri Jul 19 18:12:23 2019 +0200 test: check validator exit code *after* checking validator output ODF validator may now actually exit with non-0 since commit b14e2f6c63c18894286c99ee8dde9070e24b41c2 - look for validation errors in this case too.
After applying the patch, I see the results below.
```
$ make -j1 # still uses all threads though :(
[…]
make[1]: ***
[/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/solenv/gbuild/CppunitTest.mk:113:
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/build/workdir/CppunitTest/sc_filters_test.test]
Error 1
Exception in thread "main" java.lang.NullPointerException
at org.odftoolkit.odfvalidator.ODFValidator.getValidatorForSchema(ODFValidator.java:286)
at org.odftoolkit.odfvalidator.ODFValidator.getManifestValidator(ODFValidator.java:186)
at
org.odftoolkit.odfvalidator.ODFRootPackageValidator.validateManifest(ODFRootPackageValidator.java:170)
at
org.odftoolkit.odfvalidator.ODFRootPackageValidator.validatePre(ODFRootPackageValidator.java:93)
at org.odftoolkit.odfvalidator.ODFPackageValidator._validate(ODFPackageValidator.java:111)
at org.odftoolkit.odfvalidator.ODFPackageValidator.validate(ODFPackageValidator.java:81)
at org.odftoolkit.odfvalidator.ODFValidator.validateFile(ODFValidator.java:163)
at org.odftoolkit.odfvalidator.ODFValidator.validate(ODFValidator.java:125)
at org.odftoolkit.odfvalidator.Main.main(Main.java:314)
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/test/source/bootstrapfixture.cxx:233:SdImportTest::testDocumentLayout
equality assertion failed
- Expected: 0
- Actual : 256
- failed to execute: sh
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/build/bin/odfvalidator.sh -M
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng
-D
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-dsig-schema-v1.3+libreoffice.rng
-O
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng
-m /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/mathml2/mathml2.xsd
/tmp/lu167058k4jf7.tmp > /tmp/lu167058k4jfc.tmp
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng:
Fatal:
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng:
file does not exist
SdImportTest::testDocumentLayout finished in: 19355ms
[…]
[CHK] sfx2
Exception in thread "main" java.lang.NullPointerException
at org.odftoolkit.odfvalidator.ODFValidator.getValidatorForSchema(ODFValidator.java:286)
at org.odftoolkit.odfvalidator.ODFValidator.getManifestValidator(ODFValidator.java:186)
at
org.odftoolkit.odfvalidator.ODFRootPackageValidator.validateManifest(ODFRootPackageValidator.java:170)
at
org.odftoolkit.odfvalidator.ODFRootPackageValidator.validatePre(ODFRootPackageValidator.java:93)
at org.odftoolkit.odfvalidator.ODFPackageValidator._validate(ODFPackageValidator.java:111)
at org.odftoolkit.odfvalidator.ODFPackageValidator.validate(ODFPackageValidator.java:81)
at org.odftoolkit.odfvalidator.ODFValidator.validateFile(ODFValidator.java:163)
at org.odftoolkit.odfvalidator.ODFValidator.validate(ODFValidator.java:125)
at org.odftoolkit.odfvalidator.Main.main(Main.java:314)
file:///tmp/lu165138k4jdt.tmp/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/test/source/bootstrapfixture.cxx:233:PivotChartTest::testRoundtrip
equality assertion failed
- Expected: 0
- Actual : 256
- failed to execute: sh
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/build/bin/odfvalidator.sh -M
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng
-D
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-dsig-schema-v1.3+libreoffice.rng
-O
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng
-m /dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/mathml2/mathml2.xsd
/tmp/lu165138k4jdt.tmp > /tmp/lu165138k4jdz.tmp
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng:
Fatal:
/dev/shm/bee-root/libreoffice/libreoffice-6.3.0.4-0/source/schema/libreoffice/OpenDocument-manifest-schema-v1.3+libreoffice.rng:
file does not exist
PivotChartTest::testRoundtrip finished in: 1778ms
PivotChartTest::testChangePivotTable finished in: 277ms
[…]
```
The file is indeed not there.
```
$ find . -name "*.rng"
./build/workdir/UnpackedTarball/liborcus/misc/OpenDocument-v1.2-os-schema.rng
./build/workdir/UnpackedTarball/raptor/tests/feeds/atom.rng
./build/workdir/UnpackedTarball/beanshell/docs/manual/foo.rng
./source/writerfilter/documentation/ooxml/model.rng
./source/xmloff/dtd/openoffice-2.0-schema.rng
```
Kind regards,
Paul
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature