minutes of ESC call ...

* Present:
    + Heiko, Xisco, Kendy, Caolan, Michael S, Gabriel, Eike, Drew,
      Stephan, Cloph, Sophie, Miklos, Armin, Michael M, Olivier, Thorsten,
      Jan-Marek

* Completed Action Items:

* Pending Action Items:
    + run the certification script (Kendy)
    + commit access
       + GSOC mentors ask students (all)
       + communication issue wrt. Help (Sophie)

* Release Engineering update (Christian)
    + 6.3 alpha1: tagged, builds uploaded, except Win32 (had to redo the build)
      + feature freeze: week after the next week
      + please announce late features next week, if there will be any
    + 6.2.4 rc2 – tag planned for today
    + Remotes
    + Android viewer
    + Online

* Documentation (Olivier)
    + New Help (No news)
    + Helpontent2 
         + XML Fixes, typos (fitoshido, A Gelmini, ohallot)
         + fix contents (bubli)
         + review of l10n issues (A. Timar)
    + Goggle Seasons of Doc
         + 16 Tech Writer candidates, 
         + mostly students
         + Evaluating their tech Writer skills.
    + Guides
         + On going Calc update

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        252(252) (topicUI) bugs open, 211(211) (needsUXEval)
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months  
             added      2(-4)    21(-2)    37(1)       82(1)  
         commented     68(13)   231(14)   545(30)    1428(21) 
           removed      1(1)      3(-2)    15(1)       25(1)  
          resolved      1(-3)    10(-1)    44(-2)     131(1)  
    + top 10 contributors:
          Tietze, Heiko made 104 changes in 1 month, and 600 changes in 1 year
          Kainz, Andreas made 48 changes in 1 month, and 219 changes in 1 year
          Foote, V Stuart made 43 changes in 1 month, and 205 changes in 1 year
          Cor Nouws made 42 changes in 1 month, and 134 changes in 1 year
          Roman Kuznetsov made 30 changes in 1 month, and 198 changes in 1 year
          Xisco Faulí made 30 changes in 1 month, and 262 changes in 1 year
          Thomas Lendo made 29 changes in 1 month, and 237 changes in 1 year
          Brinzing, Oliver made 15 changes in 1 month, and 29 changes in 1 year
          Mehrbrodt, Samuel made 9 changes in 1 month, and 66 changes in 1 year

    + New needsUXEval between May/09-16

      * hyperlink choice should be remembered
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125246 
      * Wrong toolbar colors on Windows classic theme
        + https://bugs.documentfoundation.org/show_bug.cgi?id=124851
      * duplicate assignment of accelerators on a single menu disrupts keyboard
        use, eliminate duplicate accelerators
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125227 
      * Footer can not be made to appear only on the first page after it has
        been filled with content
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125280 
      => DUP, WF, NAB

      * change default grid size to 25x25 mm = 1x1 zoll
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125275 
      * UX: The Find bar should search in “Current selection only” if a cell
        range is selected
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125282 
      => in discussion

      * horizontal separator between notebookbar and main view
        + https://bugs.documentfoundation.org/show_bug.cgi?id=124667 
      => NEW

  ->  * Replace Mozilla themes with a proprietary tool reusing the existing
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125217 
      * Rename tabbed layout to notebookbar
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125009 
      * Provide an option to hide the animation effect
        + https://bugs.documentfoundation.org/show_bug.cgi?id=124477 
      * Insert image not in a new paragraph but in the current position or as
        character
        + https://bugs.documentfoundation.org/show_bug.cgi?id=45778 
      * Missing color name(s) in Conditional formatting dialog, hard coded color
        values not present on standard.soc
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125289 
      * wrong Bar color name in the Data bar dialog (#0000FF instead of Blue)
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125288 
      * Replace hard-coded chevron by themable icon
        + https://bugs.documentfoundation.org/show_bug.cgi?id=125296 
      => easyhack

  ->  * Option to turn off autocomplete text in quick find
        + https://bugs.documentfoundation.org/show_bug.cgi?id=124774 
      => needsDevAdvice

    + patch to show a What’s New infobar pointing to the releasenotes
      + https://gerrit.libreoffice.org/#/c/72218/ (review pending)

      => please carefully update the release notes

     + what version do we include in there ? (Christian)
         + majors so 6.1 or 6.2
     + why not just chat to Christian (Michael)
     + keep it as it is ? (Heiko)
         + use what existing code uses (Christian)

* Crash Testing (Caolan)
    + Google / ossfuzz:
      + 6 (+0,-1) issues
      + a few timeouts left
    + Crash testing:
      + 22(-47) import failure, 4(-4) export failures
      + import failures may be due to performance work.
    + CNA bits – got 1st batch of CVE numbers.
      + CVE-2019-9847 public – hyperlink bits
        + MITRE approved our description in the end.
    + ForcePoint #9 Completed
      + recontacted them, launched fuzzing again vs. master
    + waiting
      + coverity scan – until new version that supports c++17(?)
    + Xisco’s script ? (Michael)
       + been testing it locally (Xisco)
         + asked if we could use it at some point on servers
         + need to adapt the code to run 32 cores parallel.
       + finding lots of issues ? (Michael)
         + tested with calc & writer (Xisco)
            + found some crashes (some may be the same)
               + 30-40 crashes found.

* Crash Reporting (Xisco)
  + http://crashreport.libreoffice.org/stats/version/6.1.4.2
    + 1078 (+183)
  + http://crashreport.libreoffice.org/stats/version/6.1.5.2
    + 1558 (+264)
  + http://crashreport.libreoffice.org/stats/version/6.1.6.3
    + 215 (+147)
  + http://crashreport.libreoffice.org/stats/version/6.2.2.2
    + 1835 (+3)
  + http://crashreport.libreoffice.org/stats/version/6.2.3.2
    + 2401 (+549)
  + numbers up since last week service was down for a couple of days.
* Hackfests & Events (Sophie)
   + this year hackfests coming up:
        + Paris in Summer (Sophie)
          + first week of July Fri/Sat 5th / 6th
            + near Gare de Nord, La Mouette working on communication
          + designing a flier – avoids stomping on exams at end of June
          + https://wiki.documentfoundation.org/Hackfest/Paris2019 
          + hope to have a Hackfest NG setup again – mentees, please speak up!
          + people are adding themselves to the wiki already.
        + tentative Dresden: late autumn (past mid-October, for having students)
      + Brussels Hackathon (Italo)
          + pending October hackfest – needs confirmation
          + conflicts with Dresden – need a decision in May or so; pending …
          + slowly running out of time here …
   + hope to have one each quarter.

* Conference (Sophie)
   + <link>

* GSOC 2019 (Thorsten/Xisco/Moggi/Heiko)
   + Project page:      https://summerofcode.withgoogle.com/organizations/5557591040589824/ 
   + Timeline: https://developers.google.com/open-source/gsoc/timeline 
   + currently: community bonding period, students present their projects,      finalize plans & 
get ready to start
   + next deadline: May 27, coding starts

* C++ lectures (Xisco)
    + Izabela taking care of organization from now on.
    + unclear date for the next one (Heiko)
    + will send an E-mail to work out how to proceed (Eike)

* mentoring/easyhack update
          committer...   1 week      1 month     3 months     12 months   
                  open       77(1)      138(18)      141(20)      150(19) 
               reviews     1553(144)   5096(159)   13691(316)   49944(824)
                merged      254(-16)   1164(-2)     3621(17)    14772(11) 
             abandoned       12(-28)     76(6)       202(5)       843(4)  
           own commits      222(56)     923(11)     3131(5)     14205(-40)
        review commits      102(21)     360(14)      970(44)     3880(24) 
        contributor...   1 week   1 month    3 months   12 months   
                  open     45(13)    79(3)      80(1)       81(1)   
               reviews     84(1)    219(-48)   545(5)     4155(-500)
                merged     73(20)   231(1)     536(36)    1813(33)  
             abandoned      3(-4)    24(-20)    92(-10)    308(-3)  
           own commits     75(16)   251(7)     579(39)    1908(45)  
        review commits      0(0)      0(0)       0(0)        0(0)   
    + easyHack statistics:
       needsDevEval 96(96)   needsUXEval 0(0)   cleanup_comments 265(265)   
       total 329(329)   assigned 29(29)   open 203(203)   
    + top 10 contributors:
          Gelmini, Andrea made 146 patches in 1 month, and 736 patches in 1 year
          Illarionov, Arkadiy made 14 patches in 1 month, and 98 patches in 1 year
          Ilmari Lauhakangas made 13 patches in 1 month, and 52 patches in 1 year
          LibreOfficiant made 8 patches in 1 month, and 24 patches in 1 year
          himajin100000 made 8 patches in 1 month, and 17 patches in 1 year
          Adrien Ollier made 7 patches in 1 month, and 7 patches in 1 year
          Kaishu Sahu made 6 patches in 1 month, and 14 patches in 1 year
          Todor Balabanov made 6 patches in 1 month, and 6 patches in 1 year
          Rasmus Jonsson made 4 patches in 1 month, and 8 patches in 1 year
          Balazs Varga made 4 patches in 1 month, and 32 patches in 1 year
    + top 10 reviewers:
          Nabet, Julien made 315 review comments in 1 month, and 1495 in 1 year
          Holešovský, Jan made 203 review comments in 1 month, and 797 in 1 year
          Behrens, Thorsten made 171 review comments in 1 month, and 1716 in 1 year
          Michael Stahl made 147 review comments in 1 month, and 1131 in 1 year
          Vajna, Miklos made 144 review comments in 1 month, and 1386 in 1 year
          Grandin, Noel made 118 review comments in 1 month, and 1179 in 1 year
          Timar, Andras made 109 review comments in 1 month, and 943 in 1 year
          Meeks, Michael made 108 review comments in 1 month, and 576 in 1 year
          Bergmann, Stephan made 102 review comments in 1 month, and 785 in 1 year
          McNamara, Caolán made 92 review comments in 1 month, and 1098 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Jim Raykowski raykowj@gmail.com 
* Commit Access (Thorsten)
   + reminder – get GSOC students setup and warned wrt. private branches

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)

* Jenkins / CI update (Christian)
    from:Thu May  9 13:52:19 2019
    master linux rel  jobs: 189 ok: 189 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master linux dbg  jobs:  84 ok:  78 ko:   6 fail ratio:  7.14 % break:   6 broken duration: 
6.86%
    master mac rel    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master mac dbg    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master win rel    jobs: 116 ok:  89 ko:  26 fail ratio: 22.41 % break:  20 broken 
duration:23.33%
    master win dbg    jobs: 121 ok:  96 ko:  25 fail ratio: 20.66 % break:  23 broken 
duration:17.06%
    master win64 dbg  jobs: 116 ok:  95 ko:  21 fail ratio: 18.10 % break:  21 broken 
duration:25.62%
    lo-5.3 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    lo-5.4 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master gerrit lin jobs: 465 ok: 375 ko:  24 fail ratio:  5.16% time for ok: mean:  23 median:  
21
    master gerrit plg jobs: 475 ok: 338 ko:  83 fail ratio: 17.47% time for ok: mean:  38 median:  
34
    master gerrit win jobs: 507 ok: 309 ko:  95 fail ratio: 18.74% time for ok: mean:  68 median:  
69
    master gerrit mac jobs: 476 ok: 335 ko:  25 fail ratio:  5.25% time for ok: mean:  58 median:  
31
    master gerrit all jobs: 449 ok: 271 ko: 141 fail ratio: 31.40% time for ok: mean: 132 median: 
108
   + https://dev-www.libreoffice.org/tmp/gerrit_190516.html 
   + tests that failed more than twice in last seven days:
      4 CppunitTest_sw_uiwriter
      4 CppunitTest_sw_uwriter
      4 UITest_writer_tests
      5 CppunitTest_sc_html_export_test
      5 CppunitTest_sc_pdf_export
      6 CppunitTest_vcl_complextext
     15 UITest_writer_tests5
   + more or less working – lots of test failures again.
       + didn’t look when they started; a single set of changes ?

* ESC composition (Michael)
   + re-propose - as before
     + but keeping Bubli
   + Armin affiliation change (Armin)
     + just hacking on item bits, privately
   + good to keep this balanced wrt. contribution
   + news from Gabriel
     + 1&1 membership was approved
   => re-propose to the board

* std::function in place of DECL_LINK etc. (Michael)
   + eg. https://gerrit.libreoffice.org/#/c/72294/2
   + next big round of cleanup / standardization ?
   + plan to move away from tools (Miklos)
      + the boost thing had some terrible overhead.
      + compared to that this looks better.
   + std::function is essentially boost (Thorsten)
      + may impact compile time & memory footprint
      + broadly in favour of getting it flushed out though
   + prolly std::function header is everywhere anyway (Michael S)
      + would be my expectation too (Michael)
   + like to get the cleaner code (Michael)
   + if it works – fine (Stephan)

* ItemSet re-work (Armin)
   + mainly experimenting
   + using std::function – works pretty well
   + get the ItemSet/ItemPool bits cleaned up
   + so you don’t need which-id, but base it on item types
   + looks good, but 800 derivations of items
   + not be able to change them all
   + prototyping in project workspace.
   + checked-in, have a look.
   + goal to find out if it’s do-able
   + can we get faster, leaner, cleaner with it.
   + item access is over sorted lists currently
   + looks good, but unsure how far I can push it
   + how is this profiled ? (Michael)
      + eg. large writer docs with lots of overlapping autostyles
   + not targetted at anything in particular (Armin)
      + trying to cleanup the code, make it more abstract
      + still experimenting & discussing with Noel who has an eye on it.
   + crystalizing in some direction now
   + good place to test writer import (Michael)
   + most of items are sorted in the item-pools (Armin)
      + not inside the item-sets.
      + in the item pools: just in a vector
      + only compare, not < operator – usually not sorted.
      + working on that.
      + into more modern structures, not just for 1 app.
   + hope to make it to Almeria to talk about it.
   + mentioned std::function (Stephan)
      + rather heavy / costly at run-time
      + fine for replacing link stuff
      + but perhaps not for mass objects like items
      + would love to see it earlier and/or often
         + in a gerrit branch (?) a topic branch perhaps
         + where jenkins test builds the commits.
         + difficult for others to consume a big-blog feature branch.
    + did it in a branch – to make it visible (Armin)
        + its invisible – hard to comment on like in gerrit (Stephan)
        + use a gerrit topic branch (Eike)
           + push it not to refs/for/master but
           $ git push origin HEAD:refs/for/master/my_branch_name
           + advantage is that its also built against Jenkins / CI
           + can easily re-base & have the changes up-loaded again etc.
    + if highly expermiental (Thorsten)
        + if it will be thrown away – a balance to strike
        + if all changing, having constant review & discussion can be annoying
    + perhaps it is ready for discussion (Armin)
    + missed one of the pressing bugs (Armin)
       + changed gerrit / bugzilla to private E-mail, but don’t get it.
       + when want to be on the list – use private E-mail
    + at the end of month we have 6.3 branched for 6.4 (Xisco)
       + wrt. pushing – perhaps good to wait until after the 6.3 branch.
       + no worries, far away from being pushed (Armin)

* Just a reminder regarding kde5 plugin in still (Jan-Marek)
    + the qt5 plugin is currently not using cairo and it’s font handling is not         really 
existing.
    + if we keep kde5, should we switch qt5 to cairo too, so that people have
      the same “quality”?
    + we get bug reports for qt5, even if its never automatically selected, like
        https://bugs.documentfoundation.org/show_bug.cgi?id=125234
    + Is that considered a problem for anyone or “if it hurts, don’t do it” ?
    + what do you prefer ? (Michael)
       + not sure – user has to select it themselves (Jmux)
          + happy to get bug reports, but reply to bugs is not helpful.
          + if switch to cairo automatically – has same quality / fixes
          + if this comes to still – and people non-automatically select it
       + years ago Kendy made effort to switch VCL from inside the app (Heiko)
          + at beginning of coding process – not clear that’s there.
          + easy to switch from one to the other to cope with issues.
          + talking wrt. Still – but won’t happen here (Jmux)
       + any downside to qt5 + cairo ? (Xisco)
          + not sure if there is any downside (Jmux)
             + plus is that Qt5 would be usable for users.
          + any objections to using Cairo for Qt5 ? (Michael)
             + can we make it more obvious it’s experimental? (Thorsten)
                + not accommodating random users who did odd things they found                      
    on the net.
                   + if there is a plan to improve that over time.
          + fine – how can we make this experimental ? (Jmux)
             + for help/about can write Qt5Experimental
          + had similar thing in the past for gtk3 (Miklos)
             + just ignore it unless its experimental.
                 + i.e. bail out the vcl plug if not experimental mode is on
          officecfg::Office::Common::Misc::ExperimentalMode::get()
          + any objections to making it experimental ?
          => will make it experimental.

* l10n (Sophie)
    + approached by Fedora / l10n community
    + currently using zanata and want to hear about pootle
       + since zanata is not anymore
    + perhaps can work together moving to weblate
    + transifex ? (Michael)
       + now private.
    + is there support for weblate ? (Michael)
       + would be great to do that – we did for pootle.
       + not investigated the community (Sophie)
       + offer hosted versions – so can provide backend support (Christian)
    + very well documented, regularly releases (Sophie)

* QA update (Xisco)

    + Please help flesh out the monthly reports:
      https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 548 (-2)
        + enhancements: 73  (+5)
        + needsUXEval: 1 (-1)
        + haveBackTrace: 3 (+0)
        + needsDevAdvice: 16 (-1)
        + documentation:  13 (+1)
        + android:  13 (+1)
        + iOS:  6 (+0)
        + Online:  23 (-2)
    + Most pressing bugs:

        + New
            + External forms for a database doesn't save data - closing form
                + https://bugs.documentfoundation.org/show_bug.cgi?id=114596
                + Noel? Michael Stahl ?
            + can't open DOT file
                + https://bugs.documentfoundation.org/show_bug.cgi?id=125216
                + Tor ...
        + Older
            + Font changed when typing into cell, in edit mode, with redline
                + https://bugs.documentfoundation.org/show_bug.cgi?id=125054
                + https://gerrit.libreoffice.org/#/c/72399/
                + fix in gerrit thanks to Armin
        + Fixed
                [None]

    + New high severity bugs of the week:

        + Applying autocorrect to text with URLs causes Writer to hang
            + https://bugs.documentfoundation.org/show_bug.cgi?id=125261
                + Fixed. Thanks to Michael Stahl

        + Hang when selecting Read Online Help (GTK2)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=125266
                + Fixed. Thanks to Caolán
    + pleased to see lubos fixing mdds issues (Xisco)
* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +125  -11 (-228) overall)
      many thanks to the top bug squashers:
       QA Administrators       94
       Xisco Faulí             21
       Timur                   10
       Caolán McNamara         8
       V Stuart Foote          6
       Dieter Praas            6
       Julien Nabet            5
       Heiko Tietze            5
       Michael Stahl (CIB)     5
       Buovjaga                5

    + top 10 bugs reporters:
       Roman Kuznetsov         5
       Stéphane Aulery         5
       Peter Benedek           4
       Drew Jensen             3
       andreas_k               3
       Xisco Faulí             2
       david.cortes.rivera     2
       Oliver Brinzing         2
       Aron Budea              2
       Cathy Crumbley          2

    + top 10 bugs fixers:
       McNamara, Caolán        8
       Grandin, Noel           5
       Michael Stahl           5
       Németh, László          3
                               2
       Budea, Áron             2
       Bergmann, Stephan       1
       himajin100000           1
       Glogowski, Jan-Marek    1
       Krot, Serge             1

    + top 10 bugs confirmers:
       Xisco Faulí             45
       Dieter Praas            13
       Roman Kuznetsov         13
       Timur                   8
       Budea, Áron             6
       Foote, V Stuart         5
       Brinzing, Oliver        4
       Raal                    4
       Usama                   3


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/51 -     1 %  (+0)
     5.4 : 1/40 -     2 %  (+0)
     5.3 : 1/54 -     1 %  (+0)
     5.2 : 1/44 -     2 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 1/76 -     1 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 3/134 -    2 %  (+0)
     4.1 : 2/84 -     2 %  (+0)
     4.0 : 4/83 -     4 %  (+0)
     old : 10/248 -   4 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 664/3255 668/3238 666/3218 665/3199 664/3181 641/3146 642/3131 

     done by:
        Raal                   6
        Xisco Faulí            6
        Roman Kuznetsov        1
        Justin L               1
        Michael Stahl          1
        Brinzing, Oliver       1
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 847/4043 850/4024 848/4004 847/3985 845/3965 832/3939 835/3922 

     done by:
        Xisco Faulí            7
        Raal                   6
        Roman Kuznetsov        1
        free manga park        1
        Justin L               1
        Michael Stahl          1
        Brinzing, Oliver       1


* all bugs tagged with 'regression'
   + 1117(-9) bugs open of 8447(+18) total 6(-2) high prio.

     done by:
        Roman Kuznetsov        4
        Xisco Faulí            4
        Alex Thurgood          2
        Justin L               1
        Raal                   1
        Michael Stahl          1
        Brinzing, Oliver       1
        Telesto                1
        Timur                  1
        Cor Nouws              1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     LibreOffice   - 3(+0)
     Writer        - 2(+0)
     Calc          - 1(-1)
     Impress       - 0(-1)

   by OS:
     Mac OS X      - 0(+0)
     Linux         - 0(+0)
     All           - 6(-2)
     Windows       - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 278(-2)
     Calc                     - 219(-3)
     Impress                  - 118(-2)
     Writer: docx filter      - 80(-1)
     LibreOffice              - 68(+1)
     Base                     - 46(+0)
     Draw                     - 45(-1)
     UI                       - 43(+0)
     Borders                  - 40(+0)
     Writer: doc filter       - 37(+1)
     Writer: perf             - 34(+1)
     Writer: other filter     - 32(-1)
     graphics stack           - 30(+0)
     Crashes                  - 27(-6)
     filters and storage      - 24(+0)
     RTL                      - 23(-1)
     BASIC                    - 17(+0)
     Chart                    - 14(+0)
     Printing and PDF export  - 14(+0)
     framework                - 2(+0)
     Linguistic               - 1(+0)