Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index


On Tuesday 07 of May 2019, Tomaž Vajngerl wrote:
Hi,

On Tue, May 7, 2019 at 8:42 PM Luboš Luňák <l.lunak@collabora.com> wrote:
  A clang plugin that rewrites all "getWidth()" to "(GetWidth() + 1)" (or
the
other way around).

Well the problem is that getWidth() is not always GetWidth() + 1 , which
you see when you examine its implementation. AFAIK this is the reason
previous attempts abandoned the idea to mechanically change it.


 I see. One idea that comes to mind then is to split the current class into a 
sane tools::Rectangle and keep the insane stuff in tools::SillyRectangle. 
Then at least it would be clearly defined what is good and what is not, the 
awfulness would be contained, wouldn't spread and its usage could be reduced 
over time.

-- 
 Luboš Luňák
 l.lunak@collabora.com

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.