Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index



On 26/04/2019 13:43, Thorsten Behrens wrote:
Right - IIRC that was very trivial hairlines there, not much value in
buffering that -

        =)

     * should we not disable the SystemDependentDataBuffer ie.
       remove:

                if(maEntries.empty() && maTimer)
                    maTimer->Stop();

       from there we can stop ourselves in the timeout if necessary.

Not sure I get the question - surely disabling the timer helps to get
scheduler load down? As this code is already inside implTimeoutHdl().

        I rather suspect that adding and removing a timer a very large number
of times has a potentially significant cost. Whereas adding a timer once
- and (when it happens a second later) - noticing there is nothing to do
and removing it has a very small cost once per second. Also makes
logging & debugging scheduler related issues much nicer.

Just a bit concerned we'd flip-flop between optimizing for different
cases here - some perf test rig would be ideal I guess..

        If we get the low hanging fruit I guess we win and leave the detail to
the future =)

        ATB,

                Michael.

-- 
michael.meeks@collabora.com <><, GM Collabora Productivity
Hangout: mejmeeks@gmail.com, Skype: mmeeks
(M) +44 7795 666 147 - timezone usually UK / Europe

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.