Hi Thorsten,
On 10.04.2019 2:11, Thorsten Behrens wrote:
--- a/include/osl/mutex.hxx
+++ b/include/osl/mutex.hxx
@@ -178,11 +178,9 @@ namespace osl
*/
void clear()
{
- if(pT)
- {
- pT->release();
- pT = NULL;
- }
+ assert(pT);
+ pT->release();
+ pT = NULL;
}
};
This will have unsuspecting consumers of our API crash if they don't
catch the assertion during development. I'm not sure that's a positive
thing to impose on our ecosystem (where LibreOffice support might
already not be a priority).
I'd be much happier with the pT check still present, but guarded by
!LIBO_INTERNAL_ONLY.
Please check the discussion at https://gerrit.libreoffice.org/70381: in
fact, my original intention was just that, and it was implemented to
only assert in debug builds.
--
Best regards,
Mike Kaganski
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.