Re: Just for Information: Support for VS 2019 Preview 1

hi himajin100000,

good to hear that you are working on Visual Studio 2019 support!

sorry but i didn't have time to reply to your mail earlier...

On 13.12.18 03:25, himajin100000 wrote:
> In addtion to the modification given in
> https://gerrit.libreoffice.org/#/c/64630/
>
> I needed to:
>
> 1.
> https://opengrok.libreoffice.org/xref/core/external/twain_dsm/ExternalProject_twain_dsm.mk?r=585d9806#26 
>
>
> I need to consider $(VCVER) = 160 and $(VCVER)-$(WINDOWS_SDK_VERSION) = 
> 160-10 case for all the similar cases:
>
> https://opengrok.libreoffice.org/search?project=core&q=VCVER&defs=&refs=&path=&hist=&type= 
>
>
> $(if $(filter 160,$(VCVER)),/p:PlatformToolset=v141 
> /p:VisualStudioVersion=16.0 /ToolsVersion:Current) \

yes for these we need a new line...

> $(if $(filter 
> 160-10,$(VCVER)-$(WINDOWS_SDK_VERSION)),/p:WindowsTargetPlatformVersion=$(UCRTVERSION)) 
> \

... but here, the only supported VCVER on master will be 150 and 160, 
and all of them need this, so just remove $(VCVER) here and only check 
the other variable.

(also, there are still checks for $(VCVER) = 140 in some files - these 
can all be removed on master because configure does not accept this 
version; ideally that can be a separate cleanup patch preceding your 
2019 changes.)

> 2.
> https://opengrok.libreoffice.org/xref/core/configure.ac?r=905c107c#3432
> I don't have 16.0 folder under MSBuild directory.
> What I have is "Current" directory. so I need special treatment for this 
> case.

maybe this is a permanent change, maybe it is just like this in the 
"Preview" version and then in the release there will be 16.0 directory 
... hard to predict from the outside :)

> but even when configure failed to find the MSBuild.exe based on this 
> rule, if another MSBuild is found in one of the PATHs added during build 
> process, the build process might succeed. This case seemed to happen to 
> me somehow only for x64(probably from old .NET stuffs). For x86,error 
> for unsupported ToolsVersion was given. weird.
>
> 3. regarding lcms2,
>
> https://opengrok.libreoffice.org/xref/core/external/lcms2/ExternalProject_lcms2.mk?r=e751e242#26 
>
>
> currently, the code rebased to master has 2015 directory under Projects 
> folder, and code on github has 2017 directory
>
> https://github.com/mm2/Little-CMS/tree/master/Projects/VC2017
>
> for now, I changed the directory from 2013 to 2015, and can successfully 
> build the source. Would it be better to update the archive on 
> libreoffice to rebase to the one in github and change the diretory to 
> 2017? If yes, how can I ask the server manager to add the updated archive?

usually it's best to ask on IRC in #libreoffice-dev

i've done an upgrade of this library now as it turns out there is a new 
CVE for it as well; it's currently in gerrit, see 
https://gerrit.libreoffice.org/#/c/66400/

> 4. regarding python3,

this tends to require changes to these horrible MSBuild-files, that are 
a pain to rebase to new python versions...

... would it be possible to first upgrade the bundled python to the 
latest upstream release?

this is 3.7.2 as of now, since it's not a x.y.0 release it should be 
suitable at least for master :)

with any luck some of the problems will already be fixed in the new release.