Re: xpdfwrapper/pdfioutdev_gpl.hxx:227:22: error: ‘virtual void pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked ‘override’, but does not override

On 14.01.2019 11:46, Stephan Bergmann wrote:
> On 13/01/2019 23:57, Дилян Палаузов wrote:
> > LO 6.0.7.3 fails compiling with gcc 8.2.1 20190101 I emitting:
> >
> > [build SPP] scp2/source/ooo/ure
> > [build SCP] scp2/source/writer/file_writer
> > [build SPP] scp2/source/xsltfilter/file_xsltfilter
> > [build SPP] scp2/source/xsltfilter/module_xsltfilter
> > [build SPP] scp2/source/gnome/file_gnome
> > [build SPP] scp2/source/gnome/module_gnome
> > [build SPP] scp2/source/sdkoo/sdkoo
> > [build SCP] scp2/source/writer/module_writer
> > [build CXX] sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx
> > In file included from 
> > /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24, 
> >
> >                   from 
> > /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20: 
> >
> > /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22: 
> > error: ‘virtual void
> > pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ marked 
> > ‘override’, but does not override
> >           virtual void drawString(GfxState *state, const GooString *s) 
> > override;
> >                        ^~~~~~~~~~
> > /src/libreoffice-6.0.7.3/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:227:22: 
> > warning:   by ‘virtual void
> > pdfi::PDFOutDev::drawString(GfxState*, const GooString*)’ 
> > [-Woverloaded-virtual]
> > make[1]: *** 
> > [/src/libreoffice-6.0.7.3/solenv/gbuild/LinkTarget.mk:293: 
> > /src/libreoffice-
>
> You likely need a backport of 
> <https://gerrit.libreoffice.org/plugins/gitiles/core/+/42cebff14f7d486c20f04863681cc5ef4602f4eb%5E!/>
>  
> "fix build with poppler 0.64" (and maybe also backports of further 
> poppler-adaption fixes in that area), or configure 
> --without-system-poppler.
>
> There is obviously always a chance that building old versions of LO 
> against current system components does not work.  Often enough, you will 
> find fixes for those issues in later versions of LO, and which are often 
> even easy to backport to the version where you need them.

I'm afraid that the message implies that the fix from spring 2018 is 
already there - the constness of the GooString parameter is there in the 
message. So possibly there's some problem detecting the poppler library 
version?

-- 
Best regards,
Mike Kaganski