Re: [Libreoffice-commits] core.git: Upgrade external/postgresql to postgresql-9.2.24

Below, I conservatively upgraded only to the latest PostgreSQL 9.2.x 
(namely, 9.2.24; from previous 9.2.1).  I need that for the LO flatpak 
build (as discussed in the commit message), and plan to backport that to 
libreoffice-6-2.

However, at <https://www.postgresql.org/>, the latest releases announced 
are "PostgreSQL 11.1, 10.6, 9.6.11, 9.5.15, 9.4.20, and 9.3.25", so I 
wonder whether it would make sense to upgrade at least LO master to a 
later version?  Anybody know of any (compatibility, etc.) issues that 
restrict us to 9.2.x or similar?


On 07/12/2018 13:25, Libreoffice Gerrit user wrote:
> New commits:
> commit a01ac385ed16fbe4239938c9d31462691707e87b
> Author:     Stephan Bergmann <sbergman@redhat.com>
> AuthorDate: Thu Dec 6 17:20:37 2018 +0100
> Commit:     Stephan Bergmann <sbergman@redhat.com>
> CommitDate: Fri Dec 7 13:24:58 2018 +0100
>
>      Upgrade external/postgresql to postgresql-9.2.24
>      
>      ...which is the latest 9.2.x currently listed at
>      <https://www.postgresql.org/ftp/source/>.  9.2.1 doesn't build against
>      OpenSSL 1.1 which dropped SSL_library_init (cf. <https://wiki.openssl.org/
>      index.php/Library_Initialization#libssl_Initialization>), and 9.2.24 apparently
>      has that covered.  (Ran into this when trying to upgrade the LibreOffice flatpak
>      build to org.freedesktop.Sdk//18.08, which has OpenSSL 1.1.)
>      
>      On Windows, the new tarball as-is fails with
>      
>      > ..\..\port\chklocale.c(214): error C2037: left of 'lc_codepage' specifies undefined struct/union '__crt_locale_data'
>      
>      because at least in Windows Kits/10/Include/10.0.17763.0/ucrt/corecrt.h
>      (included from Windows Kits/10/Include/10.0.17763.0/ucrt/locale.h), the relevant
>      definitions are now
>      
>      > typedef struct __crt_locale_data_public
>      > {
>      >       unsigned short const* _locale_pctype;
>      >     _Field_range_(1, 2) int _locale_mb_cur_max;
>      >                unsigned int _locale_lc_codepage;
>      > } __crt_locale_data_public;
>      >
>      > typedef struct __crt_locale_pointers
>      > {
>      >     struct __crt_locale_data*    locinfo;
>      >     struct __crt_multibyte_data* mbcinfo;
>      > } __crt_locale_pointers;
>      >
>      > typedef __crt_locale_pointers* _locale_t;
>      
>      which presumably has changed from a past state where that lc_codepage member was
>      directly publicly accessible.
>      
>      <https://dev-www.libreoffice.org/src/postgresql-9.2.24.tar.bz2> is a copy of
>      <https://ftp.postgresql.org/pub/source/v9.2.24/postgresql-9.2.24.tar.bz2>;
>      `sha256sum postgresql-9.2.24.tar.bz2` reports the same
>      a754c02f7051c2f21e52f8669a421b50485afcde9a581674d6106326b189d126 as recorded in
>      <https://ftp.postgresql.org/pub/source/v9.2.24/postgresql-9.2.24.tar.bz2.sha256>
>      
>      Change-Id: I196dd93aa03471042efba57ea639e1bb6655de98
>      Reviewed-on: https://gerrit.libreoffice.org/64730
>      Tested-by: Jenkins
>      Reviewed-by: Stephan Bergmann <sbergman@redhat.com>