minutes of ESC call ...

* Present:
    + Eike, Miklos, Stephan, Michael S, Olivier, Xisco, Caolan
      Michael W, Sophie, Michael M, Drew, Christian, Heiko,
      Thorsten, Jan-Marek

* Completed Action Items:
    + add commit access & welcome Mert Tumer (Michael M)
    + mend Android tinderbox (Christian)
      [ has build failures, but is back ] 

* Pending Action Items:
    + run certification script (Kendy)
      [ not run yet ]
    + add screenshot builder to basic build stats (Christian)
      [ set it up on the build-bot that was Kendy’s no results yet ]

* Release Engineering update (Christian)
    + 6.1.4 RC1 status
      + tagged yesterday, uneventful – collecting builds to up-load 
    + 6.2 Beta 2 slot (?)
      + any requests for this – else skip it.
      + are daily builds sufficient for Notebookbar testing ?
      + Andreas K proposed to have a B2 (Xisco)
         + Notebookbar enabled in B1 already
         + not particularly worried about having one (Heiko)
      => no beta 2 planned.
         + can request next monday if big changes.
    + 6.2 RC 1 – Dec 17th
      + Late Features ?
         + donation infobar (Heiko)
            + https://gerrit.libreoffice.org/#/c/63883/
            + terminology in discussion, review pending
            + agreement to have this – 90 days alternation with get-involved.
            + how do we label / approach the people.
            + an option to turn it off ? (Michael W)
               + yes → lots of ways to do that (Heiko)
               + prefer to have this as a compile time option (Michael M)
            => merge it.
         + red-lining paragraph attribute re-work (Michael S)
                - trying to aim for UI freeze on Dec 17 for switching the default
            + hoping to finish a few 10’s of patches to get interactive editing
              bits into a state where basic things work.
            + will be some more complex bits to do after that.
            + autoformat pieces – makes splitting paragraphs harder.
         + showstopper for Notebookbar (Heiko)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=103226
            + Kshitij’s patch was reverted – seems like a show-stopper.
            + a problem with toolbars that pop-up or not
            + marketing people are doing work, and disappointment is great.
            + MikeK may be looking in his spare time (Caolan)
               + patch at https://gerrit.libreoffice.org/#/c/64256/
    + Remotes
    + Android viewer
 + Online

* Base / Firebird migration assistant (Xisco)
    + was experimental in 6.1 – now it’s on in 6.2
    + should it be on by default ?
    + also triggers the conversion dialog when a macro is run (Christian)
        + this breaks a number of external projects:
          https://bugs.documentfoundation.org/show_bug.cgi?id=121599 
        + rather important (Drew)
    + why don’t we make it experimental still in 6.2 ? (Miklos)
        + so more time to fix in master.
    + not convinced it is ready without a code update (Drew)
    + will we have it in another six months if experimental again ? (Xisco)
        + if not on in master – no test coverage, so good to have on (Thorsten)
        + don’t think it’s a bad thing on master (Drew) 
           + if the issue on when it prompts to start the conversion
             then could have it on in 6.2
           + waiting for someone to take an interest here (Michael M)
    => fwd port patch so it’s experimental again in 6.2 (Xisco)

* Documentation (Olivier)
    + New Help
         + added new (extended) XML tags for simpler markup (ohallot)
         + Added code highlight for BASIC code (ohallot)
    + Helpcontents
         + New pages for Basic and VBA (A. Romedenne)
         + Fixes in help pages (A Gelmini, ohallot, fitoshido)
         + Help entry pages on using Python scripts (ohallot)
    + Guides
         + Team delivering first updates on Calc book
         + discussing on how to bypass bugs.
    + updated wiki pages on how to write help pages.
         + also documenting new XML extensions.

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        260(260) (topicUI) bugs open, 284(284) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month    3 months   12 months  
             added      8(-2)     32(-3)     56(-1)      99(-1) 
         commented     34(-41)   161(-42)   387(-22)   1438(-28)
           removed      5(4)       8(5)       8(5)       14(5)  
          resolved      0(-4)      8(-2)     22(-3)     116(-5) 
    + top 10 contributors:
          Tietze, Heiko made 114 changes in 1 month, and 551 changes in 1 year
          Thomas Lendo made 80 changes in 1 month, and 349 changes in 1 year
          Xisco Faulí made 52 changes in 1 month, and 283 changes in 1 year
          Kainz, Andreas made 38 changes in 1 month, and 141 changes in 1 year
          Henschel, Regina made 15 changes in 1 month, and 79 changes in 1 year
          Pedro made 13 changes in 1 month, and 68 changes in 1 year
          Cor Nouws made 11 changes in 1 month, and 81 changes in 1 year
          Foote, V Stuart made 11 changes in 1 month, and 199 changes in 1 year
          Monastirsky, Maxim made 10 changes in 1 month, and 45 changes in 1 y
          BogdanB made 10 changes in 1 month, and 15 changes in 1 year
   + New needsUXEval between Nov/22-28

      * Ability to selectively Pin document in front of other applications
        + https://bugs.documentfoundation.org/show_bug.cgi?id=121701
        => WF
      * Added the GUI control for "Draw object height", "Draw object width", and
        "Draw object rotation degree" to the "Drawing Object properties" toolbar
        + https://bugs.documentfoundation.org/show_bug.cgi?id=121702
        => DUP
      * RTL: Update message popup pointer doesnt show up on correct side
        + https://bugs.documentfoundation.org/show_bug.cgi?id=113412
        => BUG
      * incorrect background colour choice for focused items in 6.0 on linux
        + https://bugs.documentfoundation.org/show_bug.cgi?id=116177
        => NEEDINFO
      * Record Track Changes works reluctantly on Experimental Contextual 
        Groups Interface
        + https://bugs.documentfoundation.org/show_bug.cgi?id=120994
      * There is a vertical line on Experimental Contextual Group Menu
        + https://bugs.documentfoundation.org/show_bug.cgi?id=120981
      * Sub-optimal Colibre icon for "Add fields" in Base reports
        + https://bugs.documentfoundation.org/show_bug.cgi?id=120993
      * Can’t choose paragraph or character language from task bar
        + https://bugs.documentfoundation.org/show_bug.cgi?id=121700
      * Select multiple tables in a Writer document
        + https://bugs.documentfoundation.org/show_bug.cgi?id=121705
        => unconfirmed / in discussion, needsDevAdvice
        + would be interesting if we can select more than on table
           + not easy to implement (Miklos)
               + text or a table-selection currently.
               + quite challenging to implement it.
        + best to use styles instead (Heiko) 

* Crash Testing (Caolan)
    + 1 (-2) import failures, 9(-4) export failures
        + export failures is a new assert to find these
        + passed these on to Justin.
    + 8 (+0) coverity issues
        + asked to run with C++17 – now is enabled
    + 18 Google / ossfuzz:
        + 2 serious, lots of timeout issues / broken build:
    + ForcePoint, round 9
        + 4 writer layout issues
    + couple of other issues
        + Issue in progress, finally agreed an embargo with AOO
           + now have a CVE to go with this; Jan 2019 embargo.
        + sticking with 27th November.
    + CNA process joy ?
        + updated page link ?
    + PVS Studio
        + everything from the online review fixed; some other bits
        + would like another run …
        + poke Mike & ask in the bug ... 
    + Another static checker: Svace (a Russian company)
        + filed 1 bug; semi-false-positive 
        + would be nice to have continuous running vs. master

* Crash Reporting (Xisco)
    + http://crashreport.libreoffice.org/stats/version/6.0.6.2
         + 1269 (last 7 days) (-177)
    + http://crashreport.libreoffice.org/stats/version/6.0.7.3
         + 499 (last 7 days) (+87)
    + http://crashreport.libreoffice.org/stats/version/6.1.2.1
         + 2929 (last 7 days) (-526)
    + http://crashreport.libreoffice.org/stats/version/6.1.3.2
         + 2298 (last 7 days) (+381)
    + expect 6.1.4 to be better

* Hackfests & Events (Thorsten)
   + next year hackfests coming up:
        + FOSDEM in February
          + Thur/Fri - 2 days before the conference confirmed.
        + Tirana perhaps in March/April
        + Paris in summer
        + tentative Dresden: late autumn (past mid-October, for having students)
   + hope to have one each quarter.    
   + GSoC’19
     + https://opensource.googleblog.com/2018/11/google-summer-of-code-15-years-strong.html
        + project signup starts to open Jan 15th 
     + good to come up with good ideas / design plans for the wiki (Thorsten)
          + https://wiki.documentfoundation.org/Development/GSoC/Ideas
        + Heiko / Xisco as org. admins ?
        + trouble with decision of what projects ? (Heiko)
           + based on mentor power and student quality (Thorsten)

   + C++ lectures ( Xisco )
     + 1 session:
          + Dec 13th from 20 to 21 CET in IRC
          + More info: https://forum.openlabs.cc/t/libreoffice-2019/1406/45?u=x1sc0
        + get some videos from youtube; 1 hour session to attend
        + topic won’t need preparation: would love ESC attendees to come help.

* mentoring/easyhack update
          committer...   1 week       1 month     3 months     12 months   
                  open       89(35)      129(17)      134(18)      145(18) 
               reviews     1580(347)    5131(53)    12905(257)   34674(863)
                merged      409(156)    1295(61)     3674(117)   15491(167)
             abandoned       15(1)       109(-5)      229(6)       975(-13)
           own commits      306(-107)   1467(-52)    4080(40)    15612(-93)
        review commits       62(-47)     375(1)       856(-18)    3728(-65)
        contributor...   1 week    1 month   3 months   12 months    
                  open     22(-3)     51(5)     53(5)        56(5)   
               reviews     75(1)     232(-4)   421(-4)    19113(-694)
                merged     28(-16)   145(-5)   320(1)      1549(-54) 
             abandoned      2(0)      26(-5)    64(-2)      294(-18) 
           own commits     38(-8)    177(13)   389(10)     1530(-6)  
        review commits      0(0)       0(0)      0(0)         0(0)   
    + easyHack statistics:
       needsDevEval 59(59)   needsUXEval 4(4)   cleanup_comments 232(232)   
       total 292(292)   assigned 21(21)   open 205(205)   
    + top 10 contributors:
          Gelmini, Andrea made 55 patches in 1 month, and 527 patches in 1 year
          Sophia Schröder made 30 patches in 1 month, and 169 patches in 1 year
          Zoltán Zdibák made 17 patches in 1 month, and 18 patches in 1 year
          Ilmari Lauhakangas made 10 patches in 1 month, and 47 patches in 1 year
          Illarionov, Arkadiy made 9 patches in 1 month, and 43 patches in 1 year
          Aleksei Nikiforov made 8 patches in 1 month, and 8 patches in 1 year
          Tümer, Mert made 7 patches in 1 month, and 29 patches in 1 year
          Roman Kuznetsov made 4 patches in 1 month, and 4 patches in 1 year
          Hamish McIntyre-Bhatty made 3 patches in 1 month, and 3 patches in 1 year
          Balazs Varga made 3 patches in 1 month, and 13 patches 
inhttps://gerrit.libreoffice.org/#/c/64256/ 1 year
    + top 10 reviewers:
          Behrens, Thorsten made 140 review comments in 1 month, and 1510 in 1 year
          McNamara, Caolán made 140 review comments in 1 month, and 1063 in 1 year
          Nabet, Julien made 139 review comments in 1 month, and 1028 in 1 year
          Adolfo Jayme Barrientos made 137 review comments in 1 month, and 1014 in 1 year
          Olivier Hallot made 122 review comments in 1 month, and 562 in 1 year
          Vajna, Miklos made 119 review comments in 1 month, and 1282 in 1 year
          Grandin, Noel made 111 review comments in 1 month, and 1284 in 1 year
          Bergmann, Stephan made 99 review comments in 1 month, and 686 in 1 year
          Meeks, Michael made 91 review comments in 1 month, and 793 in 1 year
          Xisco Faulí made 83 review comments in 1 month, and 417 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          sabri unal yakushabb@gmail.com 
          Alain Romedenne pyoffice.romedenne@sfr.fr 
* Commit Access

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + pending the script.

* Jenkins / CI update (Christian)
    from:Thu Nov 22 15:27:15 2018
    master linux rel  jobs: 180 ok: 126 ko:  54 fail ratio: 30.00 % break:  10 broken 
duration:19.12%
    master linux dbg  jobs: 106 ok:  80 ko:  26 fail ratio: 24.53 % break:   5 broken 
duration:12.52%
    master mac rel    jobs:  94 ok:  91 ko:   3 fail ratio:  3.19 % break:   1 broken duration: 
9.50%
    master mac dbg    jobs:  92 ok:  88 ko:   4 fail ratio:  4.35 % break:   2 broken duration: 
6.50%
    master win rel    jobs:  67 ok:  27 ko:  40 fail ratio: 59.70 % break:  12 broken 
duration:58.99%
    master win dbg    jobs:  73 ok:  51 ko:  22 fail ratio: 30.14 % break:  16 broken 
duration:32.71%
    master win64 dbg  jobs:  67 ok:  49 ko:  18 fail ratio: 26.87 % break:  13 broken 
duration:35.77%
    lo-5.3 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    lo-5.4 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    master gerrit lin jobs: 651 ok: 518 ko:  40 fail ratio:  6.14% time for ok: mean:  24 median:  
21
    master gerrit plg jobs: 652 ok: 440 ko: 110 fail ratio: 16.87% time for ok: mean:  41 median:  
37
    master gerrit win jobs: 758 ok: 427 ko: 173 fail ratio: 22.82% time for ok: mean:  81 median:  
81
    master gerrit mac jobs: 652 ok: 485 ko:  33 fail ratio:  5.06% time for ok: mean:  62 median:  
43
    master gerrit all jobs: 547 ok: 300 ko: 200 fail ratio: 36.56% time for ok: mean: 140 median: 
129
    + https://dev-www.libreoffice.org/tmp/gerrit_181129.html 
    + Tests that failed more than twice in last seven days
      3 CppunitTest_sw_fodfexport
      3 CppunitTest_sw_ooxmlfieldexport
      3 CppunitTest_sw_uiwriter
      3 UITest_writer_tests
      4 CppunitTest_slideshow
      4 CppunitTest_vcl_fontfeature
      5 CppunitTest_sw_layoutwriter
      6 CppunitTest_chart2_import
      6 CppunitTest_vcl_complextext
      9 CppunitTest_vcl_pdfexport
     12 UITest_solver
    + failure rate higher than usual- Stephan working on the new baseline
       + now you need new gperf, flex etc.
       + thanks to Stephan for updating lode etc.
    + font related failures still hurting Windows.
    + added a new Windows / Jenkins build-slave TB39
       + not as fast as the dedicated hosts – but can do one in 1:50

* l10n (Sophie)
    + looking good. 
    + zh-TW QA workshop today
    + LibreOffice Online strings updated on pootle.
    + need to test Beta for plural forms – later today.
 
* QA update (Xisco)

    + Please help flesh out the monthly reports:
        https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 520 (-17)
        + enhancements: 61  (-4)
        + needsUXEval: 3 (+1)
        + haveBackTrace: 5 (+0)
        + needsDevAdvice: 19 (-3)
        + documentation:  5 (+1)
        + android:  14 (+0)

        + what to do with these KDE bug ? (Michael)
            + plan to keep them until 6.2 (Xisco)

        + KDE5 crashes: 4 ( -2 )
            + KDE5: Crash closing check for update dialog
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121516
            + kde5: Sporadic crash when right-clicking items in toolbar
                + https://bugs.documentfoundation.org/show_bug.cgi?id=120454
            + KDE5: Impress crashes after selecting some of Slide Transitions
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121266
            + KDE5: Impress crashes at starting Slide show (with animation...
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121247
    + Most pressing bugs:
        + New
            + Can't edit file on samba shares
                + https://bugs.documentfoundation.org/show_bug.cgi?id=115747
                    + lots of feedbackon ‘ask’ about this (Mike K)
                    + juergen funk ?
        + Older
            + Crash after accepting all changes from compared documents
                + https://bugs.documentfoundation.org/show_bug.cgi?id=109376
                + M. Stahl ? 
            + Crash restarting LibreOffice after applying an option
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121180
                + Diadlo, Bubli ? ...
            + Crashes on UNDO
                + https://bugs.documentfoundation.org/show_bug.cgi?id=120754
                + dtardon / Caolan. Its an extension, so I'm guessing that
                  one of the steps is outside undo control
            + Crash applying bold to textbox control
                + https://bugs.documentfoundation.org/show_bug.cgi?id=120750
                + Jochen Nitschke / mst ? - Xisco poked Jochen.

            + Crash in: SwIndex::SwIndex(SwIndexReg * const,long)
                + https://bugs.documentfoundation.org/show_bug.cgi?id=119989
                + bisected to Ash

            + Calc: Crash when cutting some content
                + https://bugs.documentfoundation.org/show_bug.cgi?id=118707
                + Henry Castro

        + Fixed
            + KDE5: Recent Documents -> Clear list leads to crash
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121417
                + fixed thanks to Aleksei Nikiforov 

            + Crash in: SwFEShell::IsGroupSelected()
                + https://bugs.documentfoundation.org/show_bug.cgi?id=112696
                + fixed thanks to Caolán McNamara

            + CRASH closing LibreOffice with confirmation dialog open
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121746
                + fixed thanks to Caolán McNamara

            + CRASH closing LibreOffice with Parameter dialog open
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121743
                 + fixed thanks to Caolán McNamara

            + Pressing on the "Reset" button when the writing focus is...
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121644
                 + fixed thanks to Caolán McNamara

            + Crash when closing a document (being the only active) while being prompted for data 
source password
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121607
                + fixed thanks to Caolán McNamara

            + font list box preview certain malformed TTF fonts crash LO -- when receiving 
ShouldUseWinMetrics() handling
                + https://bugs.documentfoundation.org/show_bug.cgi?id=121647
                + fixed thanks to Xisco Fauli

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +192  -35 (-130) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             23
       Heiko Tietze            12
       Buovjaga                9
       Timur                   7
       Caolán McNamara         6
       Roman Kuznetsov         4
       V Stuart Foote          4
       Julien Nabet            3
       m.a.riosv               3
       Eike Rathke             3

    + top 10 bugs reporters:
       NISZ LibreOffice Team   18
       Telesto                 11
       Xisco Faulí             8
       Pedro                   4
       Roman Kuznetsov         4
       Me                      4
       Eduardo                 3
       ammine007               3
       milupo                  3
       poul.steen              3

    + top 10 bugs fixers:
       McNamara, Caolán        7
       Xisco Faulí             6
       Drew Jensen             2
       Németh, László          2
       Krot, Serge             2
       Mohrhard, Markus        2
       Tietze, Heiko           2
       Balazs Varga            2
       Nabet, Julien           1
       Kainz, Andreas          1

    + top 10 bugs confirmers:
       Xisco Faulí             60
       Brinzing, Oliver        15
       Timur                   10
       Dieter Praas            10
       Madero, Joel            8
       Buovjaga                8
       Raal                    7
       Tietze, Heiko           6
       Xavier Van Wijmeersch   4
       Henschel, Regina        4


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 2/50 -     4 %  (+0)
     5.4 : 1/40 -     2 %  (+0)
     5.3 : 2/54 -     3 %  (+0)
     5.2 : 1/41 -     2 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 3/65 -     4 %  (+0)
     4.4 : 1/76 -     1 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 5/134 -    3 %  (+0)
     4.1 : 3/84 -     3 %  (+0)
     4.0 : 4/83 -     4 %  (+0)
     old : 19/257 -   7 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 619/2782 614/2756 609/2732 602/2702 599/2682 601/2660 595/2638 

     done by:
        Xisco Faulí           20
        Raal                   4
        Brinzing, Oliver       2
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 811/3549 801/3517 795/3494 787/3460 785/3440 785/3416 777/3392 

     done by:
        Xisco Faulí           21
        Raal                   7
        Brinzing, Oliver       2
        Drew Jensen            1
        Buovjaga               1


* all bugs tagged with 'regression'
   + 1075(+20) bugs open of 7857(+41) total 13(-1) high prio.

     done by:
        Xisco Faulí           21
        Raal                   7
        Buovjaga               3
        Drew Jensen            1
        Telesto                1
        Brinzing, Oliver       1
        Timur                  1
        Vajna, Miklos          1
        Roman Kuznetsov        1
        Lars Jødal             1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     LibreOffice   - 5(+0)
     Writer        - 4(+0)
     Calc          - 2(+0)
     graphics stack - 1(+0)
     Base          - 1(-1)

   by OS:
     Windows       - 3(+0)
     All           - 10(-1)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 282(+7)
     Calc                     - 196(+8)
     Impress                  - 114(-1)
     Writer: docx filter      - 74(-2)
     LibreOffice              - 73(+2)
     UI                       - 44(+1)
     Draw                     - 42(-1)
     Borders                  - 39(+0)
     Base                     - 36(+1)
     Writer: perf             - 36(+2)
     Writer: doc filter       - 34(+0)
     graphics stack           - 33(+1)
     Crashes                  - 31(+1)
     Writer: other filter     - 25(+0)
     filters and storage      - 24(+0)
     Chart                    - 17(-3)
     Printing and PDF export  - 15(+0)
     BASIC                    - 14(+1)
     framework                - 2(+0)
     Linguistic               - 2(+0)
     Formula Editor           - 1(+0)
     Extensions               - 1(+0)
     sdk                      - 1(+0)