Hi, On Tue, Nov 27, 2018 at 05:05:47PM +0100, Stephan Bergmann <sbergman@redhat.com> wrote:
That commit is <https://gerrit.libreoffice.org/#/c/61633/> "-Werror,-Wdeprecated-declarations (--with-macosx-version-min-required=10.14)", and I had naively assumed that Jenkins would do a baseline macOS build and flag any parts that were not supported by the baseline. And I'm not even sure what the minimum SDK we want to support should be. IIUC, Xcode may provide SDK 10.y versions newer than the macOS 10.x on which the build is done, and configure.ac will (by default) pick up the newer -with-macosx-sdk=10.y then. So README.md's "Build: 10.12 + Xcode 9.3" might not necessarily imply that we support building against SDK 10.12 (again, IIUC). Anyway, I don't really care either way, whether to fix the commit if necessary or to update the build baseline in README.md to macOS 10.13 or to clarify the SDK baseline in README.md. Do we know of any build done in an environment that should be covered by our baseline but which got broken by the above commit?
Collabora's mac builder runs 10.13, so if README.md is just adapted to reality (require 10.13 instead of 10.12), that's fine for us. It was just not clear to me, what should be fixed here: code or documentation. Regards, Miklos
Attachment:
signature.asc
Description: Digital signature